From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DD9C47082 for ; Tue, 8 Jun 2021 13:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95FE760FDB for ; Tue, 8 Jun 2021 13:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232813AbhFHNSk (ORCPT ); Tue, 8 Jun 2021 09:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231344AbhFHNSi (ORCPT ); Tue, 8 Jun 2021 09:18:38 -0400 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87469C061789 for ; Tue, 8 Jun 2021 06:16:35 -0700 (PDT) Received: by mail-ua1-x935.google.com with SMTP id 68so11541123uao.11 for ; Tue, 08 Jun 2021 06:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=606SEYScY/4Dm3TG2zXGyFR6Ly8KOu4QIRdQzAVRtJ4=; b=Omj0OjhvQ++d98yJSdmaXOk1bHCbynHCXQlXQa4ETkUydcSD2yCZsQqwxh76dHd2EN NaWVtW1fj9h0vehRKFR5saruc/HSNNc/MPrxxWz/VBlEh3plbcCVVi7mLPc/cdtEMjy+ E4WWkbPCIAG0+XNmMsGsEqTYJ8c3wLylpNI+N/iJb/Z5KHrVybXjVzqToRgJn3smF09b 2HequXh1rPYIH1tSjlB9dVMVGB4wH39RIvNrK6DiaQSouBto3Qh+jBRfLayJKOyekeb8 78E7x9hrCKxO4h4PJFuDyza3nuNy5exKSLnx8qPGVe4Glpd/4Qj0oQJR4JX72hBb4/lu rxig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=606SEYScY/4Dm3TG2zXGyFR6Ly8KOu4QIRdQzAVRtJ4=; b=MUq7pZRiu7hgZBcG7Ezlj4i/zly4GU2jNjdQsppfXEZs2rExKDCRHEo5wjigsGZkZY fcZAcEXdNv3vw7MDjbIsgz3xVD/6y2vHHGtp+dBCxRF1Qu2febbJi9G8YWekwE/RYDFL IXZFIkhxg6Wu58pe+El9SjVc5ys7e7osPygf9vA++J6FQWLr0C/jVvqyXN1wEpIzH9H1 g7eyevXRkUmSSP7quesrW7f9/YV6ProPMvGEltD+k3q4Y54pxlsEkzT+/auojICe1Lf/ u7HDJxnnSpLrzHTjyXZBnWcwFE5JCUQUD1ICewrUiObU+Rb3bkvQm4CvcrHvFM96aKAo i7Ag== X-Gm-Message-State: AOAM531n6xUq3z8UGmrIaYLcn3EBYgfEx9FkSDKCSAIV7OFmatYPxrj9 cD42OW32YLyrHj8xR8eQW1Z/nPBfCBr/uLVlvxB4bQ== X-Google-Smtp-Source: ABdhPJz5aZwPNxnntAA8aRpvQS8xefc61/tur00rKpE7jf8yvD/K9Pq7D2dgwSTb802UwSLtR5tTYL3kwFEXhrF2Jjk= X-Received: by 2002:ab0:484b:: with SMTP id c11mr3216292uad.100.1623158194715; Tue, 08 Jun 2021 06:16:34 -0700 (PDT) MIME-Version: 1.0 References: <20210607013020.85885-1-andrew@aj.id.au> In-Reply-To: <20210607013020.85885-1-andrew@aj.id.au> From: Ulf Hansson Date: Tue, 8 Jun 2021 15:15:57 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning To: Andrew Jeffery Cc: linux-mmc , Adrian Hunter , Joel Stanley , linux-aspeed , Linux ARM , Linux Kernel Mailing List , Steven Lee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Jun 2021 at 03:30, Andrew Jeffery wrote: > > The card timing and the bus frequency are not changed atomically with > respect to calls to the set_clock() callback in the driver. The result > is the driver sees a transient state where there's a mismatch between > the two and thus the inputs to the phase correction calculation > formula are garbage. > > Switch from dev_warn() to dev_dbg() to avoid noise in the normal case, > though the change does make bad configurations less likely to be > noticed. > > Reported-by: Joel Stanley > Signed-off-by: Andrew Jeffery Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c > index d001c51074a0..e4665a438ec5 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed.c > +++ b/drivers/mmc/host/sdhci-of-aspeed.c > @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz, > > tap = div_u64(phase_period_ps, prop_delay_ps); > if (tap > ASPEED_SDHCI_NR_TAPS) { > - dev_warn(dev, > + dev_dbg(dev, > "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n", > tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS); > tap = ASPEED_SDHCI_NR_TAPS; > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E313C47082 for ; Tue, 8 Jun 2021 13:19:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC286100A for ; Tue, 8 Jun 2021 13:19:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBC286100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=giyqBA/pEwjq4q1CBsyUJV9BeG1RUstIgGWNxs9sRCw=; b=s4SrTiogS22kx3 kLwVnh4cY5NfU8gezNLra8UsU89NfJguqmhVsVUiKCKCjcQ/K5USOmF3JH7rhMd0HmVEbP/vkiAFS UTFgG9l8E7bcTzXu3UR//A4PKT4eazz2cLQuEp3aEg0E4ze0BZf2cjdWCehs4b4oUFEMD7mZfnPju 19PIMbB3NHQkYtnLHLqwhW4765KpEVqgQLSO0kX0PTYuvkjJu5Ue1BR/y5Od+H13niyE0u8QrByc2 gnkc5s0GFpS927ragLndT9XgLnJoiu7v/SuuaNFCT7bMHD7YheOsWhnlQya4yj7lxN7y8xHx2BzR3 YbI5Kim501yYRseNaoFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqbby-008a4p-Lp; Tue, 08 Jun 2021 13:17:43 +0000 Received: from mail-ua1-f54.google.com ([209.85.222.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqbbs-008a32-4y for linux-arm-kernel@lists.infradead.org; Tue, 08 Jun 2021 13:17:40 +0000 Received: by mail-ua1-f54.google.com with SMTP id g34so11553599uah.8 for ; Tue, 08 Jun 2021 06:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=606SEYScY/4Dm3TG2zXGyFR6Ly8KOu4QIRdQzAVRtJ4=; b=Omj0OjhvQ++d98yJSdmaXOk1bHCbynHCXQlXQa4ETkUydcSD2yCZsQqwxh76dHd2EN NaWVtW1fj9h0vehRKFR5saruc/HSNNc/MPrxxWz/VBlEh3plbcCVVi7mLPc/cdtEMjy+ E4WWkbPCIAG0+XNmMsGsEqTYJ8c3wLylpNI+N/iJb/Z5KHrVybXjVzqToRgJn3smF09b 2HequXh1rPYIH1tSjlB9dVMVGB4wH39RIvNrK6DiaQSouBto3Qh+jBRfLayJKOyekeb8 78E7x9hrCKxO4h4PJFuDyza3nuNy5exKSLnx8qPGVe4Glpd/4Qj0oQJR4JX72hBb4/lu rxig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=606SEYScY/4Dm3TG2zXGyFR6Ly8KOu4QIRdQzAVRtJ4=; b=LdeTiX7/F/MVJDxxdmfzFiS2ltoy9/mUUPb3sh+1nLjKR28nRjfo5VVLHW7z8SMKRY v8Jnqen87iX9xivXl9e7UP01OsW5jvFkYxaomeoFa3fTf+Wc1lkAe8oZ0qBlbl6lj4mw vyYrpwTCgQsV/Ot54rpeu1hfS8UzkVk2ezU2akZ2lLq+9FnueLcM1czhtHLKbuWOO8dt 7LJ02IZkf7swAC8hcME/hZgMQfATcyP5zbG1Pmdm5uQlmCAEd5Xo5cC9mhyhM6LhHzOp VVWkZKP3WiVFtIuIhU6GW4zDALdP6U1arfBH34PcUNQngGmA0s6n3FJ+4oc50GS7nEmh a5qA== X-Gm-Message-State: AOAM533LBoR/3DBKN7JwetwwS7g/BMmdxAprn2LPND4QaAncaxvS1+S9 g+QNg4dUEBl4Ma/7aeQ8lE+y0Xgif4OKOXthkEps3ylizbp08Q== X-Google-Smtp-Source: ABdhPJz5aZwPNxnntAA8aRpvQS8xefc61/tur00rKpE7jf8yvD/K9Pq7D2dgwSTb802UwSLtR5tTYL3kwFEXhrF2Jjk= X-Received: by 2002:ab0:484b:: with SMTP id c11mr3216292uad.100.1623158194715; Tue, 08 Jun 2021 06:16:34 -0700 (PDT) MIME-Version: 1.0 References: <20210607013020.85885-1-andrew@aj.id.au> In-Reply-To: <20210607013020.85885-1-andrew@aj.id.au> From: Ulf Hansson Date: Tue, 8 Jun 2021 15:15:57 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning To: Andrew Jeffery Cc: linux-mmc , Adrian Hunter , Joel Stanley , linux-aspeed , Linux ARM , Linux Kernel Mailing List , Steven Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_061736_232809_CCA4297C X-CRM114-Status: GOOD ( 20.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 7 Jun 2021 at 03:30, Andrew Jeffery wrote: > > The card timing and the bus frequency are not changed atomically with > respect to calls to the set_clock() callback in the driver. The result > is the driver sees a transient state where there's a mismatch between > the two and thus the inputs to the phase correction calculation > formula are garbage. > > Switch from dev_warn() to dev_dbg() to avoid noise in the normal case, > though the change does make bad configurations less likely to be > noticed. > > Reported-by: Joel Stanley > Signed-off-by: Andrew Jeffery Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c > index d001c51074a0..e4665a438ec5 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed.c > +++ b/drivers/mmc/host/sdhci-of-aspeed.c > @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz, > > tap = div_u64(phase_period_ps, prop_delay_ps); > if (tap > ASPEED_SDHCI_NR_TAPS) { > - dev_warn(dev, > + dev_dbg(dev, > "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n", > tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS); > tap = ASPEED_SDHCI_NR_TAPS; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel