From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA980C433E0 for ; Tue, 16 Jun 2020 11:33:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C641320B1F for ; Tue, 16 Jun 2020 11:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nDIBdjVm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbgFPLdg (ORCPT ); Tue, 16 Jun 2020 07:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728666AbgFPLdd (ORCPT ); Tue, 16 Jun 2020 07:33:33 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FCBC08C5C3 for ; Tue, 16 Jun 2020 04:33:32 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id o2so11225850vsr.0 for ; Tue, 16 Jun 2020 04:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z4+Iz5hXHc4KqHs/Siy+ZWN5Iucm03GbQ2VElO3GIbE=; b=nDIBdjVmKagHvZo44/5GnMutd+R9LOzqdj7KoKAjZCeARsNRBWF+9cGFnYMjSfV7Vs r4303MeB7Zgsz3BHhUBei2NxgJ77BYTNOA6KEqwV2dziFSfcZeH/37omrb/OhrA2FVhN iVNLxGGtaXs8BSbxMcqI1p1jIEB5fmqAanfN0b/EtI8ut38Sql4N/26QCNTV3WypKHL7 Zt940MpjDG13b3XlCEGfJ5u6HOdKds0M50x4KT+fPeZ+d5gjJmO3/4sxjcS67kQrPfUf wAagBLnmntF9pcPlTMGp34+8QiVEPqy3ZyRCeSFCk6rky6z01YGR03XLjBKgUcGL6oXy h9+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z4+Iz5hXHc4KqHs/Siy+ZWN5Iucm03GbQ2VElO3GIbE=; b=JWutJ3S5qLlbZQNArjLGxi1Zl4JNQfTZKZEPe9PuXk549pJkhx6RfC7ZHi4U9dQQZ9 bibIH4WriG6DzQSbCZTJpL5BapuKv1Vowxpy8lubZTL/xr2i/edHI1knyHT967+Lkx5g nADkZW0aUoSRRulmuNivVnG/qLcQxx5UgZ8BVDoS8d4A5CkqD508wUTSAK05DThkv0gQ V5Bl09hVjE67bq43PGcv1MoOHCceJ+d31jGd50gq8wUIChrkotl0jhqiEOj+j1F7oc3i 6Bnejh2S+p2/ngWKi6c72z46BlkSYqAOJOErfMLIlwJnhzkWlD4fvqyilnxYazruc93V ZUfQ== X-Gm-Message-State: AOAM531d+RVmN2oDQ4J5KqUnE1W5msI8WcPLSIx3cmdA/HiCwa2GSu4p yH4+84IuWpq/EJRreA0To3OFY2D5R4mlbyUUFVbQgg== X-Google-Smtp-Source: ABdhPJyGZERfhW1QKFPZ5+rChUj0a55YKn9tZGUbhrD+eRw5UOrhMGu/7HPk1pqELV9Q/H4lqZhJMwIGM2yDSPP9sLo= X-Received: by 2002:a67:903:: with SMTP id 3mr1156423vsj.191.1592307212063; Tue, 16 Jun 2020 04:33:32 -0700 (PDT) MIME-Version: 1.0 References: <20200608162226.3259186-1-hslester96@gmail.com> In-Reply-To: <20200608162226.3259186-1-hslester96@gmail.com> From: Ulf Hansson Date: Tue, 16 Jun 2020 13:32:55 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-of-arasan: Add missed checks for devm_clk_register() To: Chuhong Yuan Cc: Adrian Hunter , Michal Simek , Heiko Stuebner , Douglas Anderson , "linux-mmc@vger.kernel.org" , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2020 at 18:22, Chuhong Yuan wrote: > > These functions do not check the return value of devm_clk_register(): > - sdhci_arasan_register_sdcardclk() > - sdhci_arasan_register_sampleclk() > > Therefore, add the missed checks to fix them. > > Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock") > Signed-off-by: Chuhong Yuan Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index db9b544465cd..fb26e743e1fd 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1299,6 +1299,8 @@ sdhci_arasan_register_sdcardclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sdcardclk_hw.init = &sdcardclk_init; > clk_data->sdcardclk = > devm_clk_register(dev, &clk_data->sdcardclk_hw); > + if (IS_ERR(clk_data->sdcardclk)) > + return PTR_ERR(clk_data->sdcardclk); > clk_data->sdcardclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > @@ -1349,6 +1351,8 @@ sdhci_arasan_register_sampleclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sampleclk_hw.init = &sampleclk_init; > clk_data->sampleclk = > devm_clk_register(dev, &clk_data->sampleclk_hw); > + if (IS_ERR(clk_data->sampleclk)) > + return PTR_ERR(clk_data->sampleclk); > clk_data->sampleclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448A1C433DF for ; Tue, 16 Jun 2020 11:33:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 182BE2098B for ; Tue, 16 Jun 2020 11:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jYQ5VLmc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nDIBdjVm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 182BE2098B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xlpdx8U9J4k8nBnAoTNCu9VnKZLgJF33A/Kq/QRzUUM=; b=jYQ5VLmcuBA8su 3G79lBWIFUvDNuJqjVT3SKco5yfnE9IgkPA0LIdiBLfJdOfwVKwnQPntLOX5c1WG8dyPlTO80c+nL 8D91FOxkfCZXelEEKu6TNain3V5MIq0scm2gcaRtFY1ETJOWJcA5pd0f+rhixk7htLC5bWvA8Ut0Y sF0yJr59UEYf/fhztj7TtnKr1GO0gIV2woN3xhfmOLZJvDXa0ooqCAhZik1g9gCVaI1/pE2R+aR05 rZitlpVy6OxBjZBhsGbEG89BnoxSTiJwa4mCyDKdCiTUfSo47TYkiUAHgA01UO55Bo9+XYe25ydhF XXtcb9c4xIvt4zhd8zjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl9qS-0005em-Ke; Tue, 16 Jun 2020 11:33:36 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl9qP-0005cs-Hh for linux-arm-kernel@lists.infradead.org; Tue, 16 Jun 2020 11:33:35 +0000 Received: by mail-vs1-xe44.google.com with SMTP id 190so11192760vsr.9 for ; Tue, 16 Jun 2020 04:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z4+Iz5hXHc4KqHs/Siy+ZWN5Iucm03GbQ2VElO3GIbE=; b=nDIBdjVmKagHvZo44/5GnMutd+R9LOzqdj7KoKAjZCeARsNRBWF+9cGFnYMjSfV7Vs r4303MeB7Zgsz3BHhUBei2NxgJ77BYTNOA6KEqwV2dziFSfcZeH/37omrb/OhrA2FVhN iVNLxGGtaXs8BSbxMcqI1p1jIEB5fmqAanfN0b/EtI8ut38Sql4N/26QCNTV3WypKHL7 Zt940MpjDG13b3XlCEGfJ5u6HOdKds0M50x4KT+fPeZ+d5gjJmO3/4sxjcS67kQrPfUf wAagBLnmntF9pcPlTMGp34+8QiVEPqy3ZyRCeSFCk6rky6z01YGR03XLjBKgUcGL6oXy h9+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z4+Iz5hXHc4KqHs/Siy+ZWN5Iucm03GbQ2VElO3GIbE=; b=mrfPwBdfHKhJsXSKdl59m69gGRwgCSHlsQkrlnmO/z8smm2fMwVXEf34vsOXBQYlq5 C25tZN0szih52cPDpMvey72La17NXsVzpTLYU1g4jNItvZsx4H3e6NjY66iipXXKN0ql xEbKEVtNuK2JmCpZReCVkcmzz7fdxwhyVnplczZ4WhkrBADHBmxK9ccBrNx2NLsDDogc rNvNSucmxJVycEiGcjsIlxgx2ErUqsyDZnRREawH8tQUVaQxqvxvVYTt0mMOf3vKBgGq Qz6ZzmfUot3LNMMH/Ra6oWK77YkxT4xkbCKCFX9FyQVPcjxuqi1sf3LEzWLoyphSCeZM YQ6A== X-Gm-Message-State: AOAM531v+UzhkBuWM4aO1A0Z/ZTIVgR/BIXMePkOOjYTJ3bFzEMe2H/+ sxzT6z/W3N0ARu23rA81rT0RfyEHRX24y+ev88pvUQ== X-Google-Smtp-Source: ABdhPJyGZERfhW1QKFPZ5+rChUj0a55YKn9tZGUbhrD+eRw5UOrhMGu/7HPk1pqELV9Q/H4lqZhJMwIGM2yDSPP9sLo= X-Received: by 2002:a67:903:: with SMTP id 3mr1156423vsj.191.1592307212063; Tue, 16 Jun 2020 04:33:32 -0700 (PDT) MIME-Version: 1.0 References: <20200608162226.3259186-1-hslester96@gmail.com> In-Reply-To: <20200608162226.3259186-1-hslester96@gmail.com> From: Ulf Hansson Date: Tue, 16 Jun 2020 13:32:55 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-of-arasan: Add missed checks for devm_clk_register() To: Chuhong Yuan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_043333_621619_A0A7BB3E X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , Douglas Anderson , Adrian Hunter , Michal Simek , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 8 Jun 2020 at 18:22, Chuhong Yuan wrote: > > These functions do not check the return value of devm_clk_register(): > - sdhci_arasan_register_sdcardclk() > - sdhci_arasan_register_sampleclk() > > Therefore, add the missed checks to fix them. > > Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock") > Signed-off-by: Chuhong Yuan Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index db9b544465cd..fb26e743e1fd 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1299,6 +1299,8 @@ sdhci_arasan_register_sdcardclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sdcardclk_hw.init = &sdcardclk_init; > clk_data->sdcardclk = > devm_clk_register(dev, &clk_data->sdcardclk_hw); > + if (IS_ERR(clk_data->sdcardclk)) > + return PTR_ERR(clk_data->sdcardclk); > clk_data->sdcardclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > @@ -1349,6 +1351,8 @@ sdhci_arasan_register_sampleclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sampleclk_hw.init = &sampleclk_init; > clk_data->sampleclk = > devm_clk_register(dev, &clk_data->sampleclk_hw); > + if (IS_ERR(clk_data->sampleclk)) > + return PTR_ERR(clk_data->sampleclk); > clk_data->sampleclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > -- > 2.26.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel