From: Ulf Hansson <ulf.hansson@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Danny Lin <danny@kdrag0n.dev>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8150: Add support for deep CPU cluster idle
Date: Tue, 12 Jan 2021 11:09:31 +0100 [thread overview]
Message-ID: <CAPDyKFru7X1Wi3EUBoy-EVaxJ+-rTdhhtArJ9P5RC1ZMak9U+A@mail.gmail.com> (raw)
In-Reply-To: <X/Tw13VgA5fOnlCV@ripper>
+ Lina
On Wed, 6 Jan 2021 at 00:05, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Tue 05 Jan 12:10 PST 2021, Danny Lin wrote:
>
> > This commit adds support for deep idling of the entire unified DynamIQ
> > CPU cluster on sm8150. In this idle state, the LLCC (Last-Level Cache
> > Controller) is powered off and the AOP (Always-On Processor) enters a
> > low-power sleep state.
> >
> > I'm not sure what the per-CPU 0x400000f4 idle state previously
> > contributed by Qualcomm as the "cluster sleep" state is, but the
> > downstream kernel has no such state. The real deep cluster idle state
> > is 0x41000c244, composed of:
> >
> > Cluster idle state: (0xc24) << 4 = 0xc240
> > Is reset state: 1 << 30 = 0x40000000
> > Affinity level: 1 << 24 = 0x1000000
> > CPU idle state: 0x4 (power collapse)
> >
> > This setup can be replicated with the PSCI power domain cpuidle driver,
> > which utilizes OSI to enter cluster idle when the last active CPU
> > enters idle.
> >
> > The cluster idle state cannot be used as a plain cpuidle state because
> > it requires that all CPUs in the cluster are idling.
> >
>
> This looks quite reasonable to me.
>
> @Ulf, this seems to be the first attempt at wiring up the domain idle
> pieces upstream, would you mind having a look?
Certainly I can have a look, but I could find the original posted
patch. I had a look at the below changes and it looks good to me. Feel
free to add my reviewed-by tag for it.
Also note, the db410c was the first one to support this as introduced
in commit e37131556801 for v5.6. You may have a look at
arch/arm64/boot/dts/qcom/msm8916.dtsi.
Kind regards
Uffe
>
> The SM8150 pretty much identical to RB3 in this regard.
>
> Regards,
> Bjorn
>
> > Signed-off-by: Danny Lin <danny@kdrag0n.dev>
> > ---
> > arch/arm64/boot/dts/qcom/sm8150.dtsi | 91 ++++++++++++++++++++++------
> > 1 file changed, 73 insertions(+), 18 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > index 309e00b6fa44..8956c6986744 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -52,10 +52,10 @@ CPU0: cpu@0 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <488>;
> > dynamic-power-coefficient = <232>;
> > - cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_0>;
> > qcom,freq-domain = <&cpufreq_hw 0>;
> > + power-domains = <&CPU_PD0>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_0: l2-cache {
> > compatible = "cache";
> > @@ -73,10 +73,10 @@ CPU1: cpu@100 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <488>;
> > dynamic-power-coefficient = <232>;
> > - cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_100>;
> > qcom,freq-domain = <&cpufreq_hw 0>;
> > + power-domains = <&CPU_PD1>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_100: l2-cache {
> > compatible = "cache";
> > @@ -92,10 +92,10 @@ CPU2: cpu@200 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <488>;
> > dynamic-power-coefficient = <232>;
> > - cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_200>;
> > qcom,freq-domain = <&cpufreq_hw 0>;
> > + power-domains = <&CPU_PD2>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_200: l2-cache {
> > compatible = "cache";
> > @@ -110,10 +110,10 @@ CPU3: cpu@300 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <488>;
> > dynamic-power-coefficient = <232>;
> > - cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_300>;
> > qcom,freq-domain = <&cpufreq_hw 0>;
> > + power-domains = <&CPU_PD3>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_300: l2-cache {
> > compatible = "cache";
> > @@ -128,10 +128,10 @@ CPU4: cpu@400 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <1024>;
> > dynamic-power-coefficient = <369>;
> > - cpu-idle-states = <&BIG_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_400>;
> > qcom,freq-domain = <&cpufreq_hw 1>;
> > + power-domains = <&CPU_PD4>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_400: l2-cache {
> > compatible = "cache";
> > @@ -146,10 +146,10 @@ CPU5: cpu@500 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <1024>;
> > dynamic-power-coefficient = <369>;
> > - cpu-idle-states = <&BIG_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_500>;
> > qcom,freq-domain = <&cpufreq_hw 1>;
> > + power-domains = <&CPU_PD5>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_500: l2-cache {
> > compatible = "cache";
> > @@ -164,10 +164,10 @@ CPU6: cpu@600 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <1024>;
> > dynamic-power-coefficient = <369>;
> > - cpu-idle-states = <&BIG_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_600>;
> > qcom,freq-domain = <&cpufreq_hw 1>;
> > + power-domains = <&CPU_PD6>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_600: l2-cache {
> > compatible = "cache";
> > @@ -182,10 +182,10 @@ CPU7: cpu@700 {
> > enable-method = "psci";
> > capacity-dmips-mhz = <1024>;
> > dynamic-power-coefficient = <421>;
> > - cpu-idle-states = <&BIG_CPU_SLEEP_0
> > - &CLUSTER_SLEEP_0>;
> > next-level-cache = <&L2_700>;
> > qcom,freq-domain = <&cpufreq_hw 2>;
> > + power-domains = <&CPU_PD7>;
> > + power-domain-names = "psci";
> > #cooling-cells = <2>;
> > L2_700: l2-cache {
> > compatible = "cache";
> > @@ -251,11 +251,13 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
> > min-residency-us = <4488>;
> > local-timer-stop;
> > };
> > + };
> >
> > + domain-idle-states {
> > CLUSTER_SLEEP_0: cluster-sleep-0 {
> > - compatible = "arm,idle-state";
> > + compatible = "domain-idle-state";
> > idle-state-name = "cluster-power-collapse";
> > - arm,psci-suspend-param = <0x400000F4>;
> > + arm,psci-suspend-param = <0x4100c244>;
> > entry-latency-us = <3263>;
> > exit-latency-us = <6562>;
> > min-residency-us = <9987>;
> > @@ -291,6 +293,59 @@ pmu {
> > psci {
> > compatible = "arm,psci-1.0";
> > method = "smc";
> > +
> > + CPU_PD0: cpu0 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&LITTLE_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD1: cpu1 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&LITTLE_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD2: cpu2 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&LITTLE_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD3: cpu3 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&LITTLE_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD4: cpu4 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&BIG_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD5: cpu5 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&BIG_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD6: cpu6 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&BIG_CPU_SLEEP_0>;
> > + };
> > +
> > + CPU_PD7: cpu7 {
> > + #power-domain-cells = <0>;
> > + power-domains = <&CLUSTER_PD>;
> > + domain-idle-states = <&BIG_CPU_SLEEP_0>;
> > + };
> > +
> > + CLUSTER_PD: cpu-cluster0 {
> > + #power-domain-cells = <0>;
> > + domain-idle-states = <&CLUSTER_SLEEP_0>;
> > + };
> > };
> >
> > reserved-memory {
> > --
> > 2.29.2
> >
next prev parent reply other threads:[~2021-01-12 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 20:10 [PATCH] arm64: dts: qcom: sm8150: Add support for deep CPU cluster idle Danny Lin
2021-01-05 23:05 ` Bjorn Andersson
2021-01-12 10:09 ` Ulf Hansson [this message]
2021-01-12 14:22 ` Bjorn Andersson
2021-01-15 14:20 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFru7X1Wi3EUBoy-EVaxJ+-rTdhhtArJ9P5RC1ZMak9U+A@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=danny@kdrag0n.dev \
--cc=devicetree@vger.kernel.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.