From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h Date: Tue, 24 Jan 2017 08:57:51 +0100 Message-ID: References: <1484313256-25993-1-git-send-email-ulf.hansson@linaro.org> <1484313256-25993-2-git-send-email-ulf.hansson@linaro.org> <87efzydusi.fsf@belgarion.home> <87a8aleda2.fsf@belgarion.home> <87y3y3crxl.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87y3y3crxl.fsf@belgarion.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robert Jarzmik Cc: Linus Walleij , "linux-mmc@vger.kernel.org" , Adrian Hunter , Haojian Zhuang , Jaehoon Chung , "linux-arm-kernel@lists.infradead.org" , Daniel Mack List-Id: linux-mmc@vger.kernel.org On 22 January 2017 at 11:25, Robert Jarzmik wrote: > Robert Jarzmik writes: > >> Ulf Hansson writes: >> >>> On 20 January 2017 at 09:01, Robert Jarzmik wrote: >>>> Ulf Hansson writes: >>>> So I was wondering how you made the choice of which files you add the include to >>>> and which you don't touch ? >>> >>> By building the pxa_defconfig, see what errors it reports and then fix them. >>> >>> Isn't pxa_defconfig building all the variants? >> Euh actually it should, but it's not. > > And actually thanks to a suggestion from Russell to improve my search line, I > came up with the command line bellow, and perhaps you could fix the others with > one command line and respin the patch ? > > Here it is : > > for f in $(grep -l _led arch/arm/mach-pxa/*.c | xargs grep -L linux/leds.h); do > sed -i '0,/^#include $/{s/\(#include \n\1/}' $f; done > > Cheers. Robert, thanks for helping out! While running the above command-line, the following files becomes changed: arch/arm/mach-pxa/zylonite_pxa300.c arch/arm/mach-pxa/zylonite_pxa320.c arch/arm/mach-pxa/palmld.c arch/arm/mach-pxa/palmtc.c arch/arm/mach-pxa/ezx.c arch/arm/mach-pxa/em-x270.c arch/arm/mach-pxa/hx4700.c arch/arm/mach-pxa/magician.c arch/arm/mach-pxa/palmtreo.c arch/arm/mach-pxa/corgi_pm.c arch/arm/mach-pxa/spitz_pm.c arch/arm/mach-pxa/tosa.c arch/arm/mach-pxa/z2.c However, already by building pxa_defconfig, I have verified that these files are being build successfully without any changes needed. Because of that, I am not sure I would like to make any additional changes as a part of this series. I think it's easier if you later on deal with that as clean-ups via your pxa tree instead, does that make sense to you as well? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Tue, 24 Jan 2017 08:57:51 +0100 Subject: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h In-Reply-To: <87y3y3crxl.fsf@belgarion.home> References: <1484313256-25993-1-git-send-email-ulf.hansson@linaro.org> <1484313256-25993-2-git-send-email-ulf.hansson@linaro.org> <87efzydusi.fsf@belgarion.home> <87a8aleda2.fsf@belgarion.home> <87y3y3crxl.fsf@belgarion.home> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22 January 2017 at 11:25, Robert Jarzmik wrote: > Robert Jarzmik writes: > >> Ulf Hansson writes: >> >>> On 20 January 2017 at 09:01, Robert Jarzmik wrote: >>>> Ulf Hansson writes: >>>> So I was wondering how you made the choice of which files you add the include to >>>> and which you don't touch ? >>> >>> By building the pxa_defconfig, see what errors it reports and then fix them. >>> >>> Isn't pxa_defconfig building all the variants? >> Euh actually it should, but it's not. > > And actually thanks to a suggestion from Russell to improve my search line, I > came up with the command line bellow, and perhaps you could fix the others with > one command line and respin the patch ? > > Here it is : > > for f in $(grep -l _led arch/arm/mach-pxa/*.c | xargs grep -L linux/leds.h); do > sed -i '0,/^#include $/{s/\(#include \n\1/}' $f; done > > Cheers. Robert, thanks for helping out! While running the above command-line, the following files becomes changed: arch/arm/mach-pxa/zylonite_pxa300.c arch/arm/mach-pxa/zylonite_pxa320.c arch/arm/mach-pxa/palmld.c arch/arm/mach-pxa/palmtc.c arch/arm/mach-pxa/ezx.c arch/arm/mach-pxa/em-x270.c arch/arm/mach-pxa/hx4700.c arch/arm/mach-pxa/magician.c arch/arm/mach-pxa/palmtreo.c arch/arm/mach-pxa/corgi_pm.c arch/arm/mach-pxa/spitz_pm.c arch/arm/mach-pxa/tosa.c arch/arm/mach-pxa/z2.c However, already by building pxa_defconfig, I have verified that these files are being build successfully without any changes needed. Because of that, I am not sure I would like to make any additional changes as a part of this series. I think it's easier if you later on deal with that as clean-ups via your pxa tree instead, does that make sense to you as well? Kind regards Uffe