All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xo Wang <xow@google.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Eddie James <eajames@linux.vnet.ibm.com>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	 "Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius
Date: Fri, 14 Jul 2017 15:54:18 -0700	[thread overview]
Message-ID: <CAPH-5w4TQnpAby2q2nFi58iCUtB9c07mHx+nOHdAN4676OtN4w@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XdMbJsov9o-OWHNw8RPwXSJgMuVrdouT5w8zQAne7omkQ@mail.gmail.com>

On Wed, Jul 12, 2017 at 6:04 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Thu, Jul 13, 2017 at 5:36 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
>> From: "Edward A. James" <eajames@us.ibm.com>
>>
>> Missing label, properties, and include file.
>>
>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>
> Hey Xo, can I get an ack on this?
>
> Cheers,
>
> Joel
>

Ah, missed this.

Thanks.

Acked-by: Xo Wang <xow@google.com>

>> ---
>>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> index c620015..750ec12 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
>> @@ -71,10 +71,10 @@
>>                 };
>>         };
>>
>> -       gpio-fsi {
>> +       fsi: gpio-fsi {
>>                 compatible = "fsi-master-gpio", "fsi-master";
>> -
>> -               status = "okay";
>> +               #address-cells = <2>;
>> +               #size-cells = <0>;
>>
>>                 /*
>>                  * These 2 GPIOs are set per board revision in aspeed.c.
>> @@ -96,6 +96,8 @@
>>         };
>>  };
>>
>> +#include "ibm-power9-cfam.dtsi"
>> +
>>  &fmc {
>>         status = "okay";
>>         flash@0 {
>> --
>> 1.8.3.1
>>

  parent reply	other threads:[~2017-07-14 22:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 20:06 [PATCH linux dev-4.10] ARM: dts: aspeed: Add FSI devices for Zaius Eddie James
2017-07-13  1:04 ` Joel Stanley
2017-07-14 12:26   ` Andrew Geissler
2017-07-14 22:54   ` Xo Wang [this message]
2017-07-19  9:11     ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPH-5w4TQnpAby2q2nFi58iCUtB9c07mHx+nOHdAN4676OtN4w@mail.gmail.com \
    --to=xow@google.com \
    --cc=eajames@linux.vnet.ibm.com \
    --cc=eajames@us.ibm.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.