All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Balažic" <xerces9@gmail.com>
To: linux-ppp@vger.kernel.org
Subject: Re: PPPoE Modem hangup after random time - how to debug?
Date: Sun, 03 May 2020 10:31:51 +0000	[thread overview]
Message-ID: <CAPJ9Yc8eDBsGtFy_juZ3Z6biKKD4-JoNg0icv4otHK=o66aBZw@mail.gmail.com> (raw)
In-Reply-To: <CAPJ9Yc8Wvxb_UoqGu=wrrWX2HP5AwE98jvcS3XYnvevxa0RZpg@mail.gmail.com>

On Wed, 22 Apr 2020 at 19:45, David Balažic <xerces9@gmail.com> wrote:
>
> Hi!
>
> I have a router running openwrt connected to a GPON ONT, running a
> PPPoE connection (hw details below).
>
> The problem is, that after some random time one to 20 hours, the
> connection breaks. Then in about a minute it reconnects (successfully,
> each time).

Mystery solved.

I added a debug output to kernel pppoe.c:

pr_info("pppoe: pppoe_disc_rcv /my patch/  PADT received, sid=%d, SRC:
%02x:%02x:%02x:%02x:%02x:%02x, DST: %02x:%02x:%02x:%02x:%02x:%02x\n",
ph->sid,
eth_hdr(skb)->h_source[0],
eth_hdr(skb)->h_source[1],
eth_hdr(skb)->h_source[2],
eth_hdr(skb)->h_source[3],
eth_hdr(skb)->h_source[4],
eth_hdr(skb)->h_source[5],
eth_hdr(skb)->h_dest[0],
eth_hdr(skb)->h_dest[1],
eth_hdr(skb)->h_dest[2],
eth_hdr(skb)->h_dest[3],
eth_hdr(skb)->h_dest[4],
eth_hdr(skb)->h_dest[5]
);

When the problem happens, it prints:

pppoe: pppoe_disc_rcv /my patch/  PADT received, sid=1, SRC:
a4:7b:2c:9e:c7:44, DST: 44:4e:6d:fd:c7:39

My HWaddr is c4:xxxxxx:ed

After that, the pppoe module closes the connection.

So the problem was as already suspected, that pppoe does not properly
check if the received PADT packet belongs to its ppp session.

I'll patch it up soon (if someone does not beat me to it).

Regards,
David

  parent reply	other threads:[~2020-05-03 10:31 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 17:45 PPPoE Modem hangup after random time - how to debug? David Balažic
2020-04-22 19:51 ` Michael Richardson
2020-04-22 22:00 ` James Carlson
2020-04-23  0:08 ` Guillaume Nault
2020-04-23  0:41 ` Michael Richardson
2020-04-23  2:01 ` James Carlson
2020-04-23 10:37 ` David Balažic
2020-04-23 11:12 ` David Balažic
2020-04-23 12:13 ` David Balažic
2020-04-23 15:59 ` Michael Richardson
2020-04-23 16:01 ` Michael Richardson
2020-04-24 13:47 ` David Balažic
2020-04-24 14:02 ` David Balažic
2020-04-24 14:26 ` James Carlson
2020-04-24 15:44 ` Guillaume Nault
2020-04-24 15:54 ` Guillaume Nault
2020-04-26  1:38 ` Michael Richardson
2020-04-26 12:44 ` David Balažic
2020-04-26 12:48 ` David Balažic
2020-04-26 19:03 ` David Balažic
2020-04-27  2:14 ` Michael Richardson
2020-04-27  9:59 ` David Balažic
2020-04-27 13:43 ` James Carlson
2020-04-27 20:08 ` Guillaume Nault
2020-04-27 20:30 ` Guillaume Nault
2020-04-27 23:34 ` David Balažic
2020-04-28 10:18 ` David Balažic
2020-04-28 11:00 ` Guillaume Nault
2020-04-29 11:58 ` David Balažic
2020-05-03 10:31 ` David Balažic [this message]
2020-05-04 12:27 ` Guillaume Nault
2020-05-04 13:01 ` Guillaume Nault
2020-05-04 15:54 ` David Balažic
2020-05-04 16:36 ` David Balažic
2020-05-04 18:11 ` Guillaume Nault
2020-05-04 18:43 ` David Balažic
2020-05-06  9:52 ` David Balažic
2020-05-06 10:34 ` David Balažic
2020-05-06 14:26 ` Guillaume Nault
2020-05-06 15:02 ` Guillaume Nault
2020-05-06 15:15 ` James Carlson
2020-05-06 15:39 ` David Balažic
2020-05-06 15:54 ` David Balažic
2020-05-06 20:20 ` Guillaume Nault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPJ9Yc8eDBsGtFy_juZ3Z6biKKD4-JoNg0icv4otHK=o66aBZw@mail.gmail.com' \
    --to=xerces9@gmail.com \
    --cc=linux-ppp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.