From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbcARPXW (ORCPT ); Mon, 18 Jan 2016 10:23:22 -0500 Received: from mail-ig0-f194.google.com ([209.85.213.194]:33720 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755471AbcARPXT (ORCPT ); Mon, 18 Jan 2016 10:23:19 -0500 MIME-Version: 1.0 In-Reply-To: <2182115.GafOXid1Dx@vostro.rjw.lan> References: <20160118021138.GA20498@dtor-ws> <2182115.GafOXid1Dx@vostro.rjw.lan> Date: Mon, 18 Jan 2016 15:23:18 +0000 X-Google-Sender-Auth: s54Jsvj26eG1iRgy_bijchyhl9I Message-ID: Subject: Re: [PATCH] driver-core: platform: automatically mark wakeup devices From: Sudeep Holla To: "Rafael J. Wysocki" Cc: Dmitry Torokhov , Greg Kroah-Hartman , Rob Herring , Grant Likely , Linus Walleij , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , open list , "Rafael J. Wysocki" , Sudeep Holla Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2016 at 2:47 PM, Rafael J. Wysocki wrote: > On Sunday, January 17, 2016 06:11:38 PM Dmitry Torokhov wrote: >> When probing platform drivers let's check if corresponding devices have >> "wakeup-source" property defined (either in device tree, ACPI, or static >> platform properties) and automatically enable such devices as wakeup >> sources for the system. This will help us standardize on the name for this >> property and reduce amount of boilerplate code in the drivers. > > ACPI has other ways of telling the OS that the device is wakeup-capable, > but I guess the property in question can be used too (as long as it is > consistent with the other methods). > Just curious to know what you mean when you say this property can also be used with ACPI. Do you mean we could use "wakeup-source" DSD ? If so, won't that go against rule for DSD (i.e we *should not* bypass the existing mechanisms defined by the ACPI, e.g. _SxW in this case) -- Regards, Sudeep