From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Murphy Subject: Re: [PATCH 5/9] iommu/amd: Implement .flush_np_cache Date: Mon, 15 Apr 2019 19:18:21 +0100 Message-ID: References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-6-tmurphy@arista.com> <20190415063351.GD1377@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190415063351.GD1377@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , joerg.roedel@amd.com Cc: iommu@lists.linux-foundation.org, Heiko Stuebner , Will Deacon , David Brown , linux-samsung-soc@vger.kernel.org, Dmitry Safonov , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Andy Gross , Marc Zyngier , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Murphy , Robin Murphy List-Id: linux-arm-msm@vger.kernel.org This is a cut and paste from the current amd_iommu driver. I really have no idea if it's a good idea or not. It looks like joerg.roedel@amd.com might be the person to ask. @Joerg Roedel should we keep this? On Mon, Apr 15, 2019 at 7:33 AM Christoph Hellwig wrote: > > > +static void amd_iommu_flush_np_cache(struct iommu_domain *domain, > > + unsigned long iova, size_t size) > > +{ > > + struct protection_domain *dom = to_pdomain(domain); > > + > > + if (unlikely(amd_iommu_np_cache)) { > > Is this case really so unlikely that it needs a static branch prediction > hint? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D202C10F12 for ; Mon, 15 Apr 2019 18:18:35 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECA0D218D3 for ; Mon, 15 Apr 2019 18:18:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=arista.com header.i=@arista.com header.b="lqM8lYOI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECA0D218D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lists.linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id AB3067A4; Mon, 15 Apr 2019 18:18:34 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3088C9D for ; Mon, 15 Apr 2019 18:18:34 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A365D1C0 for ; Mon, 15 Apr 2019 18:18:33 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id h4so23209095wre.7 for ; Mon, 15 Apr 2019 11:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1LJvGvqo7EljAGlBTh6710IRHlpdfD0Ibty+Og7VIs=; b=lqM8lYOIQB81gsmtbP1nJNVx4mZZO5/MZXUp4nrAfy5hCneDvE+LT7DRbcSZ+vT5w+ 8Z+fNRmscXd7SfXljaH0efEYbA+KkrUxKliSiPRWQAPBNgM1FIA906HvgxblReyYKTHU j8LeUtxto25qoK6+fw9eQv3BOIT6ARquaNiCohdgqpqDrGC6udqGA9mBG4jF53xIVtPL l3OD1MDU63TkjVGr7thOD4MUikHJQ8WbDu7MvOLwOEZwRNtxQeJGbzmakKx3gAHeKKM2 gjZYEpQfL4ibR9od1F3Lg63SyP9zyA+GC0ox5wvadKD0M3QijlKCpH2+BdB05tV2yLQr tXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1LJvGvqo7EljAGlBTh6710IRHlpdfD0Ibty+Og7VIs=; b=aC9LUjsLeXZzZYLqi3tFiJ0Uoa6yftRN6sO82rZLFwwM69LTH42OJWV2vJvRJA8bxJ ok7Ma5Wdeeh313E8/EzF/TWOAiHjTraEYjLnOffBfg5sF4TjLOv1qdO8F3rZ8/YrTJ8O mIvhrulqDY8/B2u9WoT8mJAbd+S5EUmy5DVcPk8C8reMMQs/pB5pNygyKU+86yLlYa2I jSnJ4DNeN4iJBt4BFEgk3m4+1Im6p9h1MQ95kclczU4gJ+7Td7QS8q7lARv8U0R3b/lX Np8iuMbp1b0x+c5YmrTU/j0urWqX1gK4njwPmNFPYMPEorepS2EtJh1u81lpn2IMmxKz JZcg== X-Gm-Message-State: APjAAAUWrSXBh0j5gJukWU+10IcpDiCYTs/Cf3/aNiP2OKyXHJ9AO6sx EOUyMcNB4cwug4QWxMNrxhgc+yepMtrpCmqgVrTPaw== X-Google-Smtp-Source: APXvYqxVk2bkWycU3o5K58SYGSp4ltI2LOn3syZyyGeORJ//WKM7JLPKIJw3GKGgcDj57E9sgAZ1FsR4Wuedc1W8lKs= X-Received: by 2002:adf:e6c6:: with SMTP id y6mr49415491wrm.225.1555352312329; Mon, 15 Apr 2019 11:18:32 -0700 (PDT) MIME-Version: 1.0 References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-6-tmurphy@arista.com> <20190415063351.GD1377@infradead.org> In-Reply-To: <20190415063351.GD1377@infradead.org> Date: Mon, 15 Apr 2019 19:18:21 +0100 Message-ID: Subject: Re: [PATCH 5/9] iommu/amd: Implement .flush_np_cache To: Christoph Hellwig , joerg.roedel@amd.com Cc: linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Dmitry Safonov , Marc Zyngier , linux-arm-msm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , David Brown , iommu@lists.linux-foundation.org, Kukjin Kim , linux-mediatek@lists.infradead.org, Tom Murphy , Andy Gross , linux-rockchip@lists.infradead.org, Thomas Gleixner , Robin Murphy , linux-arm-kernel@lists.infradead.org, Matthias Brugger X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Murphy via iommu Reply-To: Tom Murphy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190415181821.SfCxgaHnclR31sUhdXTqbw0fvPtmEh1JcedcwEHLBf8@z> This is a cut and paste from the current amd_iommu driver. I really have no idea if it's a good idea or not. It looks like joerg.roedel@amd.com might be the person to ask. @Joerg Roedel should we keep this? On Mon, Apr 15, 2019 at 7:33 AM Christoph Hellwig wrote: > > > +static void amd_iommu_flush_np_cache(struct iommu_domain *domain, > > + unsigned long iova, size_t size) > > +{ > > + struct protection_domain *dom = to_pdomain(domain); > > + > > + if (unlikely(amd_iommu_np_cache)) { > > Is this case really so unlikely that it needs a static branch prediction > hint? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5E9C10F0E for ; Mon, 15 Apr 2019 18:18:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0461B205ED for ; Mon, 15 Apr 2019 18:18:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pYscy5/e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=arista.com header.i=@arista.com header.b="lqM8lYOI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0461B205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=arista.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O8O+g5LsibRvvy8ZWs3XAy0LgmHt+ya/xAG25mesJW0=; b=pYscy5/exAfCP0 Ysp+4UEerR0lGsA5fqKs7CzPT0oyqXPX/aQvMxIvRziC+IrXfryS7vRo1W0Ui9HXfa+JpTv7zikqi u/RhsHFh4PBYM2vIDiA5bFLtG+x3P/73sYcRyzeQvgGg6d6PgfP4+DpFuxhYxnJ0+aHzur+SUU3tn 5LZkthEKyk8x7pp6bz+O9GP2+gudVRWesygjvnl35sQlTI6mOxvjErCTjatrnpJtIrSSRYmPWfE2c xOShqTJF5jYLKielDMFqvmbg3J3IJlqDdlhjM+YhafDOmEkYme7zA8YCd5xBEtrWSC/3apHRif4IZ RT7IPI3r/QlhJo55S5oA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG6Bo-0002nr-Iq; Mon, 15 Apr 2019 18:18:44 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG6Be-0002aw-3S for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 18:18:37 +0000 Received: by mail-wr1-x443.google.com with SMTP id w10so23235004wrm.4 for ; Mon, 15 Apr 2019 11:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1LJvGvqo7EljAGlBTh6710IRHlpdfD0Ibty+Og7VIs=; b=lqM8lYOIQB81gsmtbP1nJNVx4mZZO5/MZXUp4nrAfy5hCneDvE+LT7DRbcSZ+vT5w+ 8Z+fNRmscXd7SfXljaH0efEYbA+KkrUxKliSiPRWQAPBNgM1FIA906HvgxblReyYKTHU j8LeUtxto25qoK6+fw9eQv3BOIT6ARquaNiCohdgqpqDrGC6udqGA9mBG4jF53xIVtPL l3OD1MDU63TkjVGr7thOD4MUikHJQ8WbDu7MvOLwOEZwRNtxQeJGbzmakKx3gAHeKKM2 gjZYEpQfL4ibR9od1F3Lg63SyP9zyA+GC0ox5wvadKD0M3QijlKCpH2+BdB05tV2yLQr tXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1LJvGvqo7EljAGlBTh6710IRHlpdfD0Ibty+Og7VIs=; b=VLpYosCeMcd54+VkgkiRs3N9fY/sr2H0H1vdUL6NO72cehuKYMLIWBjgeqNzCvC/Mc BYsF/XKvtpj/FGksx4S3tSDRz0Rdl8d1Sjo0YDw6rK26zsVs8Ds/uYBi1OphHsTq1wXN VK1AKmhobgYKMKHyO+Pnzqxe8Mahr63dAkchWqZZDzV3hVtZHzQzEnx09hase4K1+aHl EepUX85kgFv1kSnwBN9x5OGLuD54u7lrWn+I3azu5YGPOymymupZBuKO7Ymn/fxfMO2W 8bHS/LJrbdpmO7epqPjuTewTZj8P96JrTEuInffq8Bjqjv5n06BRg6ASzeDeaEzrvc8f H5WQ== X-Gm-Message-State: APjAAAXrF06Cq6YWf+rE9p83aQqBKw1OjMc+WNafrFcGdZSh7ebuxaeI bVdovM486XuKu7DSG4XbnIBzhCIwXeQBP0GB2IfktA== X-Google-Smtp-Source: APXvYqxVk2bkWycU3o5K58SYGSp4ltI2LOn3syZyyGeORJ//WKM7JLPKIJw3GKGgcDj57E9sgAZ1FsR4Wuedc1W8lKs= X-Received: by 2002:adf:e6c6:: with SMTP id y6mr49415491wrm.225.1555352312329; Mon, 15 Apr 2019 11:18:32 -0700 (PDT) MIME-Version: 1.0 References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-6-tmurphy@arista.com> <20190415063351.GD1377@infradead.org> In-Reply-To: <20190415063351.GD1377@infradead.org> From: Tom Murphy Date: Mon, 15 Apr 2019 19:18:21 +0100 Message-ID: Subject: Re: [PATCH 5/9] iommu/amd: Implement .flush_np_cache To: Christoph Hellwig , joerg.roedel@amd.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_111834_663575_743A3D47 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Dmitry Safonov , Marc Zyngier , linux-arm-msm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , David Brown , iommu@lists.linux-foundation.org, Kukjin Kim , linux-mediatek@lists.infradead.org, Tom Murphy , Andy Gross , linux-rockchip@lists.infradead.org, Thomas Gleixner , Robin Murphy , linux-arm-kernel@lists.infradead.org, Matthias Brugger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a cut and paste from the current amd_iommu driver. I really have no idea if it's a good idea or not. It looks like joerg.roedel@amd.com might be the person to ask. @Joerg Roedel should we keep this? On Mon, Apr 15, 2019 at 7:33 AM Christoph Hellwig wrote: > > > +static void amd_iommu_flush_np_cache(struct iommu_domain *domain, > > + unsigned long iova, size_t size) > > +{ > > + struct protection_domain *dom = to_pdomain(domain); > > + > > + if (unlikely(amd_iommu_np_cache)) { > > Is this case really so unlikely that it needs a static branch prediction > hint? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel