From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7262C433EF for ; Tue, 5 Oct 2021 12:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBA1861166 for ; Tue, 5 Oct 2021 12:10:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234684AbhJEMMj (ORCPT ); Tue, 5 Oct 2021 08:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234354AbhJEMMh (ORCPT ); Tue, 5 Oct 2021 08:12:37 -0400 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389DAC06174E for ; Tue, 5 Oct 2021 05:10:47 -0700 (PDT) Received: by mail-vs1-xe30.google.com with SMTP id y141so7714663vsy.5 for ; Tue, 05 Oct 2021 05:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+FpzWH2ZIdZS8P9itXj17dRdXa9ruIevTcz0+5q7b4=; b=aEQ2lypF9WQGoGPdcJLUpnDkTaoqHtURxtHwBWjypLxQS8mzf1Yhik2f1k4oyyevB+ v5JWYANFC7eDUs2ckJJj+NPbd6QMWEmrQXkJ1R7I1U1/q5IjAxzXMuVLB4wkZXQ3ad27 h3RiUotm3GY8rlULHtMoBV24PMHZGcA3nCAAd7b5zurKu+MCtR0RfEE90U1PODP6QwIJ GVcGhoG9UnAjRZrdu636fj3X49dKe94ShjN4rdcakPLQrDPU6Bcyae2uI4hkNkVkbSLc ZnIWqtI3yOPnGq17eny2S1CdLo8I8MJSIuyVoC3jgKRXZjPWCpxD9kwiIA6QzdYgEzEJ G2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+FpzWH2ZIdZS8P9itXj17dRdXa9ruIevTcz0+5q7b4=; b=7zhB1x1ujnpCRvTdx7JpewwPsMyEZJmScihzqC88ac2ExkdLdIxcbm9v/cbSEC9cE0 2En0djv37qAv3h6gbrhKF18JCydUG2ReXHlo2ToRI9njUOcoUZysi0T6+kS0RrmkeieY dIGOJPXBcqPbTCsldG5I/l6HhytGJfMTbH7eHRbIDdTeY1J12QEUmmTaakK8y2n7bSTG ieyiRLWGzlEWIkrX4QsQYwRUAioddCtA2OJITZzEO4qozmJ3fu9PZ2CoM3ldc0bHHupJ K6DJN/TsFiK0yTzGFAfPsKh2Ln9t67ZohEbLq62JYN4B0mAUC0kyL2XtHPvXfmFyL8Dq DGtQ== X-Gm-Message-State: AOAM531gocqEqGYoG6NlkAgQEABUU3irIA5pnzOXyvbF1t3DjG510BOG M5j5Ly1ShScV13JkXWFj7nujUsZMfqCr23XWwTBbPw== X-Google-Smtp-Source: ABdhPJwQPm67yxGJ4FtMJNzBWUpDBn/qkdjLiKqVJgWGXq0/bbGz9rz8oI9e2wECpt3qr8rlikCAs/B7DNWrOT5XQuM= X-Received: by 2002:a67:1781:: with SMTP id 123mr17945675vsx.1.1633435846315; Tue, 05 Oct 2021 05:10:46 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-4-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-4-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:10:34 +0300 Message-ID: Subject: Re: [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > After converting the Exynos ChipID and ASV driver to a module, allow to > actually choose it to be a module, while being a default built-in. The > side effect is that driver could be now entirely disabled even for > kernel with ARCH_EXYNOS, but this is not a critical issue because driver > is not necessary for the proper platform boot. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 5a48abac6af4..30f930e20599 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -13,7 +13,6 @@ menuconfig ARCH_EXYNOS > select ARM_GIC > select EXYNOS_IRQ_COMBINER > select COMMON_CLK_SAMSUNG > - select EXYNOS_CHIPID > select EXYNOS_THERMAL > select EXYNOS_PMU > select EXYNOS_SROM > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index fe139f26d093..e2cedef1e8d1 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,8 +13,9 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" > depends on ARCH_EXYNOS || COMPILE_TEST > + default ARCH_EXYNOS > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA2CC433F5 for ; Tue, 5 Oct 2021 12:13:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63D6161166 for ; Tue, 5 Oct 2021 12:13:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63D6161166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0wN7gcy75mrsZppJhwQ0RRSuOiViHMwE+gRWP0h9X3I=; b=P5h5rRjnlY7DEz xdqNB3an8pX8BuI3NX+HT+x7fxUkT0NVjbsVkFmlrwyTQu0tKLaVlodyryzYJVPXyE8TEyZXSPi+/ ajci8IacyZR2WrSMA/hVfaDX6lcy4vVDn+gk/u/+xqQrozNQ0nS/bEWvYi0ZExoXH3fapfHTqDzUz M6bRGujM12aAvRJESMvFg3vZbzwagmhpRbjAOk0VdhPc8xotOEmN9y+4jRWULWKmHDF619zR9AfuX PhP5MICsbl0/3OPKFWF8/+6kyJMTWNKLC5Uumh2FTA13RDkOapvCMbH98R2G/e1jrfI3EwGbMJQbC SpjwDTZ/dzsh0eWf4i1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjHe-00AHzU-1x; Tue, 05 Oct 2021 12:10:58 +0000 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjHU-00AHwj-7Z for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 12:10:49 +0000 Received: by mail-vs1-xe2d.google.com with SMTP id y14so9425754vsm.9 for ; Tue, 05 Oct 2021 05:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+FpzWH2ZIdZS8P9itXj17dRdXa9ruIevTcz0+5q7b4=; b=aEQ2lypF9WQGoGPdcJLUpnDkTaoqHtURxtHwBWjypLxQS8mzf1Yhik2f1k4oyyevB+ v5JWYANFC7eDUs2ckJJj+NPbd6QMWEmrQXkJ1R7I1U1/q5IjAxzXMuVLB4wkZXQ3ad27 h3RiUotm3GY8rlULHtMoBV24PMHZGcA3nCAAd7b5zurKu+MCtR0RfEE90U1PODP6QwIJ GVcGhoG9UnAjRZrdu636fj3X49dKe94ShjN4rdcakPLQrDPU6Bcyae2uI4hkNkVkbSLc ZnIWqtI3yOPnGq17eny2S1CdLo8I8MJSIuyVoC3jgKRXZjPWCpxD9kwiIA6QzdYgEzEJ G2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+FpzWH2ZIdZS8P9itXj17dRdXa9ruIevTcz0+5q7b4=; b=KULLx+Tw2yXVAfVV5IX4M2H2FnYw1p3aigf33g83gEi7PipgAbVldBKn4dDwj62m71 Ij04vg1zSmtoUp8PmPAU7vpm8VCoqmpNHzQUq6onQk/zs8y9tRNSSa5KAJW/l+8MfbFh aEqPnUGCioyUVCgAP6KfJj2zgNQaWDZxG6NBu2SNENni2/8IEBBH+dGnE84voXUrxdTu K3xICn6r0BAyPnxJu2k8sVWcbV/LhxMyNpgCXduTE26hDQtYHDG26Fq8k8hYrUNFL0jT AbyDcMSqtG/2T1XYQRRdikkOEmZs5FAWWaptkeG/N1YsH9Q98cifaC74u3EBh272vAbZ B6bg== X-Gm-Message-State: AOAM533ZnA8TMa1lg3Y7OXM3OfEUz3PMisyPKq/QSYhXlvPTrGNmA0Fn r+YER9uP5Rt7mt+oOLt/whOjSxvn0Cg7ves0B35JGQ== X-Google-Smtp-Source: ABdhPJwQPm67yxGJ4FtMJNzBWUpDBn/qkdjLiKqVJgWGXq0/bbGz9rz8oI9e2wECpt3qr8rlikCAs/B7DNWrOT5XQuM= X-Received: by 2002:a67:1781:: with SMTP id 123mr17945675vsx.1.1633435846315; Tue, 05 Oct 2021 05:10:46 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-4-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-4-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:10:34 +0300 Message-ID: Subject: Re: [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_051048_306954_A6E55E9F X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > After converting the Exynos ChipID and ASV driver to a module, allow to > actually choose it to be a module, while being a default built-in. The > side effect is that driver could be now entirely disabled even for > kernel with ARCH_EXYNOS, but this is not a critical issue because driver > is not necessary for the proper platform boot. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 5a48abac6af4..30f930e20599 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -13,7 +13,6 @@ menuconfig ARCH_EXYNOS > select ARM_GIC > select EXYNOS_IRQ_COMBINER > select COMMON_CLK_SAMSUNG > - select EXYNOS_CHIPID > select EXYNOS_THERMAL > select EXYNOS_PMU > select EXYNOS_SROM > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index fe139f26d093..e2cedef1e8d1 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,8 +13,9 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" > depends on ARCH_EXYNOS || COMPILE_TEST > + default ARCH_EXYNOS > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel