From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1738C433EF for ; Mon, 11 Oct 2021 10:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6E7C60F21 for ; Mon, 11 Oct 2021 10:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235860AbhJKKP1 (ORCPT ); Mon, 11 Oct 2021 06:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235756AbhJKKPW (ORCPT ); Mon, 11 Oct 2021 06:15:22 -0400 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E90FEC061570 for ; Mon, 11 Oct 2021 03:13:22 -0700 (PDT) Received: by mail-vs1-xe2e.google.com with SMTP id o15so13556205vsr.13 for ; Mon, 11 Oct 2021 03:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I14GHi8jxA3YeP5lUl6dG6cQQNqNA9f8zkpHem77AXE=; b=Iyead7c/Yz9/z8w1zLsuQQXRN4N9xsgHIwvPRw/5EPRjx2VnCODWhctr4Zs1zxLkWb G9c640BWp1yyOHh6XjFuA8iTnplnJpinYbPCbzWjInweK3g0JNuVsxSKbQsdY8Gs+G2Y I1As+3Yr3qRokQ+zh87zcBVd8FZDuCiza/MhyN7QbvuoGUXultzStxQ3/I2iw3p4BnqE WuQZhEpseiPXvquKDoxG0hLuhdWnH6J0v8PNr8pk320ZMCsqsxCax71j/LNfTo69lke/ 7YNCGaiUKNHPRcgUEFrErclqNB7aB0hjQCL5wJ3zpu0NZqfdtkbnul2qjydbvn9INcNe 3DSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I14GHi8jxA3YeP5lUl6dG6cQQNqNA9f8zkpHem77AXE=; b=aUZk0O56h47l4Jx+bwde8QQRnF5eJmdpp50m5gg7mw2R2IBd5Jd3FjoWaPlY/NcpoF Hq/CGLH9WqKV6Kn0O+a9kX7atbub55dyi2zFuswH+rfDKyUGdyQ5j0RYQik8eEoSvE6I ecnSpjGYaTpoXP0u6kOEyBweuuas8/Ia27Nto44J4onpGgdVtZfU5GVhPMJj0Fn2xL6r ZBU1zvGi/fzP4pg1xbZFdrTbT+0lL65lRpYc61zWfzQGdFFo6VrfQyL6U+C+yK5Jva4O 1dqzq5I+xNr4zV1q8SBn3I0KVow7s66uMrrKPm8Ak1NaGfEXUFn4dFP5jgO9Hjty2dW6 WYlQ== X-Gm-Message-State: AOAM530QtY2ktIP9rqRd4Vq5eAVq8QA6fZnWX02Fg5HWracYigLpEMBh xsXOIe9xznt1oTw7PMXuEfYbb6f/idTm4ny7EO5fry6oAGoJYuXD X-Google-Smtp-Source: ABdhPJzGhrvtSadLZJqKqJT3TOK0uyxaeX4nkcu5WKwayrjByJLIRU9CZUQy7omYuptslyvwrSEi19f6Q6iSlbAHsv4= X-Received: by 2002:a67:ed5a:: with SMTP id m26mr21164272vsp.35.1633947202056; Mon, 11 Oct 2021 03:13:22 -0700 (PDT) MIME-Version: 1.0 References: <20211008154352.19519-1-semen.protsenko@linaro.org> <20211008154352.19519-5-semen.protsenko@linaro.org> <7049b3a9-dc8f-2ae9-01e6-eb3b6f461400@kernel.org> In-Reply-To: <7049b3a9-dc8f-2ae9-01e6-eb3b6f461400@kernel.org> From: Sam Protsenko Date: Mon, 11 Oct 2021 13:13:10 +0300 Message-ID: Subject: Re: [PATCH v3 4/5] dt-bindings: clock: Document Exynos850 CMU bindings To: Sylwester Nawrocki Cc: Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , Linux Kernel Mailing List , Linux Samsung SOC , Krzysztof Kozlowski , Sylwester Nawrocki , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , Chanwoo Choi , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 Oct 2021 at 23:41, Sylwester Nawrocki wrote: > > On 08.10.2021 17:43, Sam Protsenko wrote: > > Provide dt-schema documentation for Exynos850 SoC clock controller. > > > > Signed-off-by: Sam Protsenko > > Reviewed-by: Krzysztof Kozlowski > > Acked-by: Chanwoo Choi > > > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > > new file mode 100644 > > index 000000000000..79202e6e6402 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > > @@ -0,0 +1,185 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/samsung,exynos850-clock.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos850 SoC clock controller > > + > > +maintainers: > > + - Sam Protsenko > > + - Chanwoo Choi > > + - Krzysztof Kozlowski > > + - Sylwester Nawrocki > > + - Tomasz Figa > > + > > +description: | > > + Exynos850 clock controller is comprised of several CMU units, generating > > + clocks for different domains. Those CMU units are modeled as separate device > > + tree nodes, and might depend on each other. Root clocks in that clock tree are > > + two external clocks:: OSCCLK (26 MHz) and RTCCLK (32768 Hz). Those external > > + clocks must be defined as fixed-rate clocks in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > > + dividers; all other leaf clocks (other CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this identifier > > + to specify the clock which they consume. All clocks that available for usage > > s/All clocks that available/All clocks available ? > No need to resend, I can amend it when applying. > Yeah, not a native speaker, I tend to do such mistakes sometimes :) Please fix when applying. Btw, I can see that you already applied 3 out of 5 patches from this patch series here: [1]. Can you please also apply the rest, or is there any outstanding comments that I missed? [1] https://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk.git/log/?h=for-v5.16/next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECC5C433F5 for ; Mon, 11 Oct 2021 10:15:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81C9160F22 for ; Mon, 11 Oct 2021 10:15:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 81C9160F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cbrpBf1sCAP4C7ql04AeTF1JnpJBjlZ0ZHLF6GocT84=; b=E4gxZbqN9NVnDc WNmS3/uT5pks7/MlNZJmePX+iDoqKjEOZWUQUHnGHr4BzPZZbgnpeaeY0zxhC2R7X/YIhTHOrISCX /X6/Rjiu8zmCTDWcU6bnOHzc1ixGxmxVLz26qAb5bpJGetYoQoYi8zk8XfPFFOZJA6eerjmO6BPr8 Xw4CVZc1L3Y8B6WeAPwtugzTqRx/eczyMhnCmI+yvYzxrIW8SljuZcHGaibgThFUjSbfhy+Q7j1p+ 0kmXE+CjQx7zxkQnv2yjznWwyOFy4SCFnNbPZhzz7SviY6JaXCxnE39rnlcQVkig+wYKvpb8mm7K2 I9owxkqnkemy/6RaYc5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZsJE-008nmy-SW; Mon, 11 Oct 2021 10:13:30 +0000 Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZsJA-008nkz-5R for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 10:13:25 +0000 Received: by mail-vs1-xe30.google.com with SMTP id 188so18500233vsv.0 for ; Mon, 11 Oct 2021 03:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I14GHi8jxA3YeP5lUl6dG6cQQNqNA9f8zkpHem77AXE=; b=Iyead7c/Yz9/z8w1zLsuQQXRN4N9xsgHIwvPRw/5EPRjx2VnCODWhctr4Zs1zxLkWb G9c640BWp1yyOHh6XjFuA8iTnplnJpinYbPCbzWjInweK3g0JNuVsxSKbQsdY8Gs+G2Y I1As+3Yr3qRokQ+zh87zcBVd8FZDuCiza/MhyN7QbvuoGUXultzStxQ3/I2iw3p4BnqE WuQZhEpseiPXvquKDoxG0hLuhdWnH6J0v8PNr8pk320ZMCsqsxCax71j/LNfTo69lke/ 7YNCGaiUKNHPRcgUEFrErclqNB7aB0hjQCL5wJ3zpu0NZqfdtkbnul2qjydbvn9INcNe 3DSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I14GHi8jxA3YeP5lUl6dG6cQQNqNA9f8zkpHem77AXE=; b=z2jd1I/qjbBvAKYZ71/or5z9oPJOW/w2DwqeSRn1OxjIIKC4gNW5yy4gybXkOxMr9X GTIvpvhmXeNcDpn84744lo0cF/g4SLX0KlncOZvWcN1AeLqxejIYqWQdqc8+SI1QySxY K4FPUyZgfPAbOCc8RWjJe+pglhsdnGRcq8oUateG6zvuRGuKCoNrKsFKr8HfjVcu3EDU 2lJ7PSYymvFF71qaGMf0XvFASSwG1yt1wDBqFzbaZauZEcCcUDtONyQnp6hzggVzdaPR iGPrjkzr0Uyyckdwqu4oTDOb7vEKDKTTdJ1JI7Xf1jvQxwrdacfy7HncvQDP4TwQFCnX 7Cqg== X-Gm-Message-State: AOAM533LigdTopG/BaiFU0355IkX8Ya5iA4DDtMtElRJkqqGhjw8OC0U XJ6SRIIWF8YHRbrs1npt0FsbZepwYt80nCzzGnJy5g== X-Google-Smtp-Source: ABdhPJzGhrvtSadLZJqKqJT3TOK0uyxaeX4nkcu5WKwayrjByJLIRU9CZUQy7omYuptslyvwrSEi19f6Q6iSlbAHsv4= X-Received: by 2002:a67:ed5a:: with SMTP id m26mr21164272vsp.35.1633947202056; Mon, 11 Oct 2021 03:13:22 -0700 (PDT) MIME-Version: 1.0 References: <20211008154352.19519-1-semen.protsenko@linaro.org> <20211008154352.19519-5-semen.protsenko@linaro.org> <7049b3a9-dc8f-2ae9-01e6-eb3b6f461400@kernel.org> In-Reply-To: <7049b3a9-dc8f-2ae9-01e6-eb3b6f461400@kernel.org> From: Sam Protsenko Date: Mon, 11 Oct 2021 13:13:10 +0300 Message-ID: Subject: Re: [PATCH v3 4/5] dt-bindings: clock: Document Exynos850 CMU bindings To: Sylwester Nawrocki Cc: Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , Linux Kernel Mailing List , Linux Samsung SOC , Krzysztof Kozlowski , Sylwester Nawrocki , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , Chanwoo Choi , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_031324_257275_C9BA8C79 X-CRM114-Status: GOOD ( 22.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 9 Oct 2021 at 23:41, Sylwester Nawrocki wrote: > > On 08.10.2021 17:43, Sam Protsenko wrote: > > Provide dt-schema documentation for Exynos850 SoC clock controller. > > > > Signed-off-by: Sam Protsenko > > Reviewed-by: Krzysztof Kozlowski > > Acked-by: Chanwoo Choi > > > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > > new file mode 100644 > > index 000000000000..79202e6e6402 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > > @@ -0,0 +1,185 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/samsung,exynos850-clock.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos850 SoC clock controller > > + > > +maintainers: > > + - Sam Protsenko > > + - Chanwoo Choi > > + - Krzysztof Kozlowski > > + - Sylwester Nawrocki > > + - Tomasz Figa > > + > > +description: | > > + Exynos850 clock controller is comprised of several CMU units, generating > > + clocks for different domains. Those CMU units are modeled as separate device > > + tree nodes, and might depend on each other. Root clocks in that clock tree are > > + two external clocks:: OSCCLK (26 MHz) and RTCCLK (32768 Hz). Those external > > + clocks must be defined as fixed-rate clocks in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > > + dividers; all other leaf clocks (other CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this identifier > > + to specify the clock which they consume. All clocks that available for usage > > s/All clocks that available/All clocks available ? > No need to resend, I can amend it when applying. > Yeah, not a native speaker, I tend to do such mistakes sometimes :) Please fix when applying. Btw, I can see that you already applied 3 out of 5 patches from this patch series here: [1]. Can you please also apply the rest, or is there any outstanding comments that I missed? [1] https://git.kernel.org/pub/scm/linux/kernel/git/snawrocki/clk.git/log/?h=for-v5.16/next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel