From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C542C43217 for ; Tue, 21 Dec 2021 12:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237425AbhLUMKK (ORCPT ); Tue, 21 Dec 2021 07:10:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237410AbhLUMKJ (ORCPT ); Tue, 21 Dec 2021 07:10:09 -0500 Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F8F7C061746 for ; Tue, 21 Dec 2021 04:10:09 -0800 (PST) Received: by mail-vk1-xa35.google.com with SMTP id u198so8025864vkb.13 for ; Tue, 21 Dec 2021 04:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ywE2wpW05e6e2QZaQTpP58GvLD74b2rkAJqlWUowmCc=; b=QbBRef6nW930vco2pV2wG94SZ1qWOjymi1QT8iGl9e263UDkeJe9IGCvKaeU8bQRCd eNYPgChVVVtngwS0c7Ne/r5KqoPgN5ciSAbOy5i3v8Fpa7Pou6sWseMYr/vDxFjbuKF8 zS2YbUnDO4qh0Vk82+SY9vMuKZzQxGEWgdXhQ/77QfQ+dsZPyxUW7GTpe4a38jXQQ0+I Y/eSMiCyFWyqRy6My34oIbwdNHb4X3NDgDl1bPkoXJLR08ng1wuXfJKcnYQiB7f3Ffsh dLM7iYf1GaKv3ohqAsQO34oQnaFkHrYdJET7HTDjWite8ncZWyr41csQglY+zfAxBusu s6oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ywE2wpW05e6e2QZaQTpP58GvLD74b2rkAJqlWUowmCc=; b=oyJfQRtVBJIXlyGPX6iduDQMGImX9LXXanjAQU3/Vv2IOLQWjDqQVX9SPca1Xxg5dv mqOQc/ueiLIqBcvergV5CZyTzp3MGMhVntI6kIUKdDSPStv7sUs3Aa77LtnPcTR/7pHk My/zHceGeJnsqVAcJbtXy0mQU9CuNjrUIC+3RL4SHlElI/25ciyJYJXfLwotgOeAr/A8 XJlCKcHiAulfv8+/a2tUoEIVfqaf52xjrbQiiLbyDSFMTdJcS1gyplzP8BUAipzFTf5Q WG8Z1/WpzaJ8En8w9Buh7czbq0cxvA5xi/mUxJ7nEKmJgzsswgzTLvf2bk9CemqAZmyW fQww== X-Gm-Message-State: AOAM532mjBm/lJ7q+qY8qpo6XhaGFd43BFLcGpv9sm3gpfOQi85o18ur XrvD/6YIXHvsp4dFJKRqwzvJYOVelQDKXC2ovNXwZA== X-Google-Smtp-Source: ABdhPJzPkIG0HQ2hdBNtswKDaMWmHQN7fmzn9zABEvpB4VQXYtrRqfmUsSSalENZnUPxHjjWEz8LBANx+HOfpCMlso4= X-Received: by 2002:a1f:b20b:: with SMTP id b11mr1044228vkf.13.1640088608342; Tue, 21 Dec 2021 04:10:08 -0800 (PST) MIME-Version: 1.0 References: <20211217161549.24836-1-semen.protsenko@linaro.org> <20211217161549.24836-2-semen.protsenko@linaro.org> <2fdc5c97-6c19-8e70-d717-28b29d86160c@kernel.org> <5bd5c0bf-4390-22c2-e4e0-cb02b80dfb9c@canonical.com> In-Reply-To: From: Sam Protsenko Date: Tue, 21 Dec 2021 14:09:56 +0200 Message-ID: Subject: Re: [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Sylwester Nawrocki , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Dec 2021 at 10:19, Krzysztof Kozlowski wrote: > > On 20/12/2021 15:55, Sam Protsenko wrote: > > On Mon, 20 Dec 2021 at 11:31, Krzysztof Kozlowski > > wrote: > >> > >> On 19/12/2021 23:29, Sylwester Nawrocki wrote: > >>> On 17.12.2021 17:15, Sam Protsenko wrote: > >>>> System Register is used to configure system behavior, like USI protocol, > >>>> etc. SYSREG clocks should be provided to corresponding syscon nodes, to > >>>> make it possible to modify SYSREG registers. > >>>> > >>>> While at it, add also missing PMU and GPIO clocks, which looks necessary > >>>> and might be needed for corresponding Exynos850 features soon. > >>>> > >>>> Reviewed-by: Krzysztof Kozlowski > >>>> Acked-by: Rob Herring > >>>> Acked-by: Chanwoo Choi > >>>> Signed-off-by: Sam Protsenko > >>> > >>> Apologies for late reply, this patch is applied now. > >>> > >> > >> Sam, > >> > >> The clock is used in the DTSI, so since this was applied, there are only > >> two choices now: > >> 1. wait for next cycle with DTSI and DTS, > >> 2. Resubmit with replacing the newly added clocks in DTSI/DTS with > >> numbers and a TODO note. > >> > > > > But why? I thought because Sylwester applied my clock patches, those > > will get into v5.17, and so DTSI/DTS might rely on those clocks? If I > > get it wrong, please let me know why, and I'll go with item (2) you > > suggested. > > If I apply the DTSI+DTS, all my builds will start failing. The > linux-next (since Sylwester's tree is included) should build fine, but > my tree won't be buildable anymore. Then arm-soc pulls my tree and gets > said because it does not build. Later, Linus will be unhappy if he pulls > arm-soc (thus mine) before clock tree. > I see. Thanks for the explanation! > Other solution, instead of using raw numbers, is to copy-paste the clock > macros you use directly in DTSI and do not include the clock header. > This actually might be cleaner choice - changes will be limited to one > place in DTSI. > Will do so in v5. > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A53CC433EF for ; Tue, 21 Dec 2021 12:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BYKKTLECk627bA+5bD2QIXq0cGol25br1GsFrjhDff8=; b=F5jeyE8rlTkO09 Huv77JRvwMfTt8bOlfGnEGm3jAj/KNUHMh/p3lYD5+vM16e1afuSIpM0xh2O2OwflzeftCiiJBJm4 hkGWo0kH0s9i3J0l/Mdd1fT2ZQQdItOuQLxs8/SAbyvnPrPGMBjy7yZqnX1EKFmztemKC5+1/YZdt VOIa3qKx5r254u/lPlkLdz3EwCjCqks/lP5zeP+73MgUiP+THW5tD7DluEVfGwt8L8ZqHVgLFKh6d RNRFcBAZzigTitcoRX9Iz6nUAPmkVdDhU22/svRzVcPcOQK0BM/gC9K/ZXgBoax7OzYWrrTSQPZec 0eNQj/ROJ4C34GMRQsew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzdyB-006h9B-Ex; Tue, 21 Dec 2021 12:10:15 +0000 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzdy5-006h78-Hb for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 12:10:11 +0000 Received: by mail-vk1-xa32.google.com with SMTP id o2so8079940vkn.0 for ; Tue, 21 Dec 2021 04:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ywE2wpW05e6e2QZaQTpP58GvLD74b2rkAJqlWUowmCc=; b=QbBRef6nW930vco2pV2wG94SZ1qWOjymi1QT8iGl9e263UDkeJe9IGCvKaeU8bQRCd eNYPgChVVVtngwS0c7Ne/r5KqoPgN5ciSAbOy5i3v8Fpa7Pou6sWseMYr/vDxFjbuKF8 zS2YbUnDO4qh0Vk82+SY9vMuKZzQxGEWgdXhQ/77QfQ+dsZPyxUW7GTpe4a38jXQQ0+I Y/eSMiCyFWyqRy6My34oIbwdNHb4X3NDgDl1bPkoXJLR08ng1wuXfJKcnYQiB7f3Ffsh dLM7iYf1GaKv3ohqAsQO34oQnaFkHrYdJET7HTDjWite8ncZWyr41csQglY+zfAxBusu s6oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ywE2wpW05e6e2QZaQTpP58GvLD74b2rkAJqlWUowmCc=; b=Hm+IjJtXF3NE5p5wtzHTyfsmkWi1i57W6F1sQcVwPosARx3HMEDhfplxzQlvxOLste THNKBZbSl6nqxUi+e+FTDdQkK1DDcrrcf87RrZLPrC5O58DfVVfUkFecLnsEYdech5Go fj/N2FV+tBsZAXP7SEm5FBbYNpzCZ4dbqvRaFqXVmr46t3oq8midi4RB1K/BX+Ow1CmR VgX8werKj7SUqi4whrk9av6OjDfpgfQuE02Py32x4YGWWIP7MKXpbl/ztYpT/uq5AM9G VecvegtFAb3gydLx59htYsRQ+cpOWX9EMii58WvbpT7EwRfTN5V0ZmpYku0QFj5lF3An iOVg== X-Gm-Message-State: AOAM533ZC5jFuQSDF7wcT5edww61MyEKwIqgxoqrfMc01ULeVF/Q2yAD 1dG9Dt+wwBhVPUeXmTCJ2iuL+VD8KyIO5iDIWMoE1g== X-Google-Smtp-Source: ABdhPJzPkIG0HQ2hdBNtswKDaMWmHQN7fmzn9zABEvpB4VQXYtrRqfmUsSSalENZnUPxHjjWEz8LBANx+HOfpCMlso4= X-Received: by 2002:a1f:b20b:: with SMTP id b11mr1044228vkf.13.1640088608342; Tue, 21 Dec 2021 04:10:08 -0800 (PST) MIME-Version: 1.0 References: <20211217161549.24836-1-semen.protsenko@linaro.org> <20211217161549.24836-2-semen.protsenko@linaro.org> <2fdc5c97-6c19-8e70-d717-28b29d86160c@kernel.org> <5bd5c0bf-4390-22c2-e4e0-cb02b80dfb9c@canonical.com> In-Reply-To: From: Sam Protsenko Date: Tue, 21 Dec 2021 14:09:56 +0200 Message-ID: Subject: Re: [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Sylwester Nawrocki , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_041009_663476_35D087F5 X-CRM114-Status: GOOD ( 25.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 21 Dec 2021 at 10:19, Krzysztof Kozlowski wrote: > > On 20/12/2021 15:55, Sam Protsenko wrote: > > On Mon, 20 Dec 2021 at 11:31, Krzysztof Kozlowski > > wrote: > >> > >> On 19/12/2021 23:29, Sylwester Nawrocki wrote: > >>> On 17.12.2021 17:15, Sam Protsenko wrote: > >>>> System Register is used to configure system behavior, like USI protocol, > >>>> etc. SYSREG clocks should be provided to corresponding syscon nodes, to > >>>> make it possible to modify SYSREG registers. > >>>> > >>>> While at it, add also missing PMU and GPIO clocks, which looks necessary > >>>> and might be needed for corresponding Exynos850 features soon. > >>>> > >>>> Reviewed-by: Krzysztof Kozlowski > >>>> Acked-by: Rob Herring > >>>> Acked-by: Chanwoo Choi > >>>> Signed-off-by: Sam Protsenko > >>> > >>> Apologies for late reply, this patch is applied now. > >>> > >> > >> Sam, > >> > >> The clock is used in the DTSI, so since this was applied, there are only > >> two choices now: > >> 1. wait for next cycle with DTSI and DTS, > >> 2. Resubmit with replacing the newly added clocks in DTSI/DTS with > >> numbers and a TODO note. > >> > > > > But why? I thought because Sylwester applied my clock patches, those > > will get into v5.17, and so DTSI/DTS might rely on those clocks? If I > > get it wrong, please let me know why, and I'll go with item (2) you > > suggested. > > If I apply the DTSI+DTS, all my builds will start failing. The > linux-next (since Sylwester's tree is included) should build fine, but > my tree won't be buildable anymore. Then arm-soc pulls my tree and gets > said because it does not build. Later, Linus will be unhappy if he pulls > arm-soc (thus mine) before clock tree. > I see. Thanks for the explanation! > Other solution, instead of using raw numbers, is to copy-paste the clock > macros you use directly in DTSI and do not include the clock header. > This actually might be cleaner choice - changes will be limited to one > place in DTSI. > Will do so in v5. > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel