From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F6DC433F5 for ; Fri, 29 Oct 2021 13:15:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FC4C60724 for ; Fri, 29 Oct 2021 13:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbhJ2NSG (ORCPT ); Fri, 29 Oct 2021 09:18:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhJ2NSF (ORCPT ); Fri, 29 Oct 2021 09:18:05 -0400 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A07C061714 for ; Fri, 29 Oct 2021 06:15:36 -0700 (PDT) Received: by mail-ua1-x92e.google.com with SMTP id x3so17972392uar.13 for ; Fri, 29 Oct 2021 06:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+Jn0Zb4XSWTtnsH7XrcWpFd+2PsMM1WYmSDBWFjSHk=; b=b9E/lRCvOBOQR1o3F7Fxr20iMUVtSJUqUxSOg6lRP3YmV//6oeIM13YCK+fke+bnix g/gii88LV1Ol2o5XiRcBIF1zdz7LNiNUU3EERvs0w4Fw75e8TzfH38xw3lE72l3P+OwA rh8RmIzbnE3CrIp8PKTRJ+pAfHgm6aMlFZwZ+EBoy4c877CzsdbrvddazYth9n8HKb4K 3lU5bFpLNwATuM534+CbMr5KoLDzQtq4rikxLyka3CLMScSCnkYR+xcl/2oCN55jH8Eo InKF8BKDFNs8H53aXzh5N7Kd7gHP5DDx7fv9lZ9a1SnvETzyYPbpzU3dboZYmSWxXA15 Ubnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+Jn0Zb4XSWTtnsH7XrcWpFd+2PsMM1WYmSDBWFjSHk=; b=xT6gXn+wKqSjEL9yZW2ZMuLqJNNgy8OX3EireQc9/4cWWq2SdfKVdFcLyil5uix7qW jSPZSlgs3DXO2cpTciYfb09JzqHHPE8mPggYaBVoH5TMmFAKtckkS8cZwFIGn8bp57io qLOOJggBVZjs9zS5ZF5+pTryAGQ9qd6+30sYyYfvKK7rHuJ2QX2Ik6zrZVrFcJ8imr9o lKUvRIM28kPwwn3G/Kak0kznBkE277wAtUovokFiGHL7UGkLydryjiPVXpMMmciNDfPH gJeTwijjiQqWrGwfMuorvgSYpnnS6Tyt0eIuTYELG/cQ92VyD72+ndj0uWEw5azvsMHA Kd7w== X-Gm-Message-State: AOAM531uswxpDXtXJiTm3PkjNcj+1pDYHGbM1LchRFDQgU98t38Tzz/t ysTfIrD6KvkwLXo1JXdOmP+4ZavjNhBS4bKUrVteQQ== X-Google-Smtp-Source: ABdhPJy54z6tvSJScJqF6AXYv4loNJuYfD/YEcFaxZYwl0OrIXfWSnt5RuDHqPLB8WOr+h4A+o6iGm8c/SKmN0YaQr8= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr12138135vsm.55.1635513336043; Fri, 29 Oct 2021 06:15:36 -0700 (PDT) MIME-Version: 1.0 References: <20211026115916.31553-1-semen.protsenko@linaro.org> <8b3466f1-2b16-80ca-79c7-577860fc90aa@canonical.com> In-Reply-To: From: Sam Protsenko Date: Fri, 29 Oct 2021 16:15:24 +0300 Message-ID: Subject: Re: [PATCH] arm64: Kconfig: Enable MCT timer for ARCH_EXYNOS To: Marek Szyprowski Cc: Krzysztof Kozlowski , linux-arm Mailing List , Linux Kernel Mailing List , Linux Samsung SOC , Mark Rutland , Chanwoo Choi , Will Deacon , Marc Zyngier , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Oct 2021 at 14:38, Marek Szyprowski wrote: > > On 28.10.2021 16:35, Krzysztof Kozlowski wrote: > > On 28/10/2021 16:22, Sam Protsenko wrote: > >> On Tue, 26 Oct 2021 at 17:03, Krzysztof Kozlowski > >> wrote: > >>> On 26/10/2021 13:59, Sam Protsenko wrote: > >>>> Some ARM64 Exynos SoCs have MCT timer block, e.g. Exynos850 and > >>>> Exynos5433. CLKSRC_EXYNOS_MCT option is not visible unless COMPILE_TEST > >>>> is enabled. Select CLKSRC_EXYNOS_MCT option for ARM64 ARCH_EXYNOS like > >>>> it's done in arch/arm/mach-exynos/Kconfig, to enable MCT timer support > >>>> for ARM64 Exynos SoCs. > >>>> > >>>> Signed-off-by: Sam Protsenko > >>>> --- > >>>> arch/arm64/Kconfig.platforms | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>> +CC Marek, Marc, Mark and Chanwoo, > >>> Looks like duplicated: > >>> https://lore.kernel.org/lkml/20181018095708.1527-7-m.szyprowski@samsung.com/ > >>> > >>> The topic stalled and I think this particular patch did not make sense > >>> on its own, without rest of changes from Marek. I am not sure, though... > >>> > >> Krzysztof, Marek, > >> > >> That series looks nice, I'm quite interested in that being applied. Do > >> you think I can do something to help with that (e.g. rebasing, > >> re-sending on behalf of Marek, testing on Exynos850, etc)? > > I think there were no objections against v4 of this patchset, but > > somehow it wasn't applied. > > > > Marek, > > Does it make sense to try respinning your v4? > > I think I've abandoned it, because I got a final NACK on the arch timer > change (support for 'not-fw-configured' timers). Without that the above > mentioned changes doesn't make much sense. > > I know that the Exynos5433 firmware breaks the defined protocol, but on > the other hand I can do nothing more than carrying internally those few > patches out of tree to keep it fully working with 'mainline'. > > I've observed the same problem with newer Exynos SoCs, but those so far > didn't get mainline support (yet), although there have been some > attempts from the community. > There is no such problem on Exynos850 SoC (which I'm trying to upstream right now), the architectured timer seems to be working fine there, as is. Or maybe everything is configured properly in bootloader, not sure. Also I managed to use MCT as a primary clocksource (for sched_clock, etc) by disabling arch timer in arch/arm64/kernel/time.c (just for the sake of test), and it works fine. So I still would like to have MCT enabled in kernel: this way we can at least test the driver, as the clocksource can be changed to MCT via sysfs (or by disabling arch timer in time.c). And for that we need to at least enable CLKSRC_EXYNOS_MCT in ARCH_EXYNOS. I guess all your patches (except one you mentioned) from that series should be fine to apply. Do you mind if I re-send your patch series (minus one patch) on your behalf? That would spare you some boring work, and at least minimize your local delta you're carrying. Thanks! > Best regards > > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28147C433F5 for ; Fri, 29 Oct 2021 13:17:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E4660E73 for ; Fri, 29 Oct 2021 13:17:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4E4660E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0LBV3lyEi8VA4+pItcQIItE0H7ABUEJe3TD5hHqK48s=; b=ZwpjBEuV+iSYaT 279BmVrn9w6wtdz/z/fp60jPkXQiXgqTHKoSAnhq7qQBGtEMDiGtgSt7ZB9mGssEN6R9OhnvO2lOe 5f9yoOL290Ch6MI39F+0pgwqcvvuvDlpO98fIIzkO4SeoVX4m1NIi8kHkpUjyRdYXJ4UoSbFLV7/X 7BgFqrGB8ve4Tj5VQ4vk4liOkY8sXeKrSyNfdU+Q5c/4vHHB42qWCEVk1Wp/LDbVag37b5NqgOZ+3 Or6nCEwlwolh84A9IzaO7dFBE4q7/TVIx2tOjC+fB4jCBN3mS6aEe1RwkAkPr8o2z2hAtWTD5cwrm C/M5dBbTaF/cC+nwV+JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRjS-00B1sp-FY; Fri, 29 Oct 2021 13:15:42 +0000 Received: from mail-ua1-x92e.google.com ([2607:f8b0:4864:20::92e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRjN-00B1sA-PR for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 13:15:40 +0000 Received: by mail-ua1-x92e.google.com with SMTP id x3so17972397uar.13 for ; Fri, 29 Oct 2021 06:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g+Jn0Zb4XSWTtnsH7XrcWpFd+2PsMM1WYmSDBWFjSHk=; b=b9E/lRCvOBOQR1o3F7Fxr20iMUVtSJUqUxSOg6lRP3YmV//6oeIM13YCK+fke+bnix g/gii88LV1Ol2o5XiRcBIF1zdz7LNiNUU3EERvs0w4Fw75e8TzfH38xw3lE72l3P+OwA rh8RmIzbnE3CrIp8PKTRJ+pAfHgm6aMlFZwZ+EBoy4c877CzsdbrvddazYth9n8HKb4K 3lU5bFpLNwATuM534+CbMr5KoLDzQtq4rikxLyka3CLMScSCnkYR+xcl/2oCN55jH8Eo InKF8BKDFNs8H53aXzh5N7Kd7gHP5DDx7fv9lZ9a1SnvETzyYPbpzU3dboZYmSWxXA15 Ubnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g+Jn0Zb4XSWTtnsH7XrcWpFd+2PsMM1WYmSDBWFjSHk=; b=FGHSiQmQHPr2BQK+caZoXo1NY0fw602XVLxn8jPWd5y4yCcm5ZQ3Rl4UBlrid0a5Lc Utqe+tVEP1EUBB2+gp+9rsjx3YoX+ok3+UfiuaEvJ5TIrlJ78bJbEpN6n1Bbbc22U6p2 dgw05OgQCIdJliOpGY/SS8mwZfj0ztVDyAwOhU+IAb/B59JFJ4pq5jwzZ4VjsWlHlE04 wiRV6TgKIfdvBG8VQUZhIWpMGK9ivk6iJQwxK5LUx9qlgLQmLnnHjtwlh3+gRa4hWAcO w6MyGWf+epEl1PV4TzNQPk0C9a96+/hYcNU7R5FioGHKFVVMsCiLRNyMawCIofvt2LRE 1GWw== X-Gm-Message-State: AOAM5336ve44KuPDgOJE5Hf2sIa+ynZm4K1UIHrDfK3G4TcztJIGCx0N 2F2chCK6IBCTiU6xZR3CS4fKkEz+e6jd3l15na7Ngw== X-Google-Smtp-Source: ABdhPJy54z6tvSJScJqF6AXYv4loNJuYfD/YEcFaxZYwl0OrIXfWSnt5RuDHqPLB8WOr+h4A+o6iGm8c/SKmN0YaQr8= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr12138135vsm.55.1635513336043; Fri, 29 Oct 2021 06:15:36 -0700 (PDT) MIME-Version: 1.0 References: <20211026115916.31553-1-semen.protsenko@linaro.org> <8b3466f1-2b16-80ca-79c7-577860fc90aa@canonical.com> In-Reply-To: From: Sam Protsenko Date: Fri, 29 Oct 2021 16:15:24 +0300 Message-ID: Subject: Re: [PATCH] arm64: Kconfig: Enable MCT timer for ARCH_EXYNOS To: Marek Szyprowski Cc: Krzysztof Kozlowski , linux-arm Mailing List , Linux Kernel Mailing List , Linux Samsung SOC , Mark Rutland , Chanwoo Choi , Will Deacon , Marc Zyngier , Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_061537_881215_ED81543C X-CRM114-Status: GOOD ( 33.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Oct 2021 at 14:38, Marek Szyprowski wrote: > > On 28.10.2021 16:35, Krzysztof Kozlowski wrote: > > On 28/10/2021 16:22, Sam Protsenko wrote: > >> On Tue, 26 Oct 2021 at 17:03, Krzysztof Kozlowski > >> wrote: > >>> On 26/10/2021 13:59, Sam Protsenko wrote: > >>>> Some ARM64 Exynos SoCs have MCT timer block, e.g. Exynos850 and > >>>> Exynos5433. CLKSRC_EXYNOS_MCT option is not visible unless COMPILE_TEST > >>>> is enabled. Select CLKSRC_EXYNOS_MCT option for ARM64 ARCH_EXYNOS like > >>>> it's done in arch/arm/mach-exynos/Kconfig, to enable MCT timer support > >>>> for ARM64 Exynos SoCs. > >>>> > >>>> Signed-off-by: Sam Protsenko > >>>> --- > >>>> arch/arm64/Kconfig.platforms | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>> +CC Marek, Marc, Mark and Chanwoo, > >>> Looks like duplicated: > >>> https://lore.kernel.org/lkml/20181018095708.1527-7-m.szyprowski@samsung.com/ > >>> > >>> The topic stalled and I think this particular patch did not make sense > >>> on its own, without rest of changes from Marek. I am not sure, though... > >>> > >> Krzysztof, Marek, > >> > >> That series looks nice, I'm quite interested in that being applied. Do > >> you think I can do something to help with that (e.g. rebasing, > >> re-sending on behalf of Marek, testing on Exynos850, etc)? > > I think there were no objections against v4 of this patchset, but > > somehow it wasn't applied. > > > > Marek, > > Does it make sense to try respinning your v4? > > I think I've abandoned it, because I got a final NACK on the arch timer > change (support for 'not-fw-configured' timers). Without that the above > mentioned changes doesn't make much sense. > > I know that the Exynos5433 firmware breaks the defined protocol, but on > the other hand I can do nothing more than carrying internally those few > patches out of tree to keep it fully working with 'mainline'. > > I've observed the same problem with newer Exynos SoCs, but those so far > didn't get mainline support (yet), although there have been some > attempts from the community. > There is no such problem on Exynos850 SoC (which I'm trying to upstream right now), the architectured timer seems to be working fine there, as is. Or maybe everything is configured properly in bootloader, not sure. Also I managed to use MCT as a primary clocksource (for sched_clock, etc) by disabling arch timer in arch/arm64/kernel/time.c (just for the sake of test), and it works fine. So I still would like to have MCT enabled in kernel: this way we can at least test the driver, as the clocksource can be changed to MCT via sysfs (or by disabling arch timer in time.c). And for that we need to at least enable CLKSRC_EXYNOS_MCT in ARCH_EXYNOS. I guess all your patches (except one you mentioned) from that series should be fine to apply. Do you mind if I re-send your patch series (minus one patch) on your behalf? That would spare you some boring work, and at least minimize your local delta you're carrying. Thanks! > Best regards > > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel