From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42683C19F28 for ; Wed, 27 Jul 2022 13:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233175AbiG0NzL (ORCPT ); Wed, 27 Jul 2022 09:55:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232891AbiG0NzK (ORCPT ); Wed, 27 Jul 2022 09:55:10 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70DA333364 for ; Wed, 27 Jul 2022 06:55:05 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id p10so19709795lfd.9 for ; Wed, 27 Jul 2022 06:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sdiNy+K85E6T6Q5Cx2+M4h0HkFCwZdyqW9o88JSTZPk=; b=ouwOadP/hMPQTv7thHahdc2e7AKPdNrRyZIzuSCyE6KR79AcLZ1PgpjXmT9MMsFFe+ 1zA+2ZTzeceEo5I43eLCqk2H6A2UNkkIWR1Ep1nEs2pSVxW15D9AJtlMxSubnfRudbeL oh3nDontOF+AHAGff/Yfw9dGU+wytr6YSTkhz8ZAqI2ceTI3z6o6Ti+NKFXZA9LtRIw3 cOAFYT4cGMahOlgmJmmquCa03KI5Bu0PEFQ9bXriZjGWS3+bC84X2IYQAC4pJ30/IASp XiqU9TEEtOyhGcOEcVk+G36+de7briY0Ic0XEgACqvi9cyLvpPbAMwAG0U6qVJe8dzz4 acjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sdiNy+K85E6T6Q5Cx2+M4h0HkFCwZdyqW9o88JSTZPk=; b=eBCO9wtycf0aMBisqx95iuYWeP5bjV5b/4Rrp9riPybiG+wFRV+bbnpNLYTyuizKzF ndfg6y/jCs0zXgDbwwnAfu5hQ063HUkl6GFOMPCvJDDIBuYV0BTLYCwTGlzv41zIsqNN sT7PKU4rvMnDodsnXxjnEXS5c5CC8a1XvQ8MqpcDH7QcYYl7u6in3tln6iUMYRCKjzV2 JJGsNJM1C+KNUVuPf6DtF/+jOOtSsczMZZjS1Mfeav7Hdu3rDFQQobdrhzC+ObJqggZh odfyl/g6l152HtQMWs+4hs31NY3VchMzKhprCo3V4x4+TvzeJVBX67DOZ5xMp/PkSK7W ZXUQ== X-Gm-Message-State: AJIora8yM2xtYZt2TYeIyk2wSqgRFKrMFhgbkZowBjYjACPoR4cNKgR+ rBiTXiRJsIkeJHHI4/XVw7jyBlaBQNezYwZwmvjiUw== X-Google-Smtp-Source: AGRyM1sNAQoXPZGQGR853MTNOGh+Bg6eDRkS0Wih4mISvpT8XTjJxWzxG6yZi37ackDpTTd4Ki6S1sp/2dZXQtCrhIQ= X-Received: by 2002:a05:6512:1320:b0:488:8fcc:e196 with SMTP id x32-20020a056512132000b004888fcce196mr8068316lfu.602.1658930103636; Wed, 27 Jul 2022 06:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> In-Reply-To: <20220727013349.3056826-1-saravanak@google.com> From: Sam Protsenko Date: Wed, 27 Jul 2022 16:54:52 +0300 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Saravana Kannan Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 27 Jul 2022 at 04:33, Saravana Kannan wrote: > > As soon as a gpio is registered, it should be usable by a consumer. So, > do all the initialization before registering the gpios. Without this > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > mapping fail. > > Signed-off-by: Saravana Kannan > --- Reviewed-by: Sam Protsenko > drivers/pinctrl/samsung/pinctrl-samsung.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index 26d309d2516d..a302b38a63a8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -1168,15 +1168,15 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) > if (ret) > goto err_put_banks; > > - ret = samsung_gpiolib_register(pdev, drvdata); > - if (ret) > - goto err_unregister; > - > if (ctrl->eint_gpio_init) > ctrl->eint_gpio_init(drvdata); > if (ctrl->eint_wkup_init) > ctrl->eint_wkup_init(drvdata); > > + ret = samsung_gpiolib_register(pdev, drvdata); > + if (ret) > + goto err_unregister; > + > platform_set_drvdata(pdev, drvdata); > > return 0; > -- > 2.37.1.359.gd136c6c3e2-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99AD3C04A68 for ; Wed, 27 Jul 2022 13:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j1L5tqT5iQv3dh1yhjIIZsyfuagjrejCBUPYdOgRZ/k=; b=dVggOx+dj8Dlcw t/es2yddFIwBTV2V9eDG9ifQwTxXpSMdq8cRotzlHXsHnyviJOmfu5EUSPiYku9sF2YY80KHOFA/9 5k1nHQDlG+NoymV3JF8dPiHlQl2u/tUkUQ5wlHXhAgeoUNP4W0MXWs2eQAMPpk5qButEQGjaqVVpM tVb6f65mfCtJGnhQX0LARghVZSDhVesBkPOC/IuYyL+xqcdP343it0Gvi4sRxlWsCYRKWKkWUVkj7 JRXefkiMqtF6jpTzwDcV2Qei98tJFuyANWeZCJdOs3E0kxii8JyFWDuItsmeMtXdw/SnpduGTp5QU 1pOaMyY9l+9hNBEMLcOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGhVH-00EFEv-7w; Wed, 27 Jul 2022 13:55:11 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGhVD-00EFBm-CQ for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 13:55:08 +0000 Received: by mail-lf1-x12d.google.com with SMTP id p11so22395946lfu.5 for ; Wed, 27 Jul 2022 06:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sdiNy+K85E6T6Q5Cx2+M4h0HkFCwZdyqW9o88JSTZPk=; b=ouwOadP/hMPQTv7thHahdc2e7AKPdNrRyZIzuSCyE6KR79AcLZ1PgpjXmT9MMsFFe+ 1zA+2ZTzeceEo5I43eLCqk2H6A2UNkkIWR1Ep1nEs2pSVxW15D9AJtlMxSubnfRudbeL oh3nDontOF+AHAGff/Yfw9dGU+wytr6YSTkhz8ZAqI2ceTI3z6o6Ti+NKFXZA9LtRIw3 cOAFYT4cGMahOlgmJmmquCa03KI5Bu0PEFQ9bXriZjGWS3+bC84X2IYQAC4pJ30/IASp XiqU9TEEtOyhGcOEcVk+G36+de7briY0Ic0XEgACqvi9cyLvpPbAMwAG0U6qVJe8dzz4 acjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sdiNy+K85E6T6Q5Cx2+M4h0HkFCwZdyqW9o88JSTZPk=; b=enW6LPpXoijCF/D09JYYYxXiMewy9HrvNP52a6GwqDRjjabsgOClAs4vuTzZQDvURc 5JEceFGO+ghcRM6rct8AV5KH9G91f8ythRMVlzr87rX3x6q7YFpy0J8gBb+08jqQ4ez4 LWuc/0/TjUl+ng7tCY6QCBS7knJbSnPcmEOkMY0X4Xmyl630vDTZLpSQolm78NerUW8a ZOy4mZnISHuIueAUol4Gfj7XYuvL2Q0NrSfYhGjK9dXlBX2VFmxvsOxZruY1esIdpocg I+Mfmpm5u6LthbMYh3h1xS+SQlRONSCgUtq7i2yor+KxXYhwLmpFF9X97OrkKsp2esGP Qcrw== X-Gm-Message-State: AJIora9jI/ia38OE1xsHF9IUXGcSM/+c/nHgfDrPOvPsNdyUy3QgVsud pfmgp7FKmoT5vUiFgsYlSABmmWGZmenkHpGKxOWniQ== X-Google-Smtp-Source: AGRyM1sNAQoXPZGQGR853MTNOGh+Bg6eDRkS0Wih4mISvpT8XTjJxWzxG6yZi37ackDpTTd4Ki6S1sp/2dZXQtCrhIQ= X-Received: by 2002:a05:6512:1320:b0:488:8fcc:e196 with SMTP id x32-20020a056512132000b004888fcce196mr8068316lfu.602.1658930103636; Wed, 27 Jul 2022 06:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> In-Reply-To: <20220727013349.3056826-1-saravanak@google.com> From: Sam Protsenko Date: Wed, 27 Jul 2022 16:54:52 +0300 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Saravana Kannan Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_065507_539425_D3C844FB X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Jul 2022 at 04:33, Saravana Kannan wrote: > > As soon as a gpio is registered, it should be usable by a consumer. So, > do all the initialization before registering the gpios. Without this > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > mapping fail. > > Signed-off-by: Saravana Kannan > --- Reviewed-by: Sam Protsenko > drivers/pinctrl/samsung/pinctrl-samsung.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index 26d309d2516d..a302b38a63a8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -1168,15 +1168,15 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) > if (ret) > goto err_put_banks; > > - ret = samsung_gpiolib_register(pdev, drvdata); > - if (ret) > - goto err_unregister; > - > if (ctrl->eint_gpio_init) > ctrl->eint_gpio_init(drvdata); > if (ctrl->eint_wkup_init) > ctrl->eint_wkup_init(drvdata); > > + ret = samsung_gpiolib_register(pdev, drvdata); > + if (ret) > + goto err_unregister; > + > platform_set_drvdata(pdev, drvdata); > > return 0; > -- > 2.37.1.359.gd136c6c3e2-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel