From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED1BC4332F for ; Thu, 16 Dec 2021 23:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbhLPXjR (ORCPT ); Thu, 16 Dec 2021 18:39:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbhLPXjQ (ORCPT ); Thu, 16 Dec 2021 18:39:16 -0500 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 733C6C061574 for ; Thu, 16 Dec 2021 15:39:16 -0800 (PST) Received: by mail-vk1-xa2b.google.com with SMTP id m185so446644vkm.5 for ; Thu, 16 Dec 2021 15:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=43o4wlr1IkiAU6zQKaIE6WugMg6KsgM5BbH78Jvij0o=; b=HB+qq10OML7ZwC1o7HMfLZN4yFllE4yDSe5F+YbzSPwkzJUex9pTjIxPjVSlJAXR+R TGqgohg+ALvNQ5TX22/tFkra8T1/GBsvqrb60u/rDp9rmJElzb6mtmSsg6txYChGvGST 2ZYWCdrEKaMsT+2oXmvQVUEZ9HxlWogkJ2TQ/BpWE/mO6e3mBF9ryAV007njMT0kQdN0 XIw05SsDe/5f6d9UboYjwepxBFgw+VpX3dpBZeWubuceQFVVLITQ0PxEdg8PMQcY6SHp jBg2qSTT6ckdin2YAr6YphjH5MnBR5AVolzlGOb5KYjOlMXu99GdQw2GDMB92WPasGUT sspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43o4wlr1IkiAU6zQKaIE6WugMg6KsgM5BbH78Jvij0o=; b=rXoQDZOiua2+4YaM00U2KujZ06v6bhkcL/FhwlonPURqU+IjzwSTNLIC5K7gvtGs20 lWaaKurPHg48hGE/EFr3vFL0iPqb5Os8XlebGwuBrQimr0UA6SGdcTGwY+JTbv41HiQ3 AstaFCQiMEm+2ubiizqaU1QM86iNqwC4fVX6eciojLfjIBPC+F1hHzz9U6FqyxRhE5PA zetTr0AHHW+VZru12P+fHyAk7xfrdR5mmDXFmxWhJUMGC3+4ypanRBF454rAj0ddFcHU WRwzvB5ndz/UcQwZgWRdrf08zO5fW/LFluL26xEzpJwn/v+dk8ydwXxrZhTDZEPDAQ4e DLaw== X-Gm-Message-State: AOAM533/4Ir/UqQagQyD+e/1VfScn0pTSTogZE6N4Ve5Qf459SfRH5VD Ke7T7fvaasKtEH3fQ5RPY4163lPRbfz2z6d4jcDZuw== X-Google-Smtp-Source: ABdhPJzp16pmobRMKBbx935rBJUh4NWI//WbgPPhjLN9j6aWH5GwJmzTWm6uqTBPwfplsvBVNP362rJ+P+2ebgD0jtQ= X-Received: by 2002:a05:6122:2158:: with SMTP id m24mr173726vkd.1.1639697955495; Thu, 16 Dec 2021 15:39:15 -0800 (PST) MIME-Version: 1.0 References: <20211215160906.17451-1-semen.protsenko@linaro.org> <20211215160906.17451-8-semen.protsenko@linaro.org> <239e30fa-7994-fcb2-5b83-27ae00ca8cbc@canonical.com> In-Reply-To: <239e30fa-7994-fcb2-5b83-27ae00ca8cbc@canonical.com> From: Sam Protsenko Date: Fri, 17 Dec 2021 01:39:03 +0200 Message-ID: Subject: Re: [PATCH 7/7] arm64: dts: exynos: Add initial E850-96 board support To: Krzysztof Kozlowski Cc: Rob Herring , Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Dec 2021 at 19:01, Krzysztof Kozlowski wrote: > > On 15/12/2021 17:09, Sam Protsenko wrote: > > E850-96 is a 96boards development board manufactured by WinLink. It > > incorporates Samsung Exynos850 SoC, and is compatible with 96boards > > mezzanine boards [1], as it follows 96boards standards. > > > > This patch adds minimal support for E850-96 board. Next features are > > enabled in board dts file and verified with minimal BusyBox rootfs: > > > > * User buttons > > * LEDs > > * Serial console > > * Watchdog timers > > * RTC > > * eMMC > > > > [1] https://www.96boards.org/products/mezzanine/ > > > > Signed-off-by: Sam Protsenko > > --- > > arch/arm64/boot/dts/exynos/Makefile | 3 +- > > .../boot/dts/exynos/exynos850-e850-96.dts | 157 ++++++++++++++++++ > > 2 files changed, 159 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > > > diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile > > index b41e86df0a84..803548ccc537 100644 > > --- a/arch/arm64/boot/dts/exynos/Makefile > > +++ b/arch/arm64/boot/dts/exynos/Makefile > > @@ -3,4 +3,5 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ > > exynos5433-tm2.dtb \ > > exynos5433-tm2e.dtb \ > > exynos7-espresso.dtb \ > > - exynosautov9-sadk.dtb > > + exynosautov9-sadk.dtb \ > > + exynos850-e850-96.dtb > > Alphabetical order please, so before autov9. > > > diff --git a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > new file mode 100644 > > index 000000000000..fd611906d81c > > --- /dev/null > > +++ b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > @@ -0,0 +1,157 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * WinLink E850-96 board device tree source > > + * > > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > > + * Copyright (C) 2021 Linaro Ltd. > > + * > > + * Device tree source file for WinLink's E850-96 board which is based on > > + * Samsung Exynos850 SoC. > > + */ > > + > > +/dts-v1/; > > + > > +#include "exynos850.dtsi" > > +#include > > +#include > > + > > +#define BOARD_ID 0x0 > > +#define BOARD_REV 0x2 > > No need for define for single-used constant. > > > + > > +/ { > > + model = "WinLink E850-96 board"; > > + compatible = "winlink,e850-96", "samsung,exynos850"; > > + board_id = ; > > + board_rev = ; > > Unknown properties. They need dtschema. > Those are not really needed in case of upstream linux (only one board revision is added and no dtbo to merge in bootloader). Will remove those in v2. > > + > > + chosen { > > + stdout-path = &serial_0; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&key_voldown_pins &key_volup_pins>; > > + > > + volume-down-key { > > + label = "Volume Down"; > > + linux,code = ; > > + gpios = <&gpa1 0 GPIO_ACTIVE_LOW>; > > + }; > > + > > + volume-up-key { > > + label = "Volume Up"; > > + linux,code = ; > > + gpios = <&gpa0 7 GPIO_ACTIVE_LOW>; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + /* HEART_BEAT_LED */ > > + user_led1: led-1 { > > + label = "yellow:user1"; > > Add where applicable: > 1. function, e.g. LED_FUNCTION_HEARTBEAT, LED_FUNCTION_WLAN, etc, > 2. color constants. > I actually had those defined initially :) But then specifically decided to remove those, as those are not very helpful when "label" and "linux,default-trigger" are already defined (and not many other boards seem to provide it). But ok, I'll pull those back in v2. > > + gpios = <&gpg2 2 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "heartbeat"; > > + }; > > + > > + /* eMMC_LED */ > > + user_led2: led-2 { > > + label = "yellow:user2"; > > + gpios = <&gpg2 3 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "mmc0"; > > + }; > > + > > + /* SD_LED */ > > + user_led3: led-3 { > > + label = "white:user3"; > > + gpios = <&gpg2 4 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "mmc2"; > > + }; > > + > > + /* WIFI_LED */ > > + wlan_active_led: led-4 { > > + label = "yellow:wlan"; > > + gpios = <&gpg2 6 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "phy0tx"; > > + default-state = "off"; > > + }; > > + > > + /* BLUETOOTH_LED */ > > + bt_active_led: led-5 { > > + label = "blue:bt"; > > + gpios = <&gpg2 7 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "hci0rx"; > > + default-state = "off"; > > + }; > > + }; > > +}; > > + > > +&oscclk {> + clock-frequency = <26000000>; > > +}; > > + > > +&rtcclk { > > + clock-frequency = <32768>; > > +}; > > + > > +&usi_uart { > > + samsung,clkreq-on; /* needed for UART mode */ > > + status = "okay"; > > +}; > > + > > +&serial_0 { > > Order all phandle overrides by phandle name, so: > &oscclk > &rtcclk > &serial_0 > &usi_uart > ... > > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart1_pins>; > > +}; > > + > > +&watchdog_cl0 { > > + status = "okay"; > > +}; > > + > > +&watchdog_cl1 { > > + status = "okay"; > > +}; > > + > > +&rtc { > > + status = "okay"; > > +}; > > + > > +&mmc_0 { > > + status = "okay"; > > + mmc-hs200-1_8v; > > + mmc-hs400-1_8v; > > + cap-mmc-highspeed; > > + non-removable; > > + broken-cd; > > Is it correct to have non-removable (typical for eMMC) and broken CD? > Nice catch, not sure how I missed that. It's just ignored in dw_mmc driver in case of "non-removable", but that property just doesn't make any sense here. This and all above comments will be addressed in v2. > > + mmc-hs400-enhanced-strobe; > > + card-detect-delay = <200>; > > + clock-frequency = <800000000>; > > + bus-width = <8>; > > + samsung,dw-mshc-ciu-div = <3>; > > + samsung,dw-mshc-sdr-timing = <0 4>; > > + samsung,dw-mshc-ddr-timing = <2 4>; > > + samsung,dw-mshc-hs400-timing = <0 2>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sd0_clk_pins &sd0_cmd_pins &sd0_rdqs_pins &sd0_nreset_pins > > + &sd0_bus1_pins &sd0_bus4_pins &sd0_bus8_pins>; > > +}; > > + > > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28EF5C433F5 for ; Thu, 16 Dec 2021 23:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ETj9Ff3DGy7mFnwilDqyZo2EH/ohuZyEMQBb4s8I96g=; b=1UiJhu8GtJdAeV VHiEXZ6r30VMrjsRh/ERTpm2GOV2mJqz7Q87S39TybyztTmh3njXEL3DlsY50vDcrAhjKsnUu56NY ATFMhAR5ATr/Zys7jKOZef3Q6g3xo3gAwRBTcQ8hVyVj4bCSxU9QRQmVp5J51KgHaMLLrG8bhZQR1 42um6ov7slt1DFolX0NB8bWB8o7QcgYtxqYxBUnTDt/r727p+xN58Ol/J78pmyOfq6HhiJvmNzcXt GbKYUVU9GkWYhVY/6eXsIlqvKe/BRNT6QUgi/w9mlDZVsWP5mHb3bQaUOneARlP4jCGCw6yo0kyjM Sgpj3q+YMn5Sm1KkvQqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1my0LJ-007z4f-52; Thu, 16 Dec 2021 23:39:21 +0000 Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1my0LF-007z39-0I for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 23:39:19 +0000 Received: by mail-vk1-xa2e.google.com with SMTP id s20so445509vkm.1 for ; Thu, 16 Dec 2021 15:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=43o4wlr1IkiAU6zQKaIE6WugMg6KsgM5BbH78Jvij0o=; b=HB+qq10OML7ZwC1o7HMfLZN4yFllE4yDSe5F+YbzSPwkzJUex9pTjIxPjVSlJAXR+R TGqgohg+ALvNQ5TX22/tFkra8T1/GBsvqrb60u/rDp9rmJElzb6mtmSsg6txYChGvGST 2ZYWCdrEKaMsT+2oXmvQVUEZ9HxlWogkJ2TQ/BpWE/mO6e3mBF9ryAV007njMT0kQdN0 XIw05SsDe/5f6d9UboYjwepxBFgw+VpX3dpBZeWubuceQFVVLITQ0PxEdg8PMQcY6SHp jBg2qSTT6ckdin2YAr6YphjH5MnBR5AVolzlGOb5KYjOlMXu99GdQw2GDMB92WPasGUT sspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43o4wlr1IkiAU6zQKaIE6WugMg6KsgM5BbH78Jvij0o=; b=APtLTE9iwyr11rsqXk3C+jpDrr2hbO7VHrxl+PVh5uflNknVj7CNokHxGndwMzuZt2 zshdvQlzG08MZJiDFiFlO79m0H1vJAFwhtPw5LgBBxkZJke5zZdlJC5Yc0Zf/de5ncOh xjT/wCQPik1v2obggmfWMqdiNWA/M79ciswfN0DRY842SxWv/VQBUMv3WLUXsretV1lq SH5cOX8pNqneyWT9zxnGQNNaoeS155vahvzb9mmwtsNd2lgtl+vPpzUmRTGQFefuDphA /QwXljf9xVDy/lsHUN6KP3yczC/K4u1YC9hibA8gk5Z7TK/2Iad7ruuAfXCpIrklq0kS RVtg== X-Gm-Message-State: AOAM530srAWkF2Af7Z5O5ARtqoSwcMt6MRZmQSQ2AT8kTOon2ZTUgyQu ZstC0qNzyHTTh8ltd8ZfzCZCmky1XaGZF+rfg8HP4Q== X-Google-Smtp-Source: ABdhPJzp16pmobRMKBbx935rBJUh4NWI//WbgPPhjLN9j6aWH5GwJmzTWm6uqTBPwfplsvBVNP362rJ+P+2ebgD0jtQ= X-Received: by 2002:a05:6122:2158:: with SMTP id m24mr173726vkd.1.1639697955495; Thu, 16 Dec 2021 15:39:15 -0800 (PST) MIME-Version: 1.0 References: <20211215160906.17451-1-semen.protsenko@linaro.org> <20211215160906.17451-8-semen.protsenko@linaro.org> <239e30fa-7994-fcb2-5b83-27ae00ca8cbc@canonical.com> In-Reply-To: <239e30fa-7994-fcb2-5b83-27ae00ca8cbc@canonical.com> From: Sam Protsenko Date: Fri, 17 Dec 2021 01:39:03 +0200 Message-ID: Subject: Re: [PATCH 7/7] arm64: dts: exynos: Add initial E850-96 board support To: Krzysztof Kozlowski Cc: Rob Herring , Sylwester Nawrocki , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Daniel Palmer , Hao Fang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_153917_150494_95AB1C96 X-CRM114-Status: GOOD ( 33.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Dec 2021 at 19:01, Krzysztof Kozlowski wrote: > > On 15/12/2021 17:09, Sam Protsenko wrote: > > E850-96 is a 96boards development board manufactured by WinLink. It > > incorporates Samsung Exynos850 SoC, and is compatible with 96boards > > mezzanine boards [1], as it follows 96boards standards. > > > > This patch adds minimal support for E850-96 board. Next features are > > enabled in board dts file and verified with minimal BusyBox rootfs: > > > > * User buttons > > * LEDs > > * Serial console > > * Watchdog timers > > * RTC > > * eMMC > > > > [1] https://www.96boards.org/products/mezzanine/ > > > > Signed-off-by: Sam Protsenko > > --- > > arch/arm64/boot/dts/exynos/Makefile | 3 +- > > .../boot/dts/exynos/exynos850-e850-96.dts | 157 ++++++++++++++++++ > > 2 files changed, 159 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > > > diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile > > index b41e86df0a84..803548ccc537 100644 > > --- a/arch/arm64/boot/dts/exynos/Makefile > > +++ b/arch/arm64/boot/dts/exynos/Makefile > > @@ -3,4 +3,5 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ > > exynos5433-tm2.dtb \ > > exynos5433-tm2e.dtb \ > > exynos7-espresso.dtb \ > > - exynosautov9-sadk.dtb > > + exynosautov9-sadk.dtb \ > > + exynos850-e850-96.dtb > > Alphabetical order please, so before autov9. > > > diff --git a/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > new file mode 100644 > > index 000000000000..fd611906d81c > > --- /dev/null > > +++ b/arch/arm64/boot/dts/exynos/exynos850-e850-96.dts > > @@ -0,0 +1,157 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * WinLink E850-96 board device tree source > > + * > > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > > + * Copyright (C) 2021 Linaro Ltd. > > + * > > + * Device tree source file for WinLink's E850-96 board which is based on > > + * Samsung Exynos850 SoC. > > + */ > > + > > +/dts-v1/; > > + > > +#include "exynos850.dtsi" > > +#include > > +#include > > + > > +#define BOARD_ID 0x0 > > +#define BOARD_REV 0x2 > > No need for define for single-used constant. > > > + > > +/ { > > + model = "WinLink E850-96 board"; > > + compatible = "winlink,e850-96", "samsung,exynos850"; > > + board_id = ; > > + board_rev = ; > > Unknown properties. They need dtschema. > Those are not really needed in case of upstream linux (only one board revision is added and no dtbo to merge in bootloader). Will remove those in v2. > > + > > + chosen { > > + stdout-path = &serial_0; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&key_voldown_pins &key_volup_pins>; > > + > > + volume-down-key { > > + label = "Volume Down"; > > + linux,code = ; > > + gpios = <&gpa1 0 GPIO_ACTIVE_LOW>; > > + }; > > + > > + volume-up-key { > > + label = "Volume Up"; > > + linux,code = ; > > + gpios = <&gpa0 7 GPIO_ACTIVE_LOW>; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + /* HEART_BEAT_LED */ > > + user_led1: led-1 { > > + label = "yellow:user1"; > > Add where applicable: > 1. function, e.g. LED_FUNCTION_HEARTBEAT, LED_FUNCTION_WLAN, etc, > 2. color constants. > I actually had those defined initially :) But then specifically decided to remove those, as those are not very helpful when "label" and "linux,default-trigger" are already defined (and not many other boards seem to provide it). But ok, I'll pull those back in v2. > > + gpios = <&gpg2 2 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "heartbeat"; > > + }; > > + > > + /* eMMC_LED */ > > + user_led2: led-2 { > > + label = "yellow:user2"; > > + gpios = <&gpg2 3 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "mmc0"; > > + }; > > + > > + /* SD_LED */ > > + user_led3: led-3 { > > + label = "white:user3"; > > + gpios = <&gpg2 4 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "mmc2"; > > + }; > > + > > + /* WIFI_LED */ > > + wlan_active_led: led-4 { > > + label = "yellow:wlan"; > > + gpios = <&gpg2 6 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "phy0tx"; > > + default-state = "off"; > > + }; > > + > > + /* BLUETOOTH_LED */ > > + bt_active_led: led-5 { > > + label = "blue:bt"; > > + gpios = <&gpg2 7 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "hci0rx"; > > + default-state = "off"; > > + }; > > + }; > > +}; > > + > > +&oscclk {> + clock-frequency = <26000000>; > > +}; > > + > > +&rtcclk { > > + clock-frequency = <32768>; > > +}; > > + > > +&usi_uart { > > + samsung,clkreq-on; /* needed for UART mode */ > > + status = "okay"; > > +}; > > + > > +&serial_0 { > > Order all phandle overrides by phandle name, so: > &oscclk > &rtcclk > &serial_0 > &usi_uart > ... > > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart1_pins>; > > +}; > > + > > +&watchdog_cl0 { > > + status = "okay"; > > +}; > > + > > +&watchdog_cl1 { > > + status = "okay"; > > +}; > > + > > +&rtc { > > + status = "okay"; > > +}; > > + > > +&mmc_0 { > > + status = "okay"; > > + mmc-hs200-1_8v; > > + mmc-hs400-1_8v; > > + cap-mmc-highspeed; > > + non-removable; > > + broken-cd; > > Is it correct to have non-removable (typical for eMMC) and broken CD? > Nice catch, not sure how I missed that. It's just ignored in dw_mmc driver in case of "non-removable", but that property just doesn't make any sense here. This and all above comments will be addressed in v2. > > + mmc-hs400-enhanced-strobe; > > + card-detect-delay = <200>; > > + clock-frequency = <800000000>; > > + bus-width = <8>; > > + samsung,dw-mshc-ciu-div = <3>; > > + samsung,dw-mshc-sdr-timing = <0 4>; > > + samsung,dw-mshc-ddr-timing = <2 4>; > > + samsung,dw-mshc-hs400-timing = <0 2>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sd0_clk_pins &sd0_cmd_pins &sd0_rdqs_pins &sd0_nreset_pins > > + &sd0_bus1_pins &sd0_bus4_pins &sd0_bus8_pins>; > > +}; > > + > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel