From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0FDC433FE for ; Tue, 5 Oct 2021 12:07:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40CAF61163 for ; Tue, 5 Oct 2021 12:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234603AbhJEMI7 (ORCPT ); Tue, 5 Oct 2021 08:08:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234395AbhJEMI6 (ORCPT ); Tue, 5 Oct 2021 08:08:58 -0400 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE6CAC06174E for ; Tue, 5 Oct 2021 05:07:07 -0700 (PDT) Received: by mail-vs1-xe36.google.com with SMTP id l19so23344088vst.7 for ; Tue, 05 Oct 2021 05:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lD83FuXyo4Rd8RPUoclDBjywfkShCLbVEGQP8et9RdA=; b=hKikOG5IDhmF6NJFOqVeb0VuaR8rP2Ugg7wDlfnHoNKRRg8JMTnBbRNIgtXdsQWhdo nB+w7sIz1XpbQfcRJclH19JCDP6JRv1Ky60u5DpF05LzJZ9lFqyebUb8/IQtRtyg1xNN gEKSTl7MOR0HaJCP/ARXgZjGBZnrbuldsQYd88DrHsQvIx6SBzeI9CPhkWtfAeceIsPZ 057zIf9cGeRjOW/VM+mOdso1O2uBENaM2WaCdLPvoB9KOFyF+sDgheUazzw6GF18uS93 QLWyV6Ehvd+pfcOX7kO9KLAwb5ywYUwUQl0pDl3xyCNFWJyOAhOS3ED+A6O9pBd9f0sJ FBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lD83FuXyo4Rd8RPUoclDBjywfkShCLbVEGQP8et9RdA=; b=MJlevJc3qw49Oe+igUp4LBBgH78/cz1SD8EX8RbFiYcNJbinvyK1hW30ypshBZ8Uvr 2+G6k9aHpjq6C64QayKKaWhHyxNlSYJdfP/G9IA8kY7KQR40MqKXBBo+Sz/oNB07bvCQ AM7bCsC9Orn3kDT3MTzO+zmhGxTiC45nHFjkoEg1DxYfBbDK2XUGmm1EU2LAWbi4TCBh wfkw4KdLNrhAlSj6UdsDad9BHCPPHfq7TGoPu6ndQH33r8u7rH3U+5KaINufEslWezxo g5vvbuoG+jSPvEL14FTQeEkc65jQokF9KMBgPHJc+LXTz07N+hQ10yBQWZBorpDVlPTM MHvw== X-Gm-Message-State: AOAM5308dTP9unnMYYssYhQ7TpnPzzVspLJH0JPKReMJ6tLocf8Ao5eT OgTWwt0mFHk3rgv53TX8jQay5ugtMqc187jAM3kXVw== X-Google-Smtp-Source: ABdhPJx3yNmMRnna6IuZi2wjjUunivgAB9HUxf0ytU7h8P5hgdhT/BSdk8MnPBSK6WNNJSgdthA0P2YwONYZ0TUL5D4= X-Received: by 2002:a67:d91b:: with SMTP id t27mr9004281vsj.55.1633435627030; Tue, 05 Oct 2021 05:07:07 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-2-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-2-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:06:55 +0300 Message-ID: Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device() To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > soc_device_to_device() seems to be discouraged [1] so remove it in favor > of printing info message with platform device. This will only change > the prefix in theh info message from "soc soc0: " to "exynos-chipid > 10000000.chipid:". > > [1] https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/ > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/exynos-chipid.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index 5c1d0f97f766..dcd9a08ce706 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -104,8 +104,7 @@ static int exynos_chipid_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, soc_dev); > > - dev_info(soc_device_to_device(soc_dev), > - "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", > + dev_info(&pdev->dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", > soc_dev_attr->soc_id, product_id, revision); > > return 0; > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B60C433EF for ; Tue, 5 Oct 2021 12:09:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B99161163 for ; Tue, 5 Oct 2021 12:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B99161163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v1L7YiMbrmQH9lpT5N+ys5+DGH1ZLHNlXs5txSCqgdY=; b=jPqxdjrPLFxp1O cF8l6r/kC57TzgIqHKayf7UDnG7AKilPAyZESWztwtFA7M6ES/43bA9Xy1kbV641QF2Cdwi6cmXHS a2jaXFqJVB/fYtXLtEp+kvX2cEsYwnJER0PUHAEdGcHUFuBICSNrkb9PCw5j48NCm5Rv0HoQtsF9s rCLCsinkI2DiObZvq06owDUNBdTyyNWTejHkbAkTmiJBK3PVMBe3t52l5/cMX/t4ICP0gnJ0QR6kd uqEvWHc0ZDy0r1Zxo2XeC9OZWxlwsi8IaOSm7OnD14t79ojQ/UKZd7/QFWQHgHYe0HwQelH1pzfje HaQ4s8+Wtgc8+bQ4albA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjDz-00AGx5-UL; Tue, 05 Oct 2021 12:07:12 +0000 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjDv-00AGwF-SP for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 12:07:09 +0000 Received: by mail-vs1-xe35.google.com with SMTP id p2so915581vst.10 for ; Tue, 05 Oct 2021 05:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lD83FuXyo4Rd8RPUoclDBjywfkShCLbVEGQP8et9RdA=; b=hKikOG5IDhmF6NJFOqVeb0VuaR8rP2Ugg7wDlfnHoNKRRg8JMTnBbRNIgtXdsQWhdo nB+w7sIz1XpbQfcRJclH19JCDP6JRv1Ky60u5DpF05LzJZ9lFqyebUb8/IQtRtyg1xNN gEKSTl7MOR0HaJCP/ARXgZjGBZnrbuldsQYd88DrHsQvIx6SBzeI9CPhkWtfAeceIsPZ 057zIf9cGeRjOW/VM+mOdso1O2uBENaM2WaCdLPvoB9KOFyF+sDgheUazzw6GF18uS93 QLWyV6Ehvd+pfcOX7kO9KLAwb5ywYUwUQl0pDl3xyCNFWJyOAhOS3ED+A6O9pBd9f0sJ FBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lD83FuXyo4Rd8RPUoclDBjywfkShCLbVEGQP8et9RdA=; b=XEpHktEtv71wOsFfu97DU05rgrLs+N8Q+pDVu477AAap50tbZsLtci14OY/o6/C17O b39imQ6kFsNFKEV9mP9ATKhd7/f9DJEHhFFyf8tO1LuToh7RrwLSx8co7YaakdHMsWXX yVd+ycuXv6uixhNYQ9lSKZ9nbtu2gM8m21pbHd/JbeLnwj36UuKImygypd8qqwTanbS3 oKkN+a//fDKIuDyUq0y9Ti9y0iNp3LKA1eTZCU9d+HzwCuk4RmgimmAQ0qVvaPZQGEHC 2HcVbeNuw0a91DQbEL12NNVgsNCpboQKN4cTne8l+B9M8PBcGybD5M3gBxtrWG1UnGFD 2ftg== X-Gm-Message-State: AOAM530AQEefQGXH4FOrgaspqsfkUJE1Mc1ySZbW23KJYhzhC3XxM+mv voncO+0vrFvGNZp+l5JnB6LS/N7WC+RT+UoqifAk+g== X-Google-Smtp-Source: ABdhPJx3yNmMRnna6IuZi2wjjUunivgAB9HUxf0ytU7h8P5hgdhT/BSdk8MnPBSK6WNNJSgdthA0P2YwONYZ0TUL5D4= X-Received: by 2002:a67:d91b:: with SMTP id t27mr9004281vsj.55.1633435627030; Tue, 05 Oct 2021 05:07:07 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-2-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-2-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:06:55 +0300 Message-ID: Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device() To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_050707_977518_495827E4 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > soc_device_to_device() seems to be discouraged [1] so remove it in favor > of printing info message with platform device. This will only change > the prefix in theh info message from "soc soc0: " to "exynos-chipid > 10000000.chipid:". > > [1] https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/ > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/exynos-chipid.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index 5c1d0f97f766..dcd9a08ce706 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -104,8 +104,7 @@ static int exynos_chipid_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, soc_dev); > > - dev_info(soc_device_to_device(soc_dev), > - "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", > + dev_info(&pdev->dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", > soc_dev_attr->soc_id, product_id, revision); > > return 0; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel