From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D03BAC433F5 for ; Tue, 5 Oct 2021 12:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9EE761163 for ; Tue, 5 Oct 2021 12:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234637AbhJEMJe (ORCPT ); Tue, 5 Oct 2021 08:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbhJEMJ2 (ORCPT ); Tue, 5 Oct 2021 08:09:28 -0400 Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E4B1C061753 for ; Tue, 5 Oct 2021 05:07:37 -0700 (PDT) Received: by mail-vs1-xe2c.google.com with SMTP id p2so917405vst.10 for ; Tue, 05 Oct 2021 05:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NMod5kv6mgBP+Lyuh+sVjFWXXjpByRzbJbxi4k3EgsI=; b=dKw9bQhzayOGjFRE3NoOdUQWH6uCbVW9FfwtlS53KSymDvI19CKdfrKmX4kio/TAU3 0Jn5zcm9ITLezTMjCY2YQTAceLs8c56SZI+78Kub+aBf9DKi3Nt1doq4P9JblkI+hFGz pD8HBW34/F8SanhmG42y2fvoUu/6vjVDcQp2GZLaYh8avPeeXo9VgiPa7jVn6kMBsWd9 doCLBRX4X4bZeG1E7J1yT0saKVyTFjN1i165ZKVdyySLsB1iNUaVpwrKPhUQdnszS4gM hN8JpbHN7UxS2XE9SceLySXOouV4JQf93DgjMpdy9L290wcId5KJ9ob5cQanl36JWBJo U19Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NMod5kv6mgBP+Lyuh+sVjFWXXjpByRzbJbxi4k3EgsI=; b=6pKYvbpsUcmtvSSlgBfbfLtwx7GIvtQR2PwhqVrcmInv/Ou3xuLPbujVB5VSs0E9fn SZu4WkgS23cywr5W7ecsElxTFEFbQZg2+VPxqkAONsbJdX0EqYtV5eZsO/gL9q9DoD2e a4EWCLVwGrGoImRAmPPT/5iKCRcqEC28kO8HmvN1IRJ34UmG4pAdDWxtuEFhmxTMvK// PdDDx9wisvnzPkUbIDeGyF1+LMBJcgBLTrkb6X7snsYMoEwueWguTvSOONrfExCIX+lc jm7Mb7wrCTyidIrsUseyI0S2PEXoVIaF4CWTtSv/5+L4gqP4mwY6No1ABFEmBiWLiFML +JFw== X-Gm-Message-State: AOAM533BoMqXg510iYkshYdmrzBlLuf+iR6XWOqgNTIAcbKZEUCyfb5d 2jD/0MUEjHz5RkdfMzE8nIGaLspNVxXIHMPbQw8MIA== X-Google-Smtp-Source: ABdhPJynizbQFCeZG9BwAOTaCKB+w3D26HKETWiOzcDEcyyn503ncEKZty/6FmuTlm97gQ7yAvJmmpNAZBJh/8IDf/E= X-Received: by 2002:a67:1781:: with SMTP id 123mr17925487vsx.1.1633435656646; Tue, 05 Oct 2021 05:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-3-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-3-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:07:25 +0300 Message-ID: Subject: Re: [PATCH v2 2/3] soc: samsung: exynos-chipid: convert to a module To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > Exynos ChipID and ASV (Adaptive Supply Voltage) driver is not essential > to system boot and it can successfully be built and loaded as module. > > This makes core kernel image smaller and reduces the memory footprint > when multi-platform kernel is booted on non-Exynos board. Usually it is > also distro-friendly. > > Add multiple authors of the driver since its conversion from > mach-exynos, ordered alphabetically by first name. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/Kconfig | 3 ++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 11 ++++++++++- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 4 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 1f643c0f5c93..fe139f26d093 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,13 +13,14 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > help > Support for Samsung Exynos SoC ChipID and Adaptive Supply Voltage. > + This driver can also be built as module (exynos_chipid). > > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 0c523a8de4eb..2ae4bea804cf 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,8 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos_chipid.o > +exynos_chipid-y += exynos-chipid.o exynos-asv.o > > -obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o exynos-asv.o > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o > > obj-$(CONFIG_EXYNOS_PMU_ARM_DRIVERS) += exynos3250-pmu.o exynos4-pmu.o \ > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index dcd9a08ce706..b2627a3a127a 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -128,6 +129,7 @@ static const struct of_device_id exynos_chipid_of_device_ids[] = { > { .compatible = "samsung,exynos4210-chipid" }, > {} > }; > +MODULE_DEVICE_TABLE(of, exynos_chipid_of_device_ids); > > static struct platform_driver exynos_chipid_driver = { > .driver = { > @@ -137,4 +139,11 @@ static struct platform_driver exynos_chipid_driver = { > .probe = exynos_chipid_probe, > .remove = exynos_chipid_remove, > }; > -builtin_platform_driver(exynos_chipid_driver); > +module_platform_driver(exynos_chipid_driver); > + > +MODULE_DESCRIPTION("Samsung Exynos ChipID controller and ASV driver"); > +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz "); > +MODULE_AUTHOR("Krzysztof Kozlowski "); > +MODULE_AUTHOR("Pankaj Dubey "); > +MODULE_AUTHOR("Sylwester Nawrocki "); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c > index ca409a976e34..475ae5276529 100644 > --- a/drivers/soc/samsung/exynos5422-asv.c > +++ b/drivers/soc/samsung/exynos5422-asv.c > @@ -503,3 +503,4 @@ int exynos5422_asv_init(struct exynos_asv *asv) > > return 0; > } > +EXPORT_SYMBOL_GPL(exynos5422_asv_init); > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35EF0C433EF for ; Tue, 5 Oct 2021 12:09:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F413C61163 for ; Tue, 5 Oct 2021 12:09:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F413C61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=98lqCt4srASCMUTRQeosiu5FJOtfZf4OalfnM/woi1M=; b=Mz0CN7dddpvrFk 8hvCH+xlWH0nIyOMFkobdhGM01QJg4Foq3ruWK0IIjVCxM+KwDiK1XznGBkdbi49xICykcf1segok OOP9VsYkymebOp9zrPFY2GxCnpGhST5uuwG5sV4miYN42r5aauue631Ud3G1yCyUP9y6fmq/ZOW08 33W0fwIqXAFZC8yqZejcMknkKdy9pl9Nx7q0J3kQhCZ0tiAZZFQA5g/UsbyqDNjjv9EutWNezV50K uUdRRmjNsD9co8MCBGV7QrGuF2Au6eChTidb0P6pXjbJginTKC24pNZL2jXhHMRqIiRf9a2/PyCo9 4tNe1xw7ldlA9TsgJ61A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjEW-00AH4Y-08; Tue, 05 Oct 2021 12:07:44 +0000 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjEQ-00AH2a-5L for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 12:07:40 +0000 Received: by mail-vs1-xe36.google.com with SMTP id p2so917407vst.10 for ; Tue, 05 Oct 2021 05:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NMod5kv6mgBP+Lyuh+sVjFWXXjpByRzbJbxi4k3EgsI=; b=dKw9bQhzayOGjFRE3NoOdUQWH6uCbVW9FfwtlS53KSymDvI19CKdfrKmX4kio/TAU3 0Jn5zcm9ITLezTMjCY2YQTAceLs8c56SZI+78Kub+aBf9DKi3Nt1doq4P9JblkI+hFGz pD8HBW34/F8SanhmG42y2fvoUu/6vjVDcQp2GZLaYh8avPeeXo9VgiPa7jVn6kMBsWd9 doCLBRX4X4bZeG1E7J1yT0saKVyTFjN1i165ZKVdyySLsB1iNUaVpwrKPhUQdnszS4gM hN8JpbHN7UxS2XE9SceLySXOouV4JQf93DgjMpdy9L290wcId5KJ9ob5cQanl36JWBJo U19Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NMod5kv6mgBP+Lyuh+sVjFWXXjpByRzbJbxi4k3EgsI=; b=LZWfHXGdqXAjWC9MKeiDDDM6Ox1qMuk9ulxUzLcVrEeGL6QQLf4j9v/BTOHP7tvui6 sGPCxCBshBzIxaLNI5AeaRHe/mPHZ950Bc2LXgIjzPEZ8d6beR8oZYPxtqNcvt33qRtf /2YaeonDcix8uZhzuwv3FzUOnhh63vXLDPJqRMjJiOpzOcxcJQlU4ohB0j9wDKrDsJg9 rUVOUQk9YBQgDDMRWQdnTTyHETZ8hpketuJcdbNemgkIOoo85WgJ1/KN5vl6PBwSGdOc 2rihor0oDObvWLZT6aVcREhYARPL6vhCI4ySD8RQhSxxBLUfBarTnGNWnzOf/ieF06SZ IZAQ== X-Gm-Message-State: AOAM531e/Vy4NAPxs2JlqAvMktB7hFUdAWfqrQC8tQy9kcm6J1Te2mNm Uup1QEf/VHhZskcCVZiSI3vI7tAY96F/tOnF9cDZtA== X-Google-Smtp-Source: ABdhPJynizbQFCeZG9BwAOTaCKB+w3D26HKETWiOzcDEcyyn503ncEKZty/6FmuTlm97gQ7yAvJmmpNAZBJh/8IDf/E= X-Received: by 2002:a67:1781:: with SMTP id 123mr17925487vsx.1.1633435656646; Tue, 05 Oct 2021 05:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-3-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-3-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:07:25 +0300 Message-ID: Subject: Re: [PATCH v2 2/3] soc: samsung: exynos-chipid: convert to a module To: Krzysztof Kozlowski Cc: Russell King , linux-arm Mailing List , Linux Samsung SOC , Linux Kernel Mailing List , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_050738_243587_F5DFB06E X-CRM114-Status: GOOD ( 27.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski wrote: > > Exynos ChipID and ASV (Adaptive Supply Voltage) driver is not essential > to system boot and it can successfully be built and loaded as module. > > This makes core kernel image smaller and reduces the memory footprint > when multi-platform kernel is booted on non-Exynos board. Usually it is > also distro-friendly. > > Add multiple authors of the driver since its conversion from > mach-exynos, ordered alphabetically by first name. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/Kconfig | 3 ++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 11 ++++++++++- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 4 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 1f643c0f5c93..fe139f26d093 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,13 +13,14 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > help > Support for Samsung Exynos SoC ChipID and Adaptive Supply Voltage. > + This driver can also be built as module (exynos_chipid). > > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 0c523a8de4eb..2ae4bea804cf 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,8 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos_chipid.o > +exynos_chipid-y += exynos-chipid.o exynos-asv.o > > -obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o exynos-asv.o > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o > > obj-$(CONFIG_EXYNOS_PMU_ARM_DRIVERS) += exynos3250-pmu.o exynos4-pmu.o \ > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index dcd9a08ce706..b2627a3a127a 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -128,6 +129,7 @@ static const struct of_device_id exynos_chipid_of_device_ids[] = { > { .compatible = "samsung,exynos4210-chipid" }, > {} > }; > +MODULE_DEVICE_TABLE(of, exynos_chipid_of_device_ids); > > static struct platform_driver exynos_chipid_driver = { > .driver = { > @@ -137,4 +139,11 @@ static struct platform_driver exynos_chipid_driver = { > .probe = exynos_chipid_probe, > .remove = exynos_chipid_remove, > }; > -builtin_platform_driver(exynos_chipid_driver); > +module_platform_driver(exynos_chipid_driver); > + > +MODULE_DESCRIPTION("Samsung Exynos ChipID controller and ASV driver"); > +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz "); > +MODULE_AUTHOR("Krzysztof Kozlowski "); > +MODULE_AUTHOR("Pankaj Dubey "); > +MODULE_AUTHOR("Sylwester Nawrocki "); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c > index ca409a976e34..475ae5276529 100644 > --- a/drivers/soc/samsung/exynos5422-asv.c > +++ b/drivers/soc/samsung/exynos5422-asv.c > @@ -503,3 +503,4 @@ int exynos5422_asv_init(struct exynos_asv *asv) > > return 0; > } > +EXPORT_SYMBOL_GPL(exynos5422_asv_init); > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel