From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DED2C433FE for ; Tue, 5 Oct 2021 12:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD15061425 for ; Tue, 5 Oct 2021 12:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbhJEMFk (ORCPT ); Tue, 5 Oct 2021 08:05:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbhJEMFi (ORCPT ); Tue, 5 Oct 2021 08:05:38 -0400 Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64384C061749 for ; Tue, 5 Oct 2021 05:03:48 -0700 (PDT) Received: by mail-vs1-xe2c.google.com with SMTP id o124so23342427vsc.6 for ; Tue, 05 Oct 2021 05:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HqbKX+VNWiRtUH7hwIBdqXVzeWXo/aDW9j/mMe6CT9Q=; b=Jxx52nQjwLKwrPqBK5J9SqX3ZpzNBu7vyOyPdeW82CnOQSqmG0hIH1TByL+Leycwup XBWkH06NvGKXQQNai223elsh1KL6akW6OCQYempohuiwSEpdxtDVayFwGBAgoCpFRif1 KjKqA22rrpT32g7m5WSKcOJiUCpUkvH/FT4MYxS3475s4QuVy9xCAJvzfsBkIUDa2Dd8 IM76MjcI1JX8JJgSgh3vEuFn2Yo2H48DRKjUkzbLvapE4c4LFKX2e41Qc8uc9FZ9zB4c Fa2Ml2CwlR6/n3p3aypY6V9b03+KPOb4rrQiNl+nssGzCeGPuvodSU9A9w1t1V9CLsMr KI7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HqbKX+VNWiRtUH7hwIBdqXVzeWXo/aDW9j/mMe6CT9Q=; b=7Ox1e7vCQl2XJcgUUCqhBjkNVPHzcoBNerbD94Y6kWvdrwiVi6TVIVHLi0F/fuY6DV TutSSBESEzPbXmVnQGFsJwrS2VmN/vvxuyRpP4nR2HsR/22Gn+p0flF1g2txc3v0EGX7 OPsxBvyCRDsyFEBpPsKuLQ81QvF3g7dpxOxcyiNTUgTGreeLpPkHYofpFlTKcnjhDrxc L7nn2pkEb2gSNtZhZQd3DkaRtVZG5LB0rYhtwPAKprCM6acFALqVK5SkJ2fhfKOgwNbP T47OCNq9lGw7bt0XbgDvgYvW3f2qGpTWtlMvAIpoKSfGQDH2ysHpaUsJWnXjfeaV/U82 POGg== X-Gm-Message-State: AOAM533FnNzfMnF5k+47puI2jEL9IBL6ZoVpWgG93ks5Yg1bZUtJkYxA 0e2G5U7/BtDMVeL2AjJCObFYWP4Giu0OC+9PNPUyyw== X-Google-Smtp-Source: ABdhPJza1u3lC+ZNbsp5i9/gcvrItb0CCbFgI4/IPF66MKhw0dUbPR0x2t27G0thTcZVDx5m2/P9sFyOeuf5o6HYyDY= X-Received: by 2002:a67:d289:: with SMTP id z9mr8927314vsi.39.1633435427435; Tue, 05 Oct 2021 05:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210917175134.252882-1-krzysztof.kozlowski@canonical.com> <20210917175134.252882-3-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210917175134.252882-3-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:03:35 +0300 Message-ID: Subject: Re: [PATCH 2/2] soc: samsung: exynos-chipid: convert to a module To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-arm Mailing List , Linux Samsung SOC , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Sept 2021 at 20:51, Krzysztof Kozlowski wrote: > > Exynos ChipID and ASV (Adaptive Supply Voltage) driver is not essential > to system boot and it can successfully be built and loaded as module. > > This makes core kernel image smaller and reduces the memory footprint > when multi-platform kernel is booted on non-Exynos board. Usually it is > also distro-friendly. > > Add multiple authors of the driver since its conversion from > mach-exynos, ordered alphabetically by first name. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/Kconfig | 3 ++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 11 ++++++++++- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 4 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 1f643c0f5c93..fe139f26d093 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,13 +13,14 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > help > Support for Samsung Exynos SoC ChipID and Adaptive Supply Voltage. > + This driver can also be built as module (exynos_chipid). > > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 0c523a8de4eb..2ae4bea804cf 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,8 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos_chipid.o > +exynos_chipid-y += exynos-chipid.o exynos-asv.o > > -obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o exynos-asv.o > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o > > obj-$(CONFIG_EXYNOS_PMU_ARM_DRIVERS) += exynos3250-pmu.o exynos4-pmu.o \ > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index 5c1d0f97f766..5e8c957231ff 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -129,6 +130,7 @@ static const struct of_device_id exynos_chipid_of_device_ids[] = { > { .compatible = "samsung,exynos4210-chipid" }, > {} > }; > +MODULE_DEVICE_TABLE(of, exynos_chipid_of_device_ids); > > static struct platform_driver exynos_chipid_driver = { > .driver = { > @@ -138,4 +140,11 @@ static struct platform_driver exynos_chipid_driver = { > .probe = exynos_chipid_probe, > .remove = exynos_chipid_remove, > }; > -builtin_platform_driver(exynos_chipid_driver); > +module_platform_driver(exynos_chipid_driver); > + > +MODULE_DESCRIPTION("Samsung Exynos ChipID controller and ASV driver"); Just curious, how exactly ASV is related to chip-id driver? > +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz "); > +MODULE_AUTHOR("Krzysztof Kozlowski "); > +MODULE_AUTHOR("Pankaj Dubey "); > +MODULE_AUTHOR("Sylwester Nawrocki "); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c > index ca409a976e34..475ae5276529 100644 > --- a/drivers/soc/samsung/exynos5422-asv.c > +++ b/drivers/soc/samsung/exynos5422-asv.c > @@ -503,3 +503,4 @@ int exynos5422_asv_init(struct exynos_asv *asv) > > return 0; > } > +EXPORT_SYMBOL_GPL(exynos5422_asv_init); > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D26C433F5 for ; Tue, 5 Oct 2021 12:06:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD4B613D5 for ; Tue, 5 Oct 2021 12:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BBD4B613D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VF2VacTG4kYcsx+fYgb8plS62Twshx1jNP9Rwi39tic=; b=mZIy4nIlEQylKg LO2v4nGEhyv8D5HxAPYAqEKX1D+5ryTMghJjS6qWSCceGRn7fvjjoDAeMMpgGFBlYnte02QZ8XiNs VOMtaJELdy7KT1v0ne9m/xRXBJ4oKQx3lb0JxOrcrzJtXWjeyKzjSp3xtz22W3u8aEC3v7AiUENkL Aes7gSbbH6dvaC+in1WoABirucVzh2PBh5IfsiEnyEiU03zK+Yp3ZCBpY0b2V6943fP59ml+z+p4D N+ptzT0cTkBweUkgQ8Byst/rHu2zWhFe2kdSHz78RaaXn3xMlkqju0aE7SuPomhbu/6baTDqO1WI5 3oXgkkMXmQHvZFSPHPJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjAo-00AGNK-Em; Tue, 05 Oct 2021 12:03:54 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjAl-00AGML-Av for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 12:03:52 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id d18so724253vsh.1 for ; Tue, 05 Oct 2021 05:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HqbKX+VNWiRtUH7hwIBdqXVzeWXo/aDW9j/mMe6CT9Q=; b=Jxx52nQjwLKwrPqBK5J9SqX3ZpzNBu7vyOyPdeW82CnOQSqmG0hIH1TByL+Leycwup XBWkH06NvGKXQQNai223elsh1KL6akW6OCQYempohuiwSEpdxtDVayFwGBAgoCpFRif1 KjKqA22rrpT32g7m5WSKcOJiUCpUkvH/FT4MYxS3475s4QuVy9xCAJvzfsBkIUDa2Dd8 IM76MjcI1JX8JJgSgh3vEuFn2Yo2H48DRKjUkzbLvapE4c4LFKX2e41Qc8uc9FZ9zB4c Fa2Ml2CwlR6/n3p3aypY6V9b03+KPOb4rrQiNl+nssGzCeGPuvodSU9A9w1t1V9CLsMr KI7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HqbKX+VNWiRtUH7hwIBdqXVzeWXo/aDW9j/mMe6CT9Q=; b=1yIsBxcY+jRbVE8gZeLgACmTbEHTxdso+9I1CiYQA+kOQL8IkTqfG7iNUrTvEXAPkL AuhPVzvMT48kKbUA9DL95erA0jHYmpImve55YA3UF9lrYROQ/qWqj10xSHX5eq84TlD9 kc2aQDho3SUC5W6Yuw7xO+oE6zxUpHCfCTVbBVKZJjz39MJeM8sua/h3HxcUhkOJYIXr KogdEnMhZGJCQH2sFRC/KV5fMZ8bgd5FjpOFyyQpmy815W+p4mz+/uITnV4wVnw19ey2 7ef9dLMm8/ObCn0FgmPFOjNfod0OgIsp45as76w2esH2r3cgKEIof2hYCHmL0LVDtmKf RClg== X-Gm-Message-State: AOAM530z3VKWwg01X1xzP+Ydvxa4eExBuP30EOFO9St3iMO5IpLqFVPt b5685xNgvVf7M9hrRdYKGWJDZTiPbvTl7rMTe7nnpw== X-Google-Smtp-Source: ABdhPJza1u3lC+ZNbsp5i9/gcvrItb0CCbFgI4/IPF66MKhw0dUbPR0x2t27G0thTcZVDx5m2/P9sFyOeuf5o6HYyDY= X-Received: by 2002:a67:d289:: with SMTP id z9mr8927314vsi.39.1633435427435; Tue, 05 Oct 2021 05:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210917175134.252882-1-krzysztof.kozlowski@canonical.com> <20210917175134.252882-3-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210917175134.252882-3-krzysztof.kozlowski@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 15:03:35 +0300 Message-ID: Subject: Re: [PATCH 2/2] soc: samsung: exynos-chipid: convert to a module To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-arm Mailing List , Linux Samsung SOC , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_050351_402658_63462E24 X-CRM114-Status: GOOD ( 27.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Sept 2021 at 20:51, Krzysztof Kozlowski wrote: > > Exynos ChipID and ASV (Adaptive Supply Voltage) driver is not essential > to system boot and it can successfully be built and loaded as module. > > This makes core kernel image smaller and reduces the memory footprint > when multi-platform kernel is booted on non-Exynos board. Usually it is > also distro-friendly. > > Add multiple authors of the driver since its conversion from > mach-exynos, ordered alphabetically by first name. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Sam Protsenko > drivers/soc/samsung/Kconfig | 3 ++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 11 ++++++++++- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 4 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 1f643c0f5c93..fe139f26d093 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -13,13 +13,14 @@ config EXYNOS_ASV_ARM > depends on EXYNOS_CHIPID > > config EXYNOS_CHIPID > - bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST > + tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > select MFD_SYSCON > select SOC_BUS > help > Support for Samsung Exynos SoC ChipID and Adaptive Supply Voltage. > + This driver can also be built as module (exynos_chipid). > > config EXYNOS_PMU > bool "Exynos PMU controller driver" if COMPILE_TEST > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 0c523a8de4eb..2ae4bea804cf 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,8 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos_chipid.o > +exynos_chipid-y += exynos-chipid.o exynos-asv.o > > -obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o exynos-asv.o > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o > > obj-$(CONFIG_EXYNOS_PMU_ARM_DRIVERS) += exynos3250-pmu.o exynos4-pmu.o \ > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index 5c1d0f97f766..5e8c957231ff 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -129,6 +130,7 @@ static const struct of_device_id exynos_chipid_of_device_ids[] = { > { .compatible = "samsung,exynos4210-chipid" }, > {} > }; > +MODULE_DEVICE_TABLE(of, exynos_chipid_of_device_ids); > > static struct platform_driver exynos_chipid_driver = { > .driver = { > @@ -138,4 +140,11 @@ static struct platform_driver exynos_chipid_driver = { > .probe = exynos_chipid_probe, > .remove = exynos_chipid_remove, > }; > -builtin_platform_driver(exynos_chipid_driver); > +module_platform_driver(exynos_chipid_driver); > + > +MODULE_DESCRIPTION("Samsung Exynos ChipID controller and ASV driver"); Just curious, how exactly ASV is related to chip-id driver? > +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz "); > +MODULE_AUTHOR("Krzysztof Kozlowski "); > +MODULE_AUTHOR("Pankaj Dubey "); > +MODULE_AUTHOR("Sylwester Nawrocki "); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c > index ca409a976e34..475ae5276529 100644 > --- a/drivers/soc/samsung/exynos5422-asv.c > +++ b/drivers/soc/samsung/exynos5422-asv.c > @@ -503,3 +503,4 @@ int exynos5422_asv_init(struct exynos_asv *asv) > > return 0; > } > +EXPORT_SYMBOL_GPL(exynos5422_asv_init); > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel