From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SBZP7cvv" Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED5FF1 for ; Sun, 10 Dec 2023 15:34:28 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d05e4a94c3so33869575ad.1 for ; Sun, 10 Dec 2023 15:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702251268; x=1702856068; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k9inBJnm4RRUBTcM8clVN2K31CIq5Yi4neoBQMqj3lw=; b=SBZP7cvvFTSc9dI5gyrQgoKBpoDkSuyp74A1pRYFlCFK/YJUOCZ5McPZ/cpAWcESW9 NgEJ+FvXNkbdUxyqNcj3NDey/amslkAKWQMymlPDaqMGsoAjCr7HArraw1C8EsTpTU0A vR5+v2lq0vQ81zlLU0SDHqneUXN5tOuiwn3kEMfDCLem8VnGArqo5yKh6WJFKPfRSthk TbRd7Gu57v8oCBcZJvu1UOysWTt+VO0jAsbcXbaKf0zAC7v/Fn8IAyXypjIsHeIGd640 o5Htg9Pe9+3Y8oBxx4+DL2sKIVfYIBthnIAOoSBv+rWHwJ7vFHJWTU7vT1vT19sX6SGk iOcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702251268; x=1702856068; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9inBJnm4RRUBTcM8clVN2K31CIq5Yi4neoBQMqj3lw=; b=VdQ75lQcQY8xvjn6518KCKGrzlJYaQXAvZbmCTJIoNNX69cPAsjIJQjgt4bSZ9T7ep AzXHlyIHI6twNbcUFsKCzJsqhQ4Lfjwwjl1nu7UKJyReskMs2Veb+HrJ4j2rSrqs1kH8 2ulOxR4MldaqsSUqXI/T5vi+nIVGVBoMPF5PmZTMhnd7w+UF7jNctz0vdbD8w2pX35cL LXY1XyJyAcN1K+BgmAWdxFyPssjCn6D0cZHFPq9Em0+4HWQG4fBrJOOoTVzbQYDVfAXZ ZE237iTy7N+fYIm1GH43JsNItHdJ8juXOaGqwukGzCAJqNSzbMeRNKy8nkFkucDngKC1 UerA== X-Gm-Message-State: AOJu0YyI5ZQPrWESWW76jp3ihBtsUIxo2BLysmLquDB+lBlIFbr7MrQx eRoIQvgDakl9PDmFTKkSClPQLel3Bi3a7yBrif1TOw== X-Google-Smtp-Source: AGHT+IGc+IvHTENHJ/KXFFp2iBYPliL5WTdTBJgCg+tz9DwtfoGQRHQ4N7s/di11rwfak1O7RMTB2P48Vdkm1Es9RHA= X-Received: by 2002:a17:90a:94c7:b0:286:7f04:23c0 with SMTP id j7-20020a17090a94c700b002867f0423c0mr2376721pjw.4.1702251267601; Sun, 10 Dec 2023 15:34:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231209233106.147416-1-peter.griffin@linaro.org> <20231209233106.147416-10-peter.griffin@linaro.org> In-Reply-To: <20231209233106.147416-10-peter.griffin@linaro.org> From: Sam Protsenko Date: Sun, 10 Dec 2023 17:34:16 -0600 Message-ID: Subject: Re: [PATCH v6 09/20] dt-bindings: serial: samsung: Make samsung,uart-fifosize a required property To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 9, 2023 at 5:31=E2=80=AFPM Peter Griffin wrote: > > Specifying samsung,uart-fifosize in both DT and driver static data is err= or > prone and relies on driver probe order and dt aliases to be correct. > > Additionally on many Exynos platforms these are (USI) universal serial > interfaces which can be uart, spi or i2c, so it can change per board. > > For google,gs101-uart make samsung,uart-fifosize a required property. > For this platform fifosize now *only* comes from DT. > > Signed-off-by: Peter Griffin > --- Reviewed-by: Sam Protsenko > .../devicetree/bindings/serial/samsung_uart.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b= /Documentation/devicetree/bindings/serial/samsung_uart.yaml > index ccc3626779d9..65d5d361e8f4 100644 > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > @@ -133,6 +133,16 @@ allOf: > - const: uart > - const: clk_uart_baud0 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - google,gs101-uart > + then: > + required: > + - samsung,uart-fifosize > + > unevaluatedProperties: false > > examples: > -- > 2.43.0.472.g3155946c3a-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67BF4C4167B for ; Sun, 10 Dec 2023 23:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/+YaW5fkiYhbB+PlRdOSewHqf8njw3lnYUdsdTvXbSY=; b=1GJn/mHG1nZIBQ r7ppalb0+ORWxud06nE+99hUlxdTlu0iV/1pNCRoYhgsUzcV4NsM44n6LsMskuUZf724ExudHfCIE bhDRJt/ntH8ZdjZlPMqTVZRn3jIaUGgZl97t+Vpps6ToPGV05cxFVR5RjZKQLOC1HTZ9P28S5vB8R qyP+DnH2v4R1EF3DO3NIImDt3MAWuleehBjB8UBBxBv5JUcmecJxg2AgI293+pODjhOQvSdR3XJ0R k1q6pQM1SzW8qT9zDSva/aK1d7IAgAjdSMo+kLKYJv+EAT5+rHiLm4uwRBYywTX3FoddqLC60KhID XwggAdDvDrhwUn1H/7kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCTJi-003cFe-0l; Sun, 10 Dec 2023 23:34:34 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCTJe-003cEY-1A for linux-arm-kernel@lists.infradead.org; Sun, 10 Dec 2023 23:34:32 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cfb30ce241so33988225ad.0 for ; Sun, 10 Dec 2023 15:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702251268; x=1702856068; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k9inBJnm4RRUBTcM8clVN2K31CIq5Yi4neoBQMqj3lw=; b=NmmdLXPFUgxpcHiW5m2HwjXZbka3/5ULUXFG39/oiOc8k286ejGRGpnIhKa3F2p34I XuiZh8JI6lkMJp/jjnET11B2hG9V3U3/AcfbxG1dQKGE5pIFbCtcO4rCKHxwhayPBN2x uExm8G1C7XA2xNIfDaeEvzJc5HjJHI5mg3P/vK2NC18GWt1G6G5GUv6bbmYBXmOUL5A6 xX9qPu3VB+x7sHlY4hxYU0K1o+aiXevMXyKvsTnzcTTpIFc1CSR/dXOJiGOtK8Noa7vt nvSFNmVb6Zv84k5xYAccms38y0VtwpqrsGQlx8eAoddpTmTpil+G9UY+Q7957evoK4wU pWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702251268; x=1702856068; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9inBJnm4RRUBTcM8clVN2K31CIq5Yi4neoBQMqj3lw=; b=d7fcYMcOQC69hD8N3NDw4q8plI3mV0C4V3pWlFPZDWjMznysmBLm9fRPU4l9NlqxE0 Ud7GDs4Zt89fSe87+cLF9BCGB0gXir7l0FDC9DCzvq2+k1kT3YVdvPvnKFTy9H7so944 ppxioVhmHjdt6m0cBf4od4Pzufh1YmSa1BbmCSfZYRocu6RAOidBkaFBqfu5jIAbbt8/ IKiN71QufHhaorHWiPp3HtvRE0riFAHkDwX/jEsknSrXh4uwEI+QE0YcjiXwVtPrar8T fo1GDkEuj3PxtScpDpKUuW6jqRZE0UtOP4ATvAgWPn3Q2glNhcAPXMajLjiJQDalFJww ej/A== X-Gm-Message-State: AOJu0YxuWYXI9c8cv2Zu0UKdSf55bipwVmcNTGbJC8+yNw+jkJs7Y8ie E+/TPDGO+aGe7gUC7NcTT1b29yhWtqMl0raoUbF/Uw== X-Google-Smtp-Source: AGHT+IGc+IvHTENHJ/KXFFp2iBYPliL5WTdTBJgCg+tz9DwtfoGQRHQ4N7s/di11rwfak1O7RMTB2P48Vdkm1Es9RHA= X-Received: by 2002:a17:90a:94c7:b0:286:7f04:23c0 with SMTP id j7-20020a17090a94c700b002867f0423c0mr2376721pjw.4.1702251267601; Sun, 10 Dec 2023 15:34:27 -0800 (PST) MIME-Version: 1.0 References: <20231209233106.147416-1-peter.griffin@linaro.org> <20231209233106.147416-10-peter.griffin@linaro.org> In-Reply-To: <20231209233106.147416-10-peter.griffin@linaro.org> From: Sam Protsenko Date: Sun, 10 Dec 2023 17:34:16 -0600 Message-ID: Subject: Re: [PATCH v6 09/20] dt-bindings: serial: samsung: Make samsung,uart-fifosize a required property To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231210_153430_538701_DAEB3577 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBEZWMgOSwgMjAyMyBhdCA1OjMx4oCvUE0gUGV0ZXIgR3JpZmZpbiA8cGV0ZXIuZ3Jp ZmZpbkBsaW5hcm8ub3JnPiB3cm90ZToKPgo+IFNwZWNpZnlpbmcgc2Ftc3VuZyx1YXJ0LWZpZm9z aXplIGluIGJvdGggRFQgYW5kIGRyaXZlciBzdGF0aWMgZGF0YSBpcyBlcnJvcgo+IHByb25lIGFu ZCByZWxpZXMgb24gZHJpdmVyIHByb2JlIG9yZGVyIGFuZCBkdCBhbGlhc2VzIHRvIGJlIGNvcnJl Y3QuCj4KPiBBZGRpdGlvbmFsbHkgb24gbWFueSBFeHlub3MgcGxhdGZvcm1zIHRoZXNlIGFyZSAo VVNJKSB1bml2ZXJzYWwgc2VyaWFsCj4gaW50ZXJmYWNlcyB3aGljaCBjYW4gYmUgdWFydCwgc3Bp IG9yIGkyYywgc28gaXQgY2FuIGNoYW5nZSBwZXIgYm9hcmQuCj4KPiBGb3IgZ29vZ2xlLGdzMTAx LXVhcnQgbWFrZSBzYW1zdW5nLHVhcnQtZmlmb3NpemUgYSByZXF1aXJlZCBwcm9wZXJ0eS4KPiBG b3IgdGhpcyBwbGF0Zm9ybSBmaWZvc2l6ZSBub3cgKm9ubHkqIGNvbWVzIGZyb20gRFQuCj4KPiBT aWduZWQtb2ZmLWJ5OiBQZXRlciBHcmlmZmluIDxwZXRlci5ncmlmZmluQGxpbmFyby5vcmc+Cj4g LS0tCgpSZXZpZXdlZC1ieTogU2FtIFByb3RzZW5rbyA8c2VtZW4ucHJvdHNlbmtvQGxpbmFyby5v cmc+Cgo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9zZXJpYWwvc2Ftc3VuZ191YXJ0LnlhbWwg ICAgICAgfCAxMCArKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp Cj4KPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Nlcmlh bC9zYW1zdW5nX3VhcnQueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9z ZXJpYWwvc2Ftc3VuZ191YXJ0LnlhbWwKPiBpbmRleCBjY2MzNjI2Nzc5ZDkuLjY1ZDVkMzYxZThm NCAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc2VyaWFs L3NhbXN1bmdfdWFydC55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3NlcmlhbC9zYW1zdW5nX3VhcnQueWFtbAo+IEBAIC0xMzMsNiArMTMzLDE2IEBAIGFsbE9m Ogo+ICAgICAgICAgICAgICAtIGNvbnN0OiB1YXJ0Cj4gICAgICAgICAgICAgIC0gY29uc3Q6IGNs a191YXJ0X2JhdWQwCj4KPiArICAtIGlmOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICAg IGNvbXBhdGlibGU6Cj4gKyAgICAgICAgICBjb250YWluczoKPiArICAgICAgICAgICAgZW51bToK PiArICAgICAgICAgICAgICAtIGdvb2dsZSxnczEwMS11YXJ0Cj4gKyAgICB0aGVuOgo+ICsgICAg ICByZXF1aXJlZDoKPiArICAgICAgICAtIHNhbXN1bmcsdWFydC1maWZvc2l6ZQo+ICsKPiAgdW5l dmFsdWF0ZWRQcm9wZXJ0aWVzOiBmYWxzZQo+Cj4gIGV4YW1wbGVzOgo+IC0tCj4gMi40My4wLjQ3 Mi5nMzE1NTk0NmMzYS1nb29nCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK