From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2FFC433FE for ; Tue, 5 Oct 2021 09:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0004461215 for ; Tue, 5 Oct 2021 09:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233775AbhJEJ7D (ORCPT ); Tue, 5 Oct 2021 05:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233365AbhJEJ7C (ORCPT ); Tue, 5 Oct 2021 05:59:02 -0400 Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B60A3C061745 for ; Tue, 5 Oct 2021 02:57:11 -0700 (PDT) Received: by mail-vk1-xa2a.google.com with SMTP id x207so9029675vke.2 for ; Tue, 05 Oct 2021 02:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5tyZ1L4nPxHAH57fPWcCNfvTj6DGtahCV/QiQgPB4f0=; b=w6WrpcoLhjiXUHF0pSlcCde3W3uqzcYz6OKbgnEaoYfsjMFccUF39SiE6HKJr2E9yf OgR6+50MXyzsGvfduM48g3XoZFulVjK2VFTXlV3QueU4lT2Wk8CN9GsvSBi55UbJXOXX wQ/7uJUi1+Hfweauq0/hWJ3nQaNQVo1FMIi3WkwTHzeyShGK08Y81G9Atx2+tNgXkuEZ tRXZTIp08hpwg7VDQzccA5vCO2iuySmkCxMwVYaGZ5vwmR6Ccj6lLOaQjkkiIJITaEAV P1qNBxRz4O6H8klxQbXOUo3Xdm9oM27ER8/RGyJploTJkGBCCYGw4iRZegjux/pdwMHU 8n0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5tyZ1L4nPxHAH57fPWcCNfvTj6DGtahCV/QiQgPB4f0=; b=RIPVhyWONJt7VqVuN7AlavnJGyfKOVF5ZUEX6p2zotvj+pXiWbIwWpkaetMjmvdVfM weuqAI85KEgJ/3XtDfzTCC+bKt+2fcujmdeXAsuDv71YzMFOaXcW95bPNLAAmuAJ0FZ5 qcp3HMxCfYHw8raD97/i73uzuyEhVanIqjdYiNKIllzzXATUdoQMF7Cbp0CF+FaeVnm+ wPId89W5jjTyU7qmKeS2Q77qsILjG2rErgvD9uYkGlA6RWxEGP3MaF/hp7IREaOJYy3V 3txKCSqMjX9kf95lSp+yV9YYMducaHlR5sKVhC+MGwMQWU8lBob7NE1x5YhsdCanJYlw Ch3Q== X-Gm-Message-State: AOAM531JKVRsEgTi5TyzCPPSGU2wvt9cLIHmpju6htc32i6b4AcQ9Iq4 iResKWUUFQSi0YWq7UfzsMl2Y+VKRoFVYGvAjLulig== X-Google-Smtp-Source: ABdhPJxkOlO4SYnOan3kE1N3PVnE07RjPPQhgqdJa8q8rTuO1aJhb1yAzCCR3efsvdB7JDWMo19sbFRbS33OTJ8AmG0= X-Received: by 2002:a1f:1bc6:: with SMTP id b189mr19231679vkb.15.1633427830840; Tue, 05 Oct 2021 02:57:10 -0700 (PDT) MIME-Version: 1.0 References: <20210914142315.26596-1-semen.protsenko@linaro.org> <6efec37b-4392-dffe-1bda-d4f7aac6643f@canonical.com> In-Reply-To: <6efec37b-4392-dffe-1bda-d4f7aac6643f@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 12:56:59 +0300 Message-ID: Subject: Re: [PATCH] tty: serial: samsung: Improve naming for common macro To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Jiri Slaby , linux-arm Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Sept 2021 at 10:28, Krzysztof Kozlowski wrote: > > On 14/09/2021 16:23, Sam Protsenko wrote: > > Having "_USI" suffix in EXYNOS_COMMON_SERIAL_DRV_DATA_USI() macro is > > confusing. Rename it to just EXYNOS_COMMON_SERIAL_DRV_DATA() and provide > > USI registers availability for all Exynos variants instead. > > > > Signed-off-by: Sam Protsenko > > --- > > drivers/tty/serial/samsung_tty.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-)> > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > index e2f49863e9c2..542b7e2b99dc 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -2780,7 +2780,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > > #endif > > > > #if defined(CONFIG_ARCH_EXYNOS) > > -#define EXYNOS_COMMON_SERIAL_DRV_DATA_USI(_has_usi) \ > > +#define EXYNOS_COMMON_SERIAL_DRV_DATA(_has_usi) \ > > .info = &(struct s3c24xx_uart_info) { \ > > .name = "Samsung Exynos UART", \ > > .type = TYPE_S3C6400, \ > > @@ -2804,21 +2804,18 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > > .has_fracval = 1, \ > > } \ > > > > -#define EXYNOS_COMMON_SERIAL_DRV_DATA \ > > - EXYNOS_COMMON_SERIAL_DRV_DATA_USI(0) > > - > > static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA, > > + EXYNOS_COMMON_SERIAL_DRV_DATA(0), > > .fifosize = { 256, 64, 16, 16 }, > > }; > > > > static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA, > > + EXYNOS_COMMON_SERIAL_DRV_DATA(0), > > .fifosize = { 64, 256, 16, 256 }, > > }; > > > > static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), > > Makes sense, although I would prefer to have here true or false. More > obvious. Otherwise "1" looks like counter/number for some property. > > The has_usi field in struct could be then also converted to bool. > No problem, will send v2 shortly. > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3578C433EF for ; Tue, 5 Oct 2021 09:59:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8130A610A5 for ; Tue, 5 Oct 2021 09:59:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8130A610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t1Bsa5DJM1n3FMM4zwqC41+3/HKz2MoBgYfDIT+rzPI=; b=zVGxX1ZDwcoEun XrDDljU4/QtBzU5bZ5AgYMICe8U4znoRZkCvaHwfvBz4WtWlJ04SXq1LKxTzwvd35F7xyJC/+l3ky uF+9ZXlXWlCgwyx166ExEfSJzzrq2TzFlC2uCVEawrxQGBPt5qMQ0/lK6XFjYm3a9h8erW4ZMN53M tokZq05YeYFc+kPC5OWAa5eAqpIEHA3i/irTUoSWJEN1UUC8V1nWIeHMrMh4/uiBp3ZuCxwi8+Hr8 VuKxXhunzYyret5ZJYWX99nU5w2IGWoiDCh/sVGPb0a0ztm+ghBnee7oaOSWiHnZjpQCsJU4Iy0rm egz6VgCTL6FYJeMh8RPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXhCG-009sdZ-T9; Tue, 05 Oct 2021 09:57:17 +0000 Received: from mail-vk1-xa2d.google.com ([2607:f8b0:4864:20::a2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXhCD-009scW-1k for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 09:57:14 +0000 Received: by mail-vk1-xa2d.google.com with SMTP id u66so3220410vku.4 for ; Tue, 05 Oct 2021 02:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5tyZ1L4nPxHAH57fPWcCNfvTj6DGtahCV/QiQgPB4f0=; b=w6WrpcoLhjiXUHF0pSlcCde3W3uqzcYz6OKbgnEaoYfsjMFccUF39SiE6HKJr2E9yf OgR6+50MXyzsGvfduM48g3XoZFulVjK2VFTXlV3QueU4lT2Wk8CN9GsvSBi55UbJXOXX wQ/7uJUi1+Hfweauq0/hWJ3nQaNQVo1FMIi3WkwTHzeyShGK08Y81G9Atx2+tNgXkuEZ tRXZTIp08hpwg7VDQzccA5vCO2iuySmkCxMwVYaGZ5vwmR6Ccj6lLOaQjkkiIJITaEAV P1qNBxRz4O6H8klxQbXOUo3Xdm9oM27ER8/RGyJploTJkGBCCYGw4iRZegjux/pdwMHU 8n0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5tyZ1L4nPxHAH57fPWcCNfvTj6DGtahCV/QiQgPB4f0=; b=VQtRf1Dxp36p0dMzxP1d+LlnnhWIBuHvVqMeTC958apnIEVwaqFeqdc5STfaGJHg8N X+1wjNdYiHVU0Qm8n2OYBOiuXDoEjeduBMIB+9VINEbDsMMJRMv3AC2WMT4FU+CD4XAc qhj+d1BvwfwgD1yWqEDY3D7i92EYpiSE+czTO/VADMlShRgpdJSlfI1eNpsfffAfe5HA ZAfUCNguli9rPUIMkZnTn0PicNHUwvDqS7SuViGR+VykaxGPfmj0NK501doKYUBr7UV8 rBf9iij4Vmjvsmtf/BcsjWjPvqaZ9lIBjmfWHMCqzzGXKafXmQMXLkSVelZNy21cjRI+ CbDg== X-Gm-Message-State: AOAM531ZVU5BsrT+zqzhmF2knFqQyPMXAmWKiAVevEp8GpdKkoUjMazK kEFs5ix44bL71jD23SJEyUIElrmPq9orfbftz1J8Sg== X-Google-Smtp-Source: ABdhPJxkOlO4SYnOan3kE1N3PVnE07RjPPQhgqdJa8q8rTuO1aJhb1yAzCCR3efsvdB7JDWMo19sbFRbS33OTJ8AmG0= X-Received: by 2002:a1f:1bc6:: with SMTP id b189mr19231679vkb.15.1633427830840; Tue, 05 Oct 2021 02:57:10 -0700 (PDT) MIME-Version: 1.0 References: <20210914142315.26596-1-semen.protsenko@linaro.org> <6efec37b-4392-dffe-1bda-d4f7aac6643f@canonical.com> In-Reply-To: <6efec37b-4392-dffe-1bda-d4f7aac6643f@canonical.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 12:56:59 +0300 Message-ID: Subject: Re: [PATCH] tty: serial: samsung: Improve naming for common macro To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Jiri Slaby , linux-arm Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_025713_174101_8B0379B8 X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Sept 2021 at 10:28, Krzysztof Kozlowski wrote: > > On 14/09/2021 16:23, Sam Protsenko wrote: > > Having "_USI" suffix in EXYNOS_COMMON_SERIAL_DRV_DATA_USI() macro is > > confusing. Rename it to just EXYNOS_COMMON_SERIAL_DRV_DATA() and provide > > USI registers availability for all Exynos variants instead. > > > > Signed-off-by: Sam Protsenko > > --- > > drivers/tty/serial/samsung_tty.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-)> > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > index e2f49863e9c2..542b7e2b99dc 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -2780,7 +2780,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > > #endif > > > > #if defined(CONFIG_ARCH_EXYNOS) > > -#define EXYNOS_COMMON_SERIAL_DRV_DATA_USI(_has_usi) \ > > +#define EXYNOS_COMMON_SERIAL_DRV_DATA(_has_usi) \ > > .info = &(struct s3c24xx_uart_info) { \ > > .name = "Samsung Exynos UART", \ > > .type = TYPE_S3C6400, \ > > @@ -2804,21 +2804,18 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > > .has_fracval = 1, \ > > } \ > > > > -#define EXYNOS_COMMON_SERIAL_DRV_DATA \ > > - EXYNOS_COMMON_SERIAL_DRV_DATA_USI(0) > > - > > static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA, > > + EXYNOS_COMMON_SERIAL_DRV_DATA(0), > > .fifosize = { 256, 64, 16, 16 }, > > }; > > > > static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA, > > + EXYNOS_COMMON_SERIAL_DRV_DATA(0), > > .fifosize = { 64, 256, 16, 256 }, > > }; > > > > static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > > - EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), > > Makes sense, although I would prefer to have here true or false. More > obvious. Otherwise "1" looks like counter/number for some property. > > The has_usi field in struct could be then also converted to bool. > No problem, will send v2 shortly. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel