From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZMt0DB1Q" Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA58ED for ; Sun, 10 Dec 2023 15:37:37 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-28a1625b503so3328404a91.2 for ; Sun, 10 Dec 2023 15:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702251456; x=1702856256; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ktrngxJslvgVofvGRW3XnDoVArwbSMEwYrvNDYxqRMM=; b=ZMt0DB1Q5u/VunX6/Rvk8gpBiwSPBrENgKzbmODOnncUGcdkh5DCbWUhre+jDkRakt CBjK8novtFlEmzpQJUQrMgiRZv5tBVPuWp4Zc3Hx9Wx70ftNBNw57ZdF5jOur/y6fNh1 Zo0w+91EDn7mPuWQeqK+Li0SrCfwSeH43cnajwANU+X67meTrbmqIz88Yvsl5YUYdAfw wBhkGcMCqqr1y2PUoxD/qNiADxqTa3e0JSjXjfMNed/bQ/F6Tlq0hdzaoi12xiYwr1/x SOCLcL6TJ08o96zDB/XxpSm803FLIpa3GwqUm28YtfyWcwZaAXCU1CyztJbKtDNHPANS k4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702251456; x=1702856256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktrngxJslvgVofvGRW3XnDoVArwbSMEwYrvNDYxqRMM=; b=qbmKFlpN9gXcvYG1YgbezXHceKImkVGDEx04cVz4HRsnDejsJeF7j5wmW+uaCaduQH 7hTKoa7eTSLTPZppsUzRrJq7dDWwT6Ka47Ntfg+oqfVTMfhe+77gavd5ybo3cUNl7vsz 1I+ZamHmonaYS3o+mYXyss054D7OcnQuoakzXE8LBM6TUdLVEW5Ms64GrNhk1piECuM/ dZ1Yf8DI5GSnE5yEBV9MZogXgyTn50ZmNqZV4YuUZRLb4748Yf9kNp1JKwRasd9n729n sUa34Jz3mJfswSrsYT5vSP7wRj7lgfGN8N1aceEcKKHFz1ZtYBJgEVf/szp+xLc4MM9l ZVxQ== X-Gm-Message-State: AOJu0YypfEd3+SLQQgKok6+MilmsbfBoq1Kpa033LAvLQvFdIu4mj0PN tmFmp1fuysEn7ka1+z8Oc9rXOSwu9M8KQ+qMiV3myQ== X-Google-Smtp-Source: AGHT+IGLsgr8i/Ys8RGtN0SYISZJUKEzU9RuUMU3J9K3efZNFIaGcYANt6ADR27OrFr246GC+h9HKAnCTaXxkKGU5BA= X-Received: by 2002:a17:90a:db08:b0:286:6cc1:7803 with SMTP id g8-20020a17090adb0800b002866cc17803mr2455327pjv.70.1702251456635; Sun, 10 Dec 2023 15:37:36 -0800 (PST) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231209233106.147416-1-peter.griffin@linaro.org> <20231209233106.147416-16-peter.griffin@linaro.org> In-Reply-To: <20231209233106.147416-16-peter.griffin@linaro.org> From: Sam Protsenko Date: Sun, 10 Dec 2023 17:37:25 -0600 Message-ID: Subject: Re: [PATCH v6 15/20] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 9, 2023 at 5:31=E2=80=AFPM Peter Griffin wrote: > > Update the remaining QUIRK macros to use the BIT macro. > > Signed-off-by: Peter Griffin > --- Reviewed-by: Sam Protsenko > drivers/watchdog/s3c2410_wdt.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wd= t.c > index 7ecb762a371d..b7a03668f743 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -107,11 +107,11 @@ > * DBGACK_MASK bit disables the watchdog outputs when the SoC is in debu= g mode. > * Debug mode is determined by the DBGACK CPU signal. > */ > -#define QUIRK_HAS_WTCLRINT_REG (1 << 0) > -#define QUIRK_HAS_PMU_MASK_RESET (1 << 1) > -#define QUIRK_HAS_PMU_RST_STAT (1 << 2) > -#define QUIRK_HAS_PMU_AUTO_DISABLE (1 << 3) > -#define QUIRK_HAS_PMU_CNT_EN (1 << 4) > +#define QUIRK_HAS_WTCLRINT_REG BIT(0) > +#define QUIRK_HAS_PMU_MASK_RESET BIT(1) > +#define QUIRK_HAS_PMU_RST_STAT BIT(2) > +#define QUIRK_HAS_PMU_AUTO_DISABLE BIT(3) > +#define QUIRK_HAS_PMU_CNT_EN BIT(4) > #define QUIRK_HAS_DBGACK_BIT BIT(5) > > /* These quirks require that we have a PMU register map */ > -- > 2.43.0.472.g3155946c3a-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FCD0C4167B for ; Sun, 10 Dec 2023 23:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ViZnrm+Hm4HZddPhRhWS81cqxXCwep7KNebpyRE9JdE=; b=hz2QDPZ9gUyWLS RTzYbW4YTracH/mLrKFlraGfQz/bfZYb9fp06Xp0pxYO0Aa2m76p+DWz0syl02A5iqWlBRoIohio4 /MUHKWcYvdLASA78+/0MXme8CmcZoQOzab4juEP+ifmrqi5mZ230czeuAuiuTQkBVZUVfFWlnFAcB ndca8aMFMjZmYO28KP/yeOKKWvCf5+a8uX/JEL4WnmfuvEz8qyy744P3GEQvvec1/4w0H+IxmqMGw /mXXaaEhdYjAjpT4zUOto1ukj+A6m63EKRD1rd46u8+ojJDlCv7fuV80mYokcp2sw9DCL5OoIrVkc HxQs89+2mwXBcPugDmag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCTMl-003cmL-2V; Sun, 10 Dec 2023 23:37:43 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCTMi-003ckv-0g for linux-arm-kernel@lists.infradead.org; Sun, 10 Dec 2023 23:37:41 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-28a1625b503so3328405a91.2 for ; Sun, 10 Dec 2023 15:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702251456; x=1702856256; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ktrngxJslvgVofvGRW3XnDoVArwbSMEwYrvNDYxqRMM=; b=fLRzPxWTlSS1TNEx95w03QZvpRyIDi5gOCLGtyyFQV1vEipiTvgY5qQfPmXxyQBgcu FpFjbJRfMjqtJCYU89PiK3AwtvyzDtTsRFkuqT+YN3RL4ySaFxeR0a/pbafH/U/BCiWE apwHXBZ1Dj6lhx06e0BALHGipzYY12x4B5GW8/q3r9+y9H0olJ0eVYzxNaS/B9z/DfZh D5qz5RymFOcVDNmv88GBYwCrZnRI3bijDgxaxXrx4746ddsybJgywLLldmzFrpqd0kSS uOdGw6TEI26wXVWUOugaCJm2mH2OSWB9DJWALCxFxvVX/SDX84epYtqRm8G73hbrlvUt 2c4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702251456; x=1702856256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktrngxJslvgVofvGRW3XnDoVArwbSMEwYrvNDYxqRMM=; b=fSc9iVA0/ZwB3KKDgovMj/0P+A/GxyTT0EkBmEQsRr1XaFby5ejtckH3RKymWYAPhq LD4M7p0QnknDmh7ffyrSyJ5HAq1mLXmjhKj6926LhUWgjORD+aQiCkKh7BQs92Jo7dRR ep4BwgbfWj9Qm/9dE/fXFFeRkkZHcr68YiBF3oxqNLqRFeY8GO4GjmNQ/B7CJlwdwStR vAgCPpldHuOzeXeyZn7QvMSlc3y4GhILKjloxwTjpfWOBJ7WitMWG388jpy5goJWrUfW anKhGSVq5CAzjL1EH8Bn8kzm/Vi+z0Dc4MdbeeFTwCLtxFZmni0qyLNHCY0gPJWeU1uh KDTA== X-Gm-Message-State: AOJu0Yy9p6gazi2cinEg40RRxDI6+6q88bzxMpEr7ZpOy3/CX6Yj2jt2 fN7/wiZ3SJtfKXVkT/v0S6KE5GuYphge5OFD8IV46g== X-Google-Smtp-Source: AGHT+IGLsgr8i/Ys8RGtN0SYISZJUKEzU9RuUMU3J9K3efZNFIaGcYANt6ADR27OrFr246GC+h9HKAnCTaXxkKGU5BA= X-Received: by 2002:a17:90a:db08:b0:286:6cc1:7803 with SMTP id g8-20020a17090adb0800b002866cc17803mr2455327pjv.70.1702251456635; Sun, 10 Dec 2023 15:37:36 -0800 (PST) MIME-Version: 1.0 References: <20231209233106.147416-1-peter.griffin@linaro.org> <20231209233106.147416-16-peter.griffin@linaro.org> In-Reply-To: <20231209233106.147416-16-peter.griffin@linaro.org> From: Sam Protsenko Date: Sun, 10 Dec 2023 17:37:25 -0600 Message-ID: Subject: Re: [PATCH v6 15/20] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231210_153740_251933_8E2D3703 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBEZWMgOSwgMjAyMyBhdCA1OjMx4oCvUE0gUGV0ZXIgR3JpZmZpbiA8cGV0ZXIuZ3Jp ZmZpbkBsaW5hcm8ub3JnPiB3cm90ZToKPgo+IFVwZGF0ZSB0aGUgcmVtYWluaW5nIFFVSVJLIG1h Y3JvcyB0byB1c2UgdGhlIEJJVCBtYWNyby4KPgo+IFNpZ25lZC1vZmYtYnk6IFBldGVyIEdyaWZm aW4gPHBldGVyLmdyaWZmaW5AbGluYXJvLm9yZz4KPiAtLS0KClJldmlld2VkLWJ5OiBTYW0gUHJv dHNlbmtvIDxzZW1lbi5wcm90c2Vua29AbGluYXJvLm9yZz4KCj4gIGRyaXZlcnMvd2F0Y2hkb2cv czNjMjQxMF93ZHQuYyB8IDEwICsrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3dhdGNoZG9n L3MzYzI0MTBfd2R0LmMgYi9kcml2ZXJzL3dhdGNoZG9nL3MzYzI0MTBfd2R0LmMKPiBpbmRleCA3 ZWNiNzYyYTM3MWQuLmI3YTAzNjY4Zjc0MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3dhdGNoZG9n L3MzYzI0MTBfd2R0LmMKPiArKysgYi9kcml2ZXJzL3dhdGNoZG9nL3MzYzI0MTBfd2R0LmMKPiBA QCAtMTA3LDExICsxMDcsMTEgQEAKPiAgICogREJHQUNLX01BU0sgYml0IGRpc2FibGVzIHRoZSB3 YXRjaGRvZyBvdXRwdXRzIHdoZW4gdGhlIFNvQyBpcyBpbiBkZWJ1ZyBtb2RlLgo+ICAgKiBEZWJ1 ZyBtb2RlIGlzIGRldGVybWluZWQgYnkgdGhlIERCR0FDSyBDUFUgc2lnbmFsLgo+ICAgKi8KPiAt I2RlZmluZSBRVUlSS19IQVNfV1RDTFJJTlRfUkVHICAgICAgICAgICAgICAgICAoMSA8PCAwKQo+ IC0jZGVmaW5lIFFVSVJLX0hBU19QTVVfTUFTS19SRVNFVCAgICAgICAgICAgICAgICgxIDw8IDEp Cj4gLSNkZWZpbmUgUVVJUktfSEFTX1BNVV9SU1RfU1RBVCAgICAgICAgICAgICAgICAgKDEgPDwg MikKPiAtI2RlZmluZSBRVUlSS19IQVNfUE1VX0FVVE9fRElTQUJMRSAgICAgICAgICAgICAoMSA8 PCAzKQo+IC0jZGVmaW5lIFFVSVJLX0hBU19QTVVfQ05UX0VOICAgICAgICAgICAgICAgICAgICgx IDw8IDQpCj4gKyNkZWZpbmUgUVVJUktfSEFTX1dUQ0xSSU5UX1JFRyAgICAgICAgICAgICAgICAg QklUKDApCj4gKyNkZWZpbmUgUVVJUktfSEFTX1BNVV9NQVNLX1JFU0VUICAgICAgICAgICAgICAg QklUKDEpCj4gKyNkZWZpbmUgUVVJUktfSEFTX1BNVV9SU1RfU1RBVCAgICAgICAgICAgICAgICAg QklUKDIpCj4gKyNkZWZpbmUgUVVJUktfSEFTX1BNVV9BVVRPX0RJU0FCTEUgICAgICAgICAgICAg QklUKDMpCj4gKyNkZWZpbmUgUVVJUktfSEFTX1BNVV9DTlRfRU4gICAgICAgICAgICAgICAgICAg QklUKDQpCj4gICNkZWZpbmUgUVVJUktfSEFTX0RCR0FDS19CSVQgICAgICAgICAgICAgICAgICAg QklUKDUpCj4KPiAgLyogVGhlc2UgcXVpcmtzIHJlcXVpcmUgdGhhdCB3ZSBoYXZlIGEgUE1VIHJl Z2lzdGVyIG1hcCAqLwo+IC0tCj4gMi40My4wLjQ3Mi5nMzE1NTk0NmMzYS1nb29nCj4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK