From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH 1 of 5] blktap: remove HAVE_BYTESWAP_H checking, since it's defined by qemu Date: Mon, 19 Dec 2011 12:26:17 +0100 Message-ID: References: <1324288096.9236.6.camel@zakaz.uk.xensource.com> <1324289291.9236.16.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324289291.9236.16.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org 2011/12/19 Ian Campbell : > I think this is the correct option. No need to undef stuff. There is > only one other include of byteswap.h in blktap. > On uclibc, byteswap.h gets included by default, because _GNU_SOURCE implies _BSD_SOURCE there. One solution is to add _POSIX_SOURCE, which prevents the addition of _BSD_SOURCE.