From: Rick Altherr <raltherr@google.com>
To: vishwa <vishwa@linux.vnet.ibm.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: Document on : Time Manager in OpenBMC --> Need your review.
Date: Mon, 22 Aug 2016 16:44:05 -0700 [thread overview]
Message-ID: <CAPLgG=koY4pB-kc=2eVCg5+CWVAVHdEN=SWwyBjK+4Bx7cPhyg@mail.gmail.com> (raw)
In-Reply-To: <c91f438b-8baa-808c-35d6-fffb928d22f1@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
In the future, please just send the text inline instead of as an attachment.
I don't understand the setting hierarchy. To me,
/org/openbmc/settings/Host/host0 implies I am modifying something related
to the host CPU, not the BMC. TimeMode only applies to the BMC so having
it under host0 feels weird.
1. I like the clear separation of NTP vs manual.
2.1. "Both" seems like what we have today which doesn't really work at
all. I suggest omitting it. "Split" feels like it should work for all
cases. If TimeMode is NTP, an offset is recorded. If TimeMode is Manual,
the BMC time is set.
APIs:
1. What time zone does SetTime assume? If UTC, make sure to add tests for
a valid leap second and leap year.
2. I really dislike APIs that change behavior. Provide separate GetBmcTime
and GetHostTime APIs if you must.
3. SetNTP is a very limiting name. if this really changes TimeMode, call
it SetTimeMode. That way we can support things like 1588, GPS, etc later.
Changes to NetworkManager:
- I don't see the point of UseNTP for SetDHCP. Configuring an NTP address
is different from using NTP as a time source. It's up to the DHCP server
to provide NTP options. Whether the BMC uses them is controlled by
TimeMode.
- Add a SetNtpServer API instead of adding to SetAddress4. NTP is entirely
separate from IPv4 address configuration.
On Thu, Aug 18, 2016 at 4:08 AM, vishwa <vishwa@linux.vnet.ibm.com> wrote:
> Team,
>
> Please help look into this document that describes what I think the
> TimeManager on openBMC systems should look like.
>
> Please weigh in your thoughts.
>
> Thanks.
>
> Vishwanath.
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
>
>
[-- Attachment #2: Type: text/html, Size: 2472 bytes --]
next prev parent reply other threads:[~2016-08-22 23:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 11:08 Document on : Time Manager in OpenBMC --> Need your review vishwa
2016-08-22 23:44 ` Rick Altherr [this message]
2016-08-25 11:59 ` vishwa
2016-08-25 17:19 ` Rick Altherr
2016-09-06 9:01 ` vishwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPLgG=koY4pB-kc=2eVCg5+CWVAVHdEN=SWwyBjK+4Bx7cPhyg@mail.gmail.com' \
--to=raltherr@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=vishwa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.