From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbdJEDYO (ORCPT ); Wed, 4 Oct 2017 23:24:14 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:44427 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdJEDYM (ORCPT ); Wed, 4 Oct 2017 23:24:12 -0400 X-Google-Smtp-Source: AOwi7QAD2kugiDriaxclRZdVRiui9oG6pG0vXFzyt293LOfiHAgKvA6NzrJ6zpajPQc6HPULGii9A4pM/wd3tCCmmWc= MIME-Version: 1.0 In-Reply-To: References: <20170705222406.28124-1-keithp@keithp.com> <20170705222406.28124-7-keithp@keithp.com> From: Dave Airlie Date: Thu, 5 Oct 2017 13:24:10 +1000 Message-ID: Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3] To: Keith Packard Cc: LKML , Dave Airlie , Daniel Vetter , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 October 2017 at 13:17, Dave Airlie wrote: >> --- >> drivers/gpu/drm/drm_ioctl.c | 4 + >> drivers/gpu/drm/drm_lease.c | 270 ++++++++++++++++++++++++++++++++++++++++++++ >> include/drm/drm_lease.h | 12 ++ >> include/uapi/drm/drm.h | 5 + >> include/uapi/drm/drm_mode.h | 64 +++++++++++ >> 5 files changed, 355 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c >> index a5a259964c7d..0a43e82d3f06 100644 >> --- a/drivers/gpu/drm/drm_ioctl.c >> +++ b/drivers/gpu/drm/drm_ioctl.c >> @@ -657,6 +657,10 @@ static const struct drm_ioctl_desc drm_ioctls[] = { >> DRM_UNLOCKED|DRM_RENDER_ALLOW), >> DRM_IOCTL_DEF(DRM_IOCTL_SYNCOBJ_FD_TO_HANDLE, drm_syncobj_fd_to_handle_ioctl, >> DRM_UNLOCKED|DRM_RENDER_ALLOW), >> + DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATE_LEASE, drm_mode_create_lease_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED), >> + DRM_IOCTL_DEF(DRM_IOCTL_MODE_LIST_LESSEES, drm_mode_list_lessees_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED), >> + DRM_IOCTL_DEF(DRM_IOCTL_MODE_GET_LEASE, drm_mode_get_lease_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED), >> + DRM_IOCTL_DEF(DRM_IOCTL_MODE_REVOKE_LEASE, drm_mode_revoke_lease_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED), >> }; >> >> #define DRM_CORE_IOCTL_COUNT ARRAY_SIZE( drm_ioctls ) >> diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c >> index a8bd4bdd2977..f233d8b488f2 100644 >> --- a/drivers/gpu/drm/drm_lease.c >> +++ b/drivers/gpu/drm/drm_lease.c >> @@ -23,6 +23,8 @@ >> #define drm_for_each_lessee(lessee, lessor) \ >> list_for_each_entry((lessee), &(lessor)->lessees, lessee_list) >> >> +static uint64_t drm_lease_idr_object; > > What is this for? ^^ > >> + ret = idr_alloc(&leases, &drm_lease_idr_object , object_id, object_id + 1, GFP_KERNEL); > > You can just pass NULL here. > Just read the comment, this smells a bit of black magic, I'll spend some time staring at it :-) Dave. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3] Date: Thu, 5 Oct 2017 13:24:10 +1000 Message-ID: References: <20170705222406.28124-1-keithp@keithp.com> <20170705222406.28124-7-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F21F6E551 for ; Thu, 5 Oct 2017 03:24:13 +0000 (UTC) Received: by mail-lf0-x242.google.com with SMTP id n140so13199528lfn.4 for ; Wed, 04 Oct 2017 20:24:13 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Keith Packard Cc: Dave Airlie , dri-devel , LKML List-Id: dri-devel@lists.freedesktop.org T24gNSBPY3RvYmVyIDIwMTcgYXQgMTM6MTcsIERhdmUgQWlybGllIDxhaXJsaWVkQGdtYWlsLmNv bT4gd3JvdGU6Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jIHwgICA0ICsK Pj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fbGVhc2UuYyB8IDI3MCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgaW5jbHVkZS9kcm0vZHJtX2xlYXNlLmggICAg IHwgIDEyICsrCj4+ICBpbmNsdWRlL3VhcGkvZHJtL2RybS5oICAgICAgfCAgIDUgKwo+PiAgaW5j bHVkZS91YXBpL2RybS9kcm1fbW9kZS5oIHwgIDY0ICsrKysrKysrKysrCj4+ICA1IGZpbGVzIGNo YW5nZWQsIDM1NSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2lvY3RsLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lvY3RsLmMKPj4gaW5kZXggYTVh MjU5OTY0YzdkLi4wYTQzZTgyZDNmMDYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1faW9jdGwuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lvY3RsLmMKPj4gQEAgLTY1 Nyw2ICs2NTcsMTAgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1faW9jdGxfZGVzYyBkcm1faW9j dGxzW10gPSB7Cj4+ICAgICAgICAgICAgICAgICAgICAgICBEUk1fVU5MT0NLRUR8RFJNX1JFTkRF Ul9BTExPVyksCj4+ICAgICAgICAgRFJNX0lPQ1RMX0RFRihEUk1fSU9DVExfU1lOQ09CSl9GRF9U T19IQU5ETEUsIGRybV9zeW5jb2JqX2ZkX3RvX2hhbmRsZV9pb2N0bCwKPj4gICAgICAgICAgICAg ICAgICAgICAgIERSTV9VTkxPQ0tFRHxEUk1fUkVOREVSX0FMTE9XKSwKPj4gKyAgICAgICBEUk1f SU9DVExfREVGKERSTV9JT0NUTF9NT0RFX0NSRUFURV9MRUFTRSwgZHJtX21vZGVfY3JlYXRlX2xl YXNlX2lvY3RsLCBEUk1fTUFTVEVSfERSTV9DT05UUk9MX0FMTE9XfERSTV9VTkxPQ0tFRCksCj4+ ICsgICAgICAgRFJNX0lPQ1RMX0RFRihEUk1fSU9DVExfTU9ERV9MSVNUX0xFU1NFRVMsIGRybV9t b2RlX2xpc3RfbGVzc2Vlc19pb2N0bCwgRFJNX01BU1RFUnxEUk1fQ09OVFJPTF9BTExPV3xEUk1f VU5MT0NLRUQpLAo+PiArICAgICAgIERSTV9JT0NUTF9ERUYoRFJNX0lPQ1RMX01PREVfR0VUX0xF QVNFLCBkcm1fbW9kZV9nZXRfbGVhc2VfaW9jdGwsIERSTV9NQVNURVJ8RFJNX0NPTlRST0xfQUxM T1d8RFJNX1VOTE9DS0VEKSwKPj4gKyAgICAgICBEUk1fSU9DVExfREVGKERSTV9JT0NUTF9NT0RF X1JFVk9LRV9MRUFTRSwgZHJtX21vZGVfcmV2b2tlX2xlYXNlX2lvY3RsLCBEUk1fTUFTVEVSfERS TV9DT05UUk9MX0FMTE9XfERSTV9VTkxPQ0tFRCksCj4+ICB9Owo+Pgo+PiAgI2RlZmluZSBEUk1f Q09SRV9JT0NUTF9DT1VOVCAgIEFSUkFZX1NJWkUoIGRybV9pb2N0bHMgKQo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9sZWFzZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9sZWFz ZS5jCj4+IGluZGV4IGE4YmQ0YmRkMjk3Ny4uZjIzM2Q4YjQ4OGYyIDEwMDY0NAo+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2xlYXNlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9s ZWFzZS5jCj4+IEBAIC0yMyw2ICsyMyw4IEBACj4+ICAjZGVmaW5lIGRybV9mb3JfZWFjaF9sZXNz ZWUobGVzc2VlLCBsZXNzb3IpIFwKPj4gICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KChsZXNz ZWUpLCAmKGxlc3NvciktPmxlc3NlZXMsIGxlc3NlZV9saXN0KQo+Pgo+PiArc3RhdGljIHVpbnQ2 NF90IGRybV9sZWFzZV9pZHJfb2JqZWN0Owo+Cj4gV2hhdCBpcyB0aGlzIGZvcj8gXl4KPgo+PiAr ICAgICAgICAgICAgICAgcmV0ID0gaWRyX2FsbG9jKCZsZWFzZXMsICZkcm1fbGVhc2VfaWRyX29i amVjdCAsIG9iamVjdF9pZCwgb2JqZWN0X2lkICsgMSwgR0ZQX0tFUk5FTCk7Cj4KPiBZb3UgY2Fu IGp1c3QgcGFzcyBOVUxMIGhlcmUuCj4KCkp1c3QgcmVhZCB0aGUgY29tbWVudCwgdGhpcyBzbWVs bHMgYSBiaXQgb2YgYmxhY2sgbWFnaWMsIEknbGwgc3BlbmQKc29tZSB0aW1lIHN0YXJpbmcgYXQg aXQgOi0pCgpEYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK