From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32ACC43215 for ; Tue, 19 Nov 2019 20:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AE6222448 for ; Tue, 19 Nov 2019 20:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZL6BOPq0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727343AbfKSUGk (ORCPT ); Tue, 19 Nov 2019 15:06:40 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42960 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbfKSUGk (ORCPT ); Tue, 19 Nov 2019 15:06:40 -0500 Received: by mail-lj1-f193.google.com with SMTP id n5so24805930ljc.9; Tue, 19 Nov 2019 12:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8ozTKJ2rIRG9nHA+tMxCQpcyR7fs60WJFT2iDBkxCrc=; b=ZL6BOPq0/1KVhaECgSsxziPcOkvFxCuctCJ9rq8sLs/yLOhBxMcaQvuoy+IDEqD27D sSHx/DHVjZznHM0IAyxS8uZp0SmGoJlXJIubk/aTtK+nyJqN7qbGU9k0yZq6F3axHLoR I7LCwhSLHWb05G9GLhB0j4DA2AcS6BAHEAZKnw/mM3h+jex3SyIg1hAeyEdfHqBjAxar 8MdCnxa2QwtuDrx/3aLqSbJS6DBN5x3o3B8q+CPFKESr0wngpwxLhX5aiF7fSavMZ2EG ChetJ0Big0TYLMLJajdWXtmZn4EmS5XFmk662U4arRsb0GUpQPR05c1BUF4hG8afVPRH vaQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8ozTKJ2rIRG9nHA+tMxCQpcyR7fs60WJFT2iDBkxCrc=; b=iahwsUXeXURpLOVn2klqpZBkrRnGCppYvqYYZu/wiGsK0+N5auR3aV42GLTo+a7owk on+mfnkimBpTCeRTcMCjhusPGfg0MHSskJnHfO7vki4O3ny+l0xwEAGIK3pzmBoO9sHJ bqy6eW1RF3KU9euAhG5t/84gTxg1H1U0lvNXs7BFzIbd0uSGqdA0eg6sA+Iu+NCF9zy/ YN53ak+YFm+cD9UhY7xhwiGuxeFJRu0sh9u8p39/lL+8dcfUYhnIMwqoYCEFysNnGCtv KFK/wJw8pQDuKCHObPwUw8pPCfQuFBKCjRZ58lLudOIG0eNpFXlx2p05saDKJRFsFUVN 4xzg== X-Gm-Message-State: APjAAAVHGnkULXl3ngTRv+RFsFWRYcmc2BJvC2xBvregSvHhbkTtu0mk nSAB629dr5We7DnCGHxvSlLrilA0WD7PZl9icyQ= X-Google-Smtp-Source: APXvYqxCtBrAFAKyz1SDQAYnzSvQxMY0cyWFJoF6LQeB2TSVVGaggbw8jwL0kptUtrgQCGDaLvHaKnfBd6oNfvmJjBU= X-Received: by 2002:a2e:7c12:: with SMTP id x18mr5487839ljc.130.1574193996900; Tue, 19 Nov 2019 12:06:36 -0800 (PST) MIME-Version: 1.0 References: <20191017121901.13699-1-kherbst@redhat.com> In-Reply-To: <20191017121901.13699-1-kherbst@redhat.com> From: Dave Airlie Date: Wed, 20 Nov 2019 06:06:25 +1000 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Karol Herbst Cc: LKML , Linux PM list , Linux PCI , Mika Westerberg , "Rafael J . Wysocki" , dri-devel , nouveau , Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Oct 2019 at 22:19, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > states. Can we get this acked/committed? At this stage I think we've done all we can unless Intel actually escalate this internally and work out how the hw is broken. Dave. > > v2: convert to pci_dev quirk > put a proper technical explanation of the issue as a in-code comment > v3: disable it only for certain combinations of intel and nvidia hardware > v4: simplify quirk by setting flag on the GPU itself > > Signed-off-by: Karol Herbst > Cc: Bjorn Helgaas > Cc: Lyude Paul > Cc: Rafael J. Wysocki > Cc: Mika Westerberg > Cc: linux-pci@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > --- > drivers/pci/pci.c | 7 ++++++ > drivers/pci/quirks.c | 53 ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/pci.h | 1 + > 3 files changed, 61 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index b97d9e10c9cc..02e71e0bcdd7 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -850,6 +850,13 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) > || (state == PCI_D2 && !dev->d2_support)) > return -EIO; > > + /* > + * check if we have a bad combination of bridge controller and nvidia > + * GPU, see quirk_broken_nv_runpm for more info > + */ > + if (state != PCI_D0 && dev->broken_nv_runpm) > + return 0; > + > pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); > > /* > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44c4ae1abd00..0006c9e37b6f 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5268,3 +5268,56 @@ static void quirk_reset_lenovo_thinkpad_p50_nvgpu(struct pci_dev *pdev) > DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, 0x13b1, > PCI_CLASS_DISPLAY_VGA, 8, > quirk_reset_lenovo_thinkpad_p50_nvgpu); > + > +/* > + * Some Intel PCIe bridges cause devices to disappear from the PCIe bus after > + * those were put into D3cold state if they were put into a non D0 PCI PM > + * device state before doing so. > + * > + * This leads to various issue different issues which all manifest differently, > + * but have the same root cause: > + * - AIML code execution hits an infinite loop (as the coe waits on device > + * memory to change). > + * - kernel crashes, as all pci reads return -1, which most code isn't able > + * to handle well enough. > + * - sudden shutdowns, as the kernel identified an unrecoverable error after > + * userspace tries to access the GPU. > + * > + * In all cases dmesg will contain at least one line like this: > + * 'nouveau 0000:01:00.0: Refused to change power state, currently in D3' > + * followed by a lot of nouveau timeouts. > + * > + * ACPI code writes bit 0x80 to the not documented PCI register 0x248 of the > + * PCIe bridge controller in order to power down the GPU. > + * Nonetheless, there are other code paths inside the ACPI firmware which use > + * other registers, which seem to work fine: > + * - 0xbc bit 0x20 (publicly available documentation claims 'reserved') > + * - 0xb0 bit 0x10 (link disable) > + * Changing the conditions inside the firmware by poking into the relevant > + * addresses does resolve the issue, but it seemed to be ACPI private memory > + * and not any device accessible memory at all, so there is no portable way of > + * changing the conditions. > + * > + * The only systems where this behavior can be seen are hybrid graphics laptops > + * with a secondary Nvidia Pascal GPU. It cannot be ruled out that this issue > + * only occurs in combination with listed Intel PCIe bridge controllers and > + * the mentioned GPUs or if it's only a hw bug in the bridge controller. > + * > + * But because this issue was NOT seen on laptops with an Nvidia Pascal GPU > + * and an Intel Coffee Lake SoC, there is a higher chance of there being a bug > + * in the bridge controller rather than in the GPU. > + * > + * This issue was not able to be reproduced on non laptop systems. > + */ > + > +static void quirk_broken_nv_runpm(struct pci_dev *dev) > +{ > + struct pci_dev *bridge = pci_upstream_bridge(dev); > + > + if (bridge->vendor == PCI_VENDOR_ID_INTEL && > + bridge->device == 0x1901) > + dev->broken_nv_runpm = 1; > +} > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > + PCI_BASE_CLASS_DISPLAY, 16, > + quirk_broken_nv_runpm); > diff --git a/include/linux/pci.h b/include/linux/pci.h > index ac8a6c4e1792..903a0b3a39ec 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -416,6 +416,7 @@ struct pci_dev { > unsigned int __aer_firmware_first_valid:1; > unsigned int __aer_firmware_first:1; > unsigned int broken_intx_masking:1; /* INTx masking can't be used */ > + unsigned int broken_nv_runpm:1; /* some combinations of intel bridge controller and nvidia GPUs break rtd3 */ > unsigned int io_window_1k:1; /* Intel bridge 1K I/O windows */ > unsigned int irq_managed:1; > unsigned int has_secondary_link:1; > -- > 2.21.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Wed, 20 Nov 2019 06:06:25 +1000 Message-ID: References: <20191017121901.13699-1-kherbst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191017121901.13699-1-kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Karol Herbst Cc: Linux PM list , Linux PCI , Mika Westerberg , "Rafael J . Wysocki" , LKML , dri-devel , nouveau , Bjorn Helgaas List-Id: nouveau.vger.kernel.org T24gVGh1LCAxNyBPY3QgMjAxOSBhdCAyMjoxOSwgS2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhh dC5jb20+IHdyb3RlOgo+Cj4gRml4ZXMgc3RhdGUgdHJhbnNpdGlvbnMgb2YgTnZpZGlhIFBhc2Nh bCBHUFVzIGZyb20gRDNjb2xkIGludG8gaGlnaGVyIGRldmljZQo+IHN0YXRlcy4KCgpDYW4gd2Ug Z2V0IHRoaXMgYWNrZWQvY29tbWl0dGVkPyBBdCB0aGlzIHN0YWdlIEkgdGhpbmsgd2UndmUgZG9u ZSBhbGwKd2UgY2FuIHVubGVzcyBJbnRlbCBhY3R1YWxseSBlc2NhbGF0ZSB0aGlzIGludGVybmFs bHkgYW5kIHdvcmsgb3V0IGhvdwp0aGUgaHcgaXMgYnJva2VuLgoKRGF2ZS4KPgo+IHYyOiBjb252 ZXJ0IHRvIHBjaV9kZXYgcXVpcmsKPiAgICAgcHV0IGEgcHJvcGVyIHRlY2huaWNhbCBleHBsYW5h dGlvbiBvZiB0aGUgaXNzdWUgYXMgYSBpbi1jb2RlIGNvbW1lbnQKPiB2MzogZGlzYWJsZSBpdCBv bmx5IGZvciBjZXJ0YWluIGNvbWJpbmF0aW9ucyBvZiBpbnRlbCBhbmQgbnZpZGlhIGhhcmR3YXJl Cj4gdjQ6IHNpbXBsaWZ5IHF1aXJrIGJ5IHNldHRpbmcgZmxhZyBvbiB0aGUgR1BVIGl0c2VsZgo+ Cj4gU2lnbmVkLW9mZi1ieTogS2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhhdC5jb20+Cj4gQ2M6 IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+Cj4gQ2M6IEx5dWRlIFBhdWwgPGx5 dWRlQHJlZGhhdC5jb20+Cj4gQ2M6IFJhZmFlbCBKLiBXeXNvY2tpIDxyandAcmp3eXNvY2tpLm5l dD4KPiBDYzogTWlrYSBXZXN0ZXJiZXJnIDxtaWthLndlc3RlcmJlcmdAaW50ZWwuY29tPgo+IENj OiBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LXBtQHZnZXIua2VybmVsLm9y Zwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IG5vdXZlYXVAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gLS0tCj4gIGRyaXZlcnMvcGNpL3BjaS5jICAgIHwgIDcgKysr KysrCj4gIGRyaXZlcnMvcGNpL3F1aXJrcy5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9wY2kuaCAgfCAgMSArCj4gIDMg ZmlsZXMgY2hhbmdlZCwgNjEgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaS5jIGIvZHJpdmVycy9wY2kvcGNpLmMKPiBpbmRleCBiOTdkOWUxMGM5Y2MuLjAyZTcx ZTBiY2RkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2kuYwo+ICsrKyBiL2RyaXZlcnMv cGNpL3BjaS5jCj4gQEAgLTg1MCw2ICs4NTAsMTMgQEAgc3RhdGljIGludCBwY2lfcmF3X3NldF9w b3dlcl9zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqZGV2LCBwY2lfcG93ZXJfdCBzdGF0ZSkKPiAgICAg ICAgICAgIHx8IChzdGF0ZSA9PSBQQ0lfRDIgJiYgIWRldi0+ZDJfc3VwcG9ydCkpCj4gICAgICAg ICAgICAgICAgIHJldHVybiAtRUlPOwo+Cj4gKyAgICAgICAvKgo+ICsgICAgICAgICogY2hlY2sg aWYgd2UgaGF2ZSBhIGJhZCBjb21iaW5hdGlvbiBvZiBicmlkZ2UgY29udHJvbGxlciBhbmQgbnZp ZGlhCj4gKyAgICAgICAgICogR1BVLCBzZWUgcXVpcmtfYnJva2VuX252X3J1bnBtIGZvciBtb3Jl IGluZm8KPiArICAgICAgICAqLwo+ICsgICAgICAgaWYgKHN0YXRlICE9IFBDSV9EMCAmJiBkZXYt PmJyb2tlbl9udl9ydW5wbSkKPiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gKwo+ICAgICAg ICAgcGNpX3JlYWRfY29uZmlnX3dvcmQoZGV2LCBkZXYtPnBtX2NhcCArIFBDSV9QTV9DVFJMLCAm cG1jc3IpOwo+Cj4gICAgICAgICAvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9xdWlya3Mu YyBiL2RyaXZlcnMvcGNpL3F1aXJrcy5jCj4gaW5kZXggNDRjNGFlMWFiZDAwLi4wMDA2YzllMzdi NmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvcXVpcmtzLmMKPiArKysgYi9kcml2ZXJzL3Bj aS9xdWlya3MuYwo+IEBAIC01MjY4LDMgKzUyNjgsNTYgQEAgc3RhdGljIHZvaWQgcXVpcmtfcmVz ZXRfbGVub3ZvX3RoaW5rcGFkX3A1MF9udmdwdShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPiAgREVD TEFSRV9QQ0lfRklYVVBfQ0xBU1NfRklOQUwoUENJX1ZFTkRPUl9JRF9OVklESUEsIDB4MTNiMSwK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfQ0xBU1NfRElTUExBWV9WR0EsIDgs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcXVpcmtfcmVzZXRfbGVub3ZvX3RoaW5r cGFkX3A1MF9udmdwdSk7Cj4gKwo+ICsvKgo+ICsgKiBTb21lIEludGVsIFBDSWUgYnJpZGdlcyBj YXVzZSBkZXZpY2VzIHRvIGRpc2FwcGVhciBmcm9tIHRoZSBQQ0llIGJ1cyBhZnRlcgo+ICsgKiB0 aG9zZSB3ZXJlIHB1dCBpbnRvIEQzY29sZCBzdGF0ZSBpZiB0aGV5IHdlcmUgcHV0IGludG8gYSBu b24gRDAgUENJIFBNCj4gKyAqIGRldmljZSBzdGF0ZSBiZWZvcmUgZG9pbmcgc28uCj4gKyAqCj4g KyAqIFRoaXMgbGVhZHMgdG8gdmFyaW91cyBpc3N1ZSBkaWZmZXJlbnQgaXNzdWVzIHdoaWNoIGFs bCBtYW5pZmVzdCBkaWZmZXJlbnRseSwKPiArICogYnV0IGhhdmUgdGhlIHNhbWUgcm9vdCBjYXVz ZToKPiArICogIC0gQUlNTCBjb2RlIGV4ZWN1dGlvbiBoaXRzIGFuIGluZmluaXRlIGxvb3AgKGFz IHRoZSBjb2Ugd2FpdHMgb24gZGV2aWNlCj4gKyAqICAgIG1lbW9yeSB0byBjaGFuZ2UpLgo+ICsg KiAgLSBrZXJuZWwgY3Jhc2hlcywgYXMgYWxsIHBjaSByZWFkcyByZXR1cm4gLTEsIHdoaWNoIG1v c3QgY29kZSBpc24ndCBhYmxlCj4gKyAqICAgIHRvIGhhbmRsZSB3ZWxsIGVub3VnaC4KPiArICog IC0gc3VkZGVuIHNodXRkb3ducywgYXMgdGhlIGtlcm5lbCBpZGVudGlmaWVkIGFuIHVucmVjb3Zl cmFibGUgZXJyb3IgYWZ0ZXIKPiArICogICAgdXNlcnNwYWNlIHRyaWVzIHRvIGFjY2VzcyB0aGUg R1BVLgo+ICsgKgo+ICsgKiBJbiBhbGwgY2FzZXMgZG1lc2cgd2lsbCBjb250YWluIGF0IGxlYXN0 IG9uZSBsaW5lIGxpa2UgdGhpczoKPiArICogJ25vdXZlYXUgMDAwMDowMTowMC4wOiBSZWZ1c2Vk IHRvIGNoYW5nZSBwb3dlciBzdGF0ZSwgY3VycmVudGx5IGluIEQzJwo+ICsgKiBmb2xsb3dlZCBi eSBhIGxvdCBvZiBub3V2ZWF1IHRpbWVvdXRzLgo+ICsgKgo+ICsgKiBBQ1BJIGNvZGUgd3JpdGVz IGJpdCAweDgwIHRvIHRoZSBub3QgZG9jdW1lbnRlZCBQQ0kgcmVnaXN0ZXIgMHgyNDggb2YgdGhl Cj4gKyAqIFBDSWUgYnJpZGdlIGNvbnRyb2xsZXIgaW4gb3JkZXIgdG8gcG93ZXIgZG93biB0aGUg R1BVLgo+ICsgKiBOb25ldGhlbGVzcywgdGhlcmUgYXJlIG90aGVyIGNvZGUgcGF0aHMgaW5zaWRl IHRoZSBBQ1BJIGZpcm13YXJlIHdoaWNoIHVzZQo+ICsgKiBvdGhlciByZWdpc3RlcnMsIHdoaWNo IHNlZW0gdG8gd29yayBmaW5lOgo+ICsgKiAgLSAweGJjIGJpdCAweDIwIChwdWJsaWNseSBhdmFp bGFibGUgZG9jdW1lbnRhdGlvbiBjbGFpbXMgJ3Jlc2VydmVkJykKPiArICogIC0gMHhiMCBiaXQg MHgxMCAobGluayBkaXNhYmxlKQo+ICsgKiBDaGFuZ2luZyB0aGUgY29uZGl0aW9ucyBpbnNpZGUg dGhlIGZpcm13YXJlIGJ5IHBva2luZyBpbnRvIHRoZSByZWxldmFudAo+ICsgKiBhZGRyZXNzZXMg ZG9lcyByZXNvbHZlIHRoZSBpc3N1ZSwgYnV0IGl0IHNlZW1lZCB0byBiZSBBQ1BJIHByaXZhdGUg bWVtb3J5Cj4gKyAqIGFuZCBub3QgYW55IGRldmljZSBhY2Nlc3NpYmxlIG1lbW9yeSBhdCBhbGws IHNvIHRoZXJlIGlzIG5vIHBvcnRhYmxlIHdheSBvZgo+ICsgKiBjaGFuZ2luZyB0aGUgY29uZGl0 aW9ucy4KPiArICoKPiArICogVGhlIG9ubHkgc3lzdGVtcyB3aGVyZSB0aGlzIGJlaGF2aW9yIGNh biBiZSBzZWVuIGFyZSBoeWJyaWQgZ3JhcGhpY3MgbGFwdG9wcwo+ICsgKiB3aXRoIGEgc2Vjb25k YXJ5IE52aWRpYSBQYXNjYWwgR1BVLiBJdCBjYW5ub3QgYmUgcnVsZWQgb3V0IHRoYXQgdGhpcyBp c3N1ZQo+ICsgKiBvbmx5IG9jY3VycyBpbiBjb21iaW5hdGlvbiB3aXRoIGxpc3RlZCBJbnRlbCBQ Q0llIGJyaWRnZSBjb250cm9sbGVycyBhbmQKPiArICogdGhlIG1lbnRpb25lZCBHUFVzIG9yIGlm IGl0J3Mgb25seSBhIGh3IGJ1ZyBpbiB0aGUgYnJpZGdlIGNvbnRyb2xsZXIuCj4gKyAqCj4gKyAq IEJ1dCBiZWNhdXNlIHRoaXMgaXNzdWUgd2FzIE5PVCBzZWVuIG9uIGxhcHRvcHMgd2l0aCBhbiBO dmlkaWEgUGFzY2FsIEdQVQo+ICsgKiBhbmQgYW4gSW50ZWwgQ29mZmVlIExha2UgU29DLCB0aGVy ZSBpcyBhIGhpZ2hlciBjaGFuY2Ugb2YgdGhlcmUgYmVpbmcgYSBidWcKPiArICogaW4gdGhlIGJy aWRnZSBjb250cm9sbGVyIHJhdGhlciB0aGFuIGluIHRoZSBHUFUuCj4gKyAqCj4gKyAqIFRoaXMg aXNzdWUgd2FzIG5vdCBhYmxlIHRvIGJlIHJlcHJvZHVjZWQgb24gbm9uIGxhcHRvcCBzeXN0ZW1z Lgo+ICsgKi8KPiArCj4gK3N0YXRpYyB2b2lkIHF1aXJrX2Jyb2tlbl9udl9ydW5wbShzdHJ1Y3Qg cGNpX2RldiAqZGV2KQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3QgcGNpX2RldiAqYnJpZGdlID0gcGNp X3Vwc3RyZWFtX2JyaWRnZShkZXYpOwo+ICsKPiArICAgICAgIGlmIChicmlkZ2UtPnZlbmRvciA9 PSBQQ0lfVkVORE9SX0lEX0lOVEVMICYmCj4gKyAgICAgICAgICAgYnJpZGdlLT5kZXZpY2UgPT0g MHgxOTAxKQo+ICsgICAgICAgICAgICAgICBkZXYtPmJyb2tlbl9udl9ydW5wbSA9IDE7Cj4gK30K PiArREVDTEFSRV9QQ0lfRklYVVBfQ0xBU1NfRklOQUwoUENJX1ZFTkRPUl9JRF9OVklESUEsIFBD SV9BTllfSUQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JBU0VfQ0xBU1Nf RElTUExBWSwgMTYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcXVpcmtfYnJva2Vu X252X3J1bnBtKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9wY2kuaCBiL2luY2x1ZGUv bGludXgvcGNpLmgKPiBpbmRleCBhYzhhNmM0ZTE3OTIuLjkwM2EwYjNhMzllYyAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9wY2kuaAo+IEBA IC00MTYsNiArNDE2LDcgQEAgc3RydWN0IHBjaV9kZXYgewo+ICAgICAgICAgdW5zaWduZWQgaW50 ICAgIF9fYWVyX2Zpcm13YXJlX2ZpcnN0X3ZhbGlkOjE7Cj4gICAgICAgICB1bnNpZ25lZCBpbnQg ICAgX19hZXJfZmlybXdhcmVfZmlyc3Q6MTsKPiAgICAgICAgIHVuc2lnbmVkIGludCAgICBicm9r ZW5faW50eF9tYXNraW5nOjE7ICAvKiBJTlR4IG1hc2tpbmcgY2FuJ3QgYmUgdXNlZCAqLwo+ICsg ICAgICAgdW5zaWduZWQgaW50ICAgIGJyb2tlbl9udl9ydW5wbToxOyAgICAgIC8qIHNvbWUgY29t YmluYXRpb25zIG9mIGludGVsIGJyaWRnZSBjb250cm9sbGVyIGFuZCBudmlkaWEgR1BVcyBicmVh ayBydGQzICovCj4gICAgICAgICB1bnNpZ25lZCBpbnQgICAgaW9fd2luZG93XzFrOjE7ICAgICAg ICAgLyogSW50ZWwgYnJpZGdlIDFLIEkvTyB3aW5kb3dzICovCj4gICAgICAgICB1bnNpZ25lZCBp bnQgICAgaXJxX21hbmFnZWQ6MTsKPiAgICAgICAgIHVuc2lnbmVkIGludCAgICBoYXNfc2Vjb25k YXJ5X2xpbms6MTsKPiAtLQo+IDIuMjEuMAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v bm91dmVhdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798EBC432C3 for ; Tue, 19 Nov 2019 20:06:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BA22245F for ; Tue, 19 Nov 2019 20:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53BA22245F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CA086E902; Tue, 19 Nov 2019 20:06:40 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA6E46E997; Tue, 19 Nov 2019 20:06:38 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id r7so24819613ljg.2; Tue, 19 Nov 2019 12:06:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8ozTKJ2rIRG9nHA+tMxCQpcyR7fs60WJFT2iDBkxCrc=; b=IxA6IG/qftB3LGUlfZFmD+K16UWCWGysjOUfdA+8d7BcWH5lVIokRRn9TbsjmgbNK2 g3MabZLAFjNF1x2r78ysQ9YMqcJdsGiLq2AukBP/u6HLY0CrqnB3MBOid2ik/yLsIHO5 1UIEbYl9w3VqbR8dbeYKJN87T3OtUTDXUalE38ieAYHN6afZvT8wwnh88jrkcUXH+i15 xlb5w1xpwoeFjA6gbqBIS/odOhMQIv9XQPkH1svaWCNRE+XdbhIep8fY2kJk61o3FpWG KeBF2S2OU9wnXpvK+BnsJFVPVw+bQSUstRueALLHfck2uOiZMofV6wrp1YQhlDDClRFU gNlQ== X-Gm-Message-State: APjAAAVMHc69XD7XFDmapcPbPlBm4RDosv+4otU9q1u0mkK1mtU/0cL4 XSLz2oJ8txgol3L5rmYIsI8uEAmAAyc+aCwhjlY= X-Google-Smtp-Source: APXvYqxCtBrAFAKyz1SDQAYnzSvQxMY0cyWFJoF6LQeB2TSVVGaggbw8jwL0kptUtrgQCGDaLvHaKnfBd6oNfvmJjBU= X-Received: by 2002:a2e:7c12:: with SMTP id x18mr5487839ljc.130.1574193996900; Tue, 19 Nov 2019 12:06:36 -0800 (PST) MIME-Version: 1.0 References: <20191017121901.13699-1-kherbst@redhat.com> In-Reply-To: <20191017121901.13699-1-kherbst@redhat.com> From: Dave Airlie Date: Wed, 20 Nov 2019 06:06:25 +1000 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Karol Herbst X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8ozTKJ2rIRG9nHA+tMxCQpcyR7fs60WJFT2iDBkxCrc=; b=ZL6BOPq0/1KVhaECgSsxziPcOkvFxCuctCJ9rq8sLs/yLOhBxMcaQvuoy+IDEqD27D sSHx/DHVjZznHM0IAyxS8uZp0SmGoJlXJIubk/aTtK+nyJqN7qbGU9k0yZq6F3axHLoR I7LCwhSLHWb05G9GLhB0j4DA2AcS6BAHEAZKnw/mM3h+jex3SyIg1hAeyEdfHqBjAxar 8MdCnxa2QwtuDrx/3aLqSbJS6DBN5x3o3B8q+CPFKESr0wngpwxLhX5aiF7fSavMZ2EG ChetJ0Big0TYLMLJajdWXtmZn4EmS5XFmk662U4arRsb0GUpQPR05c1BUF4hG8afVPRH vaQA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux PM list , Linux PCI , Mika Westerberg , "Rafael J . Wysocki" , LKML , dri-devel , nouveau , Bjorn Helgaas Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191119200625.npD6yVFgo6ridMejcoachYe9AxxfSMIH-HVUhsTWd04@z> T24gVGh1LCAxNyBPY3QgMjAxOSBhdCAyMjoxOSwgS2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhh dC5jb20+IHdyb3RlOgo+Cj4gRml4ZXMgc3RhdGUgdHJhbnNpdGlvbnMgb2YgTnZpZGlhIFBhc2Nh bCBHUFVzIGZyb20gRDNjb2xkIGludG8gaGlnaGVyIGRldmljZQo+IHN0YXRlcy4KCgpDYW4gd2Ug Z2V0IHRoaXMgYWNrZWQvY29tbWl0dGVkPyBBdCB0aGlzIHN0YWdlIEkgdGhpbmsgd2UndmUgZG9u ZSBhbGwKd2UgY2FuIHVubGVzcyBJbnRlbCBhY3R1YWxseSBlc2NhbGF0ZSB0aGlzIGludGVybmFs bHkgYW5kIHdvcmsgb3V0IGhvdwp0aGUgaHcgaXMgYnJva2VuLgoKRGF2ZS4KPgo+IHYyOiBjb252 ZXJ0IHRvIHBjaV9kZXYgcXVpcmsKPiAgICAgcHV0IGEgcHJvcGVyIHRlY2huaWNhbCBleHBsYW5h dGlvbiBvZiB0aGUgaXNzdWUgYXMgYSBpbi1jb2RlIGNvbW1lbnQKPiB2MzogZGlzYWJsZSBpdCBv bmx5IGZvciBjZXJ0YWluIGNvbWJpbmF0aW9ucyBvZiBpbnRlbCBhbmQgbnZpZGlhIGhhcmR3YXJl Cj4gdjQ6IHNpbXBsaWZ5IHF1aXJrIGJ5IHNldHRpbmcgZmxhZyBvbiB0aGUgR1BVIGl0c2VsZgo+ Cj4gU2lnbmVkLW9mZi1ieTogS2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhhdC5jb20+Cj4gQ2M6 IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+Cj4gQ2M6IEx5dWRlIFBhdWwgPGx5 dWRlQHJlZGhhdC5jb20+Cj4gQ2M6IFJhZmFlbCBKLiBXeXNvY2tpIDxyandAcmp3eXNvY2tpLm5l dD4KPiBDYzogTWlrYSBXZXN0ZXJiZXJnIDxtaWthLndlc3RlcmJlcmdAaW50ZWwuY29tPgo+IENj OiBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LXBtQHZnZXIua2VybmVsLm9y Zwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IG5vdXZlYXVAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gLS0tCj4gIGRyaXZlcnMvcGNpL3BjaS5jICAgIHwgIDcgKysr KysrCj4gIGRyaXZlcnMvcGNpL3F1aXJrcy5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9wY2kuaCAgfCAgMSArCj4gIDMg ZmlsZXMgY2hhbmdlZCwgNjEgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaS5jIGIvZHJpdmVycy9wY2kvcGNpLmMKPiBpbmRleCBiOTdkOWUxMGM5Y2MuLjAyZTcx ZTBiY2RkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2kuYwo+ICsrKyBiL2RyaXZlcnMv cGNpL3BjaS5jCj4gQEAgLTg1MCw2ICs4NTAsMTMgQEAgc3RhdGljIGludCBwY2lfcmF3X3NldF9w b3dlcl9zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqZGV2LCBwY2lfcG93ZXJfdCBzdGF0ZSkKPiAgICAg ICAgICAgIHx8IChzdGF0ZSA9PSBQQ0lfRDIgJiYgIWRldi0+ZDJfc3VwcG9ydCkpCj4gICAgICAg ICAgICAgICAgIHJldHVybiAtRUlPOwo+Cj4gKyAgICAgICAvKgo+ICsgICAgICAgICogY2hlY2sg aWYgd2UgaGF2ZSBhIGJhZCBjb21iaW5hdGlvbiBvZiBicmlkZ2UgY29udHJvbGxlciBhbmQgbnZp ZGlhCj4gKyAgICAgICAgICogR1BVLCBzZWUgcXVpcmtfYnJva2VuX252X3J1bnBtIGZvciBtb3Jl IGluZm8KPiArICAgICAgICAqLwo+ICsgICAgICAgaWYgKHN0YXRlICE9IFBDSV9EMCAmJiBkZXYt PmJyb2tlbl9udl9ydW5wbSkKPiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gKwo+ICAgICAg ICAgcGNpX3JlYWRfY29uZmlnX3dvcmQoZGV2LCBkZXYtPnBtX2NhcCArIFBDSV9QTV9DVFJMLCAm cG1jc3IpOwo+Cj4gICAgICAgICAvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9xdWlya3Mu YyBiL2RyaXZlcnMvcGNpL3F1aXJrcy5jCj4gaW5kZXggNDRjNGFlMWFiZDAwLi4wMDA2YzllMzdi NmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvcXVpcmtzLmMKPiArKysgYi9kcml2ZXJzL3Bj aS9xdWlya3MuYwo+IEBAIC01MjY4LDMgKzUyNjgsNTYgQEAgc3RhdGljIHZvaWQgcXVpcmtfcmVz ZXRfbGVub3ZvX3RoaW5rcGFkX3A1MF9udmdwdShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPiAgREVD TEFSRV9QQ0lfRklYVVBfQ0xBU1NfRklOQUwoUENJX1ZFTkRPUl9JRF9OVklESUEsIDB4MTNiMSwK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfQ0xBU1NfRElTUExBWV9WR0EsIDgs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcXVpcmtfcmVzZXRfbGVub3ZvX3RoaW5r cGFkX3A1MF9udmdwdSk7Cj4gKwo+ICsvKgo+ICsgKiBTb21lIEludGVsIFBDSWUgYnJpZGdlcyBj YXVzZSBkZXZpY2VzIHRvIGRpc2FwcGVhciBmcm9tIHRoZSBQQ0llIGJ1cyBhZnRlcgo+ICsgKiB0 aG9zZSB3ZXJlIHB1dCBpbnRvIEQzY29sZCBzdGF0ZSBpZiB0aGV5IHdlcmUgcHV0IGludG8gYSBu b24gRDAgUENJIFBNCj4gKyAqIGRldmljZSBzdGF0ZSBiZWZvcmUgZG9pbmcgc28uCj4gKyAqCj4g KyAqIFRoaXMgbGVhZHMgdG8gdmFyaW91cyBpc3N1ZSBkaWZmZXJlbnQgaXNzdWVzIHdoaWNoIGFs bCBtYW5pZmVzdCBkaWZmZXJlbnRseSwKPiArICogYnV0IGhhdmUgdGhlIHNhbWUgcm9vdCBjYXVz ZToKPiArICogIC0gQUlNTCBjb2RlIGV4ZWN1dGlvbiBoaXRzIGFuIGluZmluaXRlIGxvb3AgKGFz IHRoZSBjb2Ugd2FpdHMgb24gZGV2aWNlCj4gKyAqICAgIG1lbW9yeSB0byBjaGFuZ2UpLgo+ICsg KiAgLSBrZXJuZWwgY3Jhc2hlcywgYXMgYWxsIHBjaSByZWFkcyByZXR1cm4gLTEsIHdoaWNoIG1v c3QgY29kZSBpc24ndCBhYmxlCj4gKyAqICAgIHRvIGhhbmRsZSB3ZWxsIGVub3VnaC4KPiArICog IC0gc3VkZGVuIHNodXRkb3ducywgYXMgdGhlIGtlcm5lbCBpZGVudGlmaWVkIGFuIHVucmVjb3Zl cmFibGUgZXJyb3IgYWZ0ZXIKPiArICogICAgdXNlcnNwYWNlIHRyaWVzIHRvIGFjY2VzcyB0aGUg R1BVLgo+ICsgKgo+ICsgKiBJbiBhbGwgY2FzZXMgZG1lc2cgd2lsbCBjb250YWluIGF0IGxlYXN0 IG9uZSBsaW5lIGxpa2UgdGhpczoKPiArICogJ25vdXZlYXUgMDAwMDowMTowMC4wOiBSZWZ1c2Vk IHRvIGNoYW5nZSBwb3dlciBzdGF0ZSwgY3VycmVudGx5IGluIEQzJwo+ICsgKiBmb2xsb3dlZCBi eSBhIGxvdCBvZiBub3V2ZWF1IHRpbWVvdXRzLgo+ICsgKgo+ICsgKiBBQ1BJIGNvZGUgd3JpdGVz IGJpdCAweDgwIHRvIHRoZSBub3QgZG9jdW1lbnRlZCBQQ0kgcmVnaXN0ZXIgMHgyNDggb2YgdGhl Cj4gKyAqIFBDSWUgYnJpZGdlIGNvbnRyb2xsZXIgaW4gb3JkZXIgdG8gcG93ZXIgZG93biB0aGUg R1BVLgo+ICsgKiBOb25ldGhlbGVzcywgdGhlcmUgYXJlIG90aGVyIGNvZGUgcGF0aHMgaW5zaWRl IHRoZSBBQ1BJIGZpcm13YXJlIHdoaWNoIHVzZQo+ICsgKiBvdGhlciByZWdpc3RlcnMsIHdoaWNo IHNlZW0gdG8gd29yayBmaW5lOgo+ICsgKiAgLSAweGJjIGJpdCAweDIwIChwdWJsaWNseSBhdmFp bGFibGUgZG9jdW1lbnRhdGlvbiBjbGFpbXMgJ3Jlc2VydmVkJykKPiArICogIC0gMHhiMCBiaXQg MHgxMCAobGluayBkaXNhYmxlKQo+ICsgKiBDaGFuZ2luZyB0aGUgY29uZGl0aW9ucyBpbnNpZGUg dGhlIGZpcm13YXJlIGJ5IHBva2luZyBpbnRvIHRoZSByZWxldmFudAo+ICsgKiBhZGRyZXNzZXMg ZG9lcyByZXNvbHZlIHRoZSBpc3N1ZSwgYnV0IGl0IHNlZW1lZCB0byBiZSBBQ1BJIHByaXZhdGUg bWVtb3J5Cj4gKyAqIGFuZCBub3QgYW55IGRldmljZSBhY2Nlc3NpYmxlIG1lbW9yeSBhdCBhbGws IHNvIHRoZXJlIGlzIG5vIHBvcnRhYmxlIHdheSBvZgo+ICsgKiBjaGFuZ2luZyB0aGUgY29uZGl0 aW9ucy4KPiArICoKPiArICogVGhlIG9ubHkgc3lzdGVtcyB3aGVyZSB0aGlzIGJlaGF2aW9yIGNh biBiZSBzZWVuIGFyZSBoeWJyaWQgZ3JhcGhpY3MgbGFwdG9wcwo+ICsgKiB3aXRoIGEgc2Vjb25k YXJ5IE52aWRpYSBQYXNjYWwgR1BVLiBJdCBjYW5ub3QgYmUgcnVsZWQgb3V0IHRoYXQgdGhpcyBp c3N1ZQo+ICsgKiBvbmx5IG9jY3VycyBpbiBjb21iaW5hdGlvbiB3aXRoIGxpc3RlZCBJbnRlbCBQ Q0llIGJyaWRnZSBjb250cm9sbGVycyBhbmQKPiArICogdGhlIG1lbnRpb25lZCBHUFVzIG9yIGlm IGl0J3Mgb25seSBhIGh3IGJ1ZyBpbiB0aGUgYnJpZGdlIGNvbnRyb2xsZXIuCj4gKyAqCj4gKyAq IEJ1dCBiZWNhdXNlIHRoaXMgaXNzdWUgd2FzIE5PVCBzZWVuIG9uIGxhcHRvcHMgd2l0aCBhbiBO dmlkaWEgUGFzY2FsIEdQVQo+ICsgKiBhbmQgYW4gSW50ZWwgQ29mZmVlIExha2UgU29DLCB0aGVy ZSBpcyBhIGhpZ2hlciBjaGFuY2Ugb2YgdGhlcmUgYmVpbmcgYSBidWcKPiArICogaW4gdGhlIGJy aWRnZSBjb250cm9sbGVyIHJhdGhlciB0aGFuIGluIHRoZSBHUFUuCj4gKyAqCj4gKyAqIFRoaXMg aXNzdWUgd2FzIG5vdCBhYmxlIHRvIGJlIHJlcHJvZHVjZWQgb24gbm9uIGxhcHRvcCBzeXN0ZW1z Lgo+ICsgKi8KPiArCj4gK3N0YXRpYyB2b2lkIHF1aXJrX2Jyb2tlbl9udl9ydW5wbShzdHJ1Y3Qg cGNpX2RldiAqZGV2KQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3QgcGNpX2RldiAqYnJpZGdlID0gcGNp X3Vwc3RyZWFtX2JyaWRnZShkZXYpOwo+ICsKPiArICAgICAgIGlmIChicmlkZ2UtPnZlbmRvciA9 PSBQQ0lfVkVORE9SX0lEX0lOVEVMICYmCj4gKyAgICAgICAgICAgYnJpZGdlLT5kZXZpY2UgPT0g MHgxOTAxKQo+ICsgICAgICAgICAgICAgICBkZXYtPmJyb2tlbl9udl9ydW5wbSA9IDE7Cj4gK30K PiArREVDTEFSRV9QQ0lfRklYVVBfQ0xBU1NfRklOQUwoUENJX1ZFTkRPUl9JRF9OVklESUEsIFBD SV9BTllfSUQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUENJX0JBU0VfQ0xBU1Nf RElTUExBWSwgMTYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcXVpcmtfYnJva2Vu X252X3J1bnBtKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9wY2kuaCBiL2luY2x1ZGUv bGludXgvcGNpLmgKPiBpbmRleCBhYzhhNmM0ZTE3OTIuLjkwM2EwYjNhMzllYyAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9wY2kuaAo+IEBA IC00MTYsNiArNDE2LDcgQEAgc3RydWN0IHBjaV9kZXYgewo+ICAgICAgICAgdW5zaWduZWQgaW50 ICAgIF9fYWVyX2Zpcm13YXJlX2ZpcnN0X3ZhbGlkOjE7Cj4gICAgICAgICB1bnNpZ25lZCBpbnQg ICAgX19hZXJfZmlybXdhcmVfZmlyc3Q6MTsKPiAgICAgICAgIHVuc2lnbmVkIGludCAgICBicm9r ZW5faW50eF9tYXNraW5nOjE7ICAvKiBJTlR4IG1hc2tpbmcgY2FuJ3QgYmUgdXNlZCAqLwo+ICsg ICAgICAgdW5zaWduZWQgaW50ICAgIGJyb2tlbl9udl9ydW5wbToxOyAgICAgIC8qIHNvbWUgY29t YmluYXRpb25zIG9mIGludGVsIGJyaWRnZSBjb250cm9sbGVyIGFuZCBudmlkaWEgR1BVcyBicmVh ayBydGQzICovCj4gICAgICAgICB1bnNpZ25lZCBpbnQgICAgaW9fd2luZG93XzFrOjE7ICAgICAg ICAgLyogSW50ZWwgYnJpZGdlIDFLIEkvTyB3aW5kb3dzICovCj4gICAgICAgICB1bnNpZ25lZCBp bnQgICAgaXJxX21hbmFnZWQ6MTsKPiAgICAgICAgIHVuc2lnbmVkIGludCAgICBoYXNfc2Vjb25k YXJ5X2xpbms6MTsKPiAtLQo+IDIuMjEuMAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbA==