From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE42C433FE for ; Thu, 10 Dec 2020 01:32:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B85023BC6 for ; Thu, 10 Dec 2020 01:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B85023BC6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5721E6E218; Thu, 10 Dec 2020 01:32:33 +0000 (UTC) Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E48B6E218 for ; Thu, 10 Dec 2020 01:32:32 +0000 (UTC) Received: by mail-ej1-x641.google.com with SMTP id f23so5023457ejk.2 for ; Wed, 09 Dec 2020 17:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pEGWrSqUP6BZujFmQ+Fz15950Yp6fS/iTg2m5txnlM4=; b=C/LcicVAxDXW2EcHxz/tgZykCuENMZn35S6gKY9V9tm1C3w+TuYZJQq0NGp/a6tLm2 Z28vZY0iouN1PCMs1Ru26x3dwINgCJ7HNYFB0Ntt0HY9XOgnIn8z6MPb9ACv3YB25mCt twmXje7JICb/QzCrhg6qTgq8DKE8iMNodVSQyBlSLpYk6c9jfgsKeBXbmXmS379C8D2I DuYQPsxItWkQAHocDbtbU8wRs0WC1Sxj/mriqlLzFdYjukFKmyZfSjwQ0ETr9OCcbmze 5z8rT3pMNROZH3tNzgKP+cDMYB2M68yvOOcipsn5AejP5elW9dVuZbHk2O7p3IhHRCyG 3d/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pEGWrSqUP6BZujFmQ+Fz15950Yp6fS/iTg2m5txnlM4=; b=AwyEVycd5WQYzvVXb2u/rP0bX6Vj3V10V/7kyNxAsLRCxPJkmih6XCp57X/FrJz5gH sHF9Y1sIGiTSQGg6gGTKcXj0l5evav3oqhp5gS2PyGhPfuEIYabHYtjjLuDHc8/GYZsm v5+RhBEEDhWg3U/YeRxoU7QulSB3b8yCiZy8k0tNZpVYvvNTYuH4hvBZDbatHaHX2Fmx LWd938ApsM3k3K+OrgsMqOA5kRzB/yugFGn4sEEc4pMgfqcewBTZrYYWiH1F9dtiLuLP JeashJMjKmCby1sKfTJPurb5CGKUKGj0vOPGyA0GT6KYhcYBctNOMh+l4LivS7nELqX2 8/1A== X-Gm-Message-State: AOAM5324xM2/3APwXvME6pely+fNEJ6STbO5bzpqhpCFLAw4FreCm2LW nPOtlDUHIKjgPZPQoUCCC4dLDOltJ9/pdHR1wVvlR6DDOlE= X-Google-Smtp-Source: ABdhPJxlUuB4lFH1SltO5Fmekrg0MnqAyhvq4UvVH+kN40BwzHw3ZVrmQ4jXGNmVomxBKhJ+tmD7/r/4+d9z67Bboq4= X-Received: by 2002:a17:906:8152:: with SMTP id z18mr4482291ejw.317.1607563950461; Wed, 09 Dec 2020 17:32:30 -0800 (PST) MIME-Version: 1.0 References: <20201209042144.2281-1-airlied@gmail.com> <20201209042144.2281-5-airlied@gmail.com> In-Reply-To: From: Dave Airlie Date: Thu, 10 Dec 2020 11:32:18 +1000 Message-ID: To: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: split fdi code out from intel_display.c X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 9 Dec 2020 at 20:48, Daniel Vetter wrote: > > On Wed, Dec 9, 2020 at 5:22 AM Dave Airlie wrote: > > > > From: Dave Airlie > > > > This just refactors out the fdi code to a separate file. > > > > Signed-off-by: Dave Airlie > > There's also hsw_fdi_link_train from intel_ddi.c (another fairly big > file), I think that also belongs in here. It's not in the vtable > because it's directly called from the hsw crt encoder. With that this > looks reasonable to me. It does but it's definitely a lot messier to move, it has a lot of links into the ddi code and tables. I'll add another patch to the end that we can look at to decide if there's a cleaner way to do it. Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx