From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Airlie <airlied@gmail.com>
Subject: Re: [PATCH 13/13] drm/radeon: rework recursive gpu reset handling
Date: Fri, 20 Apr 2012 07:57:09 +0100
Message-ID: <CAPM=9txr5EMjY4T8CtEtphkzTcxK8vRerzurXSNnLfHXY7CTxw@mail.gmail.com>
References: <1334875160-5454-1-git-send-email-deathsimple@vodafone.de>
	<1334875160-5454-14-git-send-email-deathsimple@vodafone.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-yw0-f49.google.com (mail-yw0-f49.google.com
	[209.85.213.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id CF4729E798
	for <dri-devel@lists.freedesktop.org>;
	Thu, 19 Apr 2012 23:57:09 -0700 (PDT)
Received: by yhjj52 with SMTP id j52so5542331yhj.36
	for <dri-devel@lists.freedesktop.org>;
	Thu, 19 Apr 2012 23:57:09 -0700 (PDT)
In-Reply-To: <1334875160-5454-14-git-send-email-deathsimple@vodafone.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: =?ISO-8859-1?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

2012/4/19 Christian K=F6nig <deathsimple@vodafone.de>:
> Instead of all this humpy pumpy with recursive
> mutex (which also fixes only halve of the problem)
> move the actual gpu reset out of the fence code,
> return -EDEADLK and then reset the gpu in the
> calling ioctl function.

I'm trying to figure out if this has any disadvantages over doing what
I proposed before and just kicking a thread to reset the gpu.

It seems like this should also avoid the locking problems, I'd like to
make sure we don't return -EDEADLK to userspace by accident anywhere,
since I don't think it prepared for it and it would be an ABI change.

Dave.