From: Dave Airlie <airlied@gmail.com> To: Thomas Zimmermann <tzimmermann@suse.de>, Lyude Paul <lyude@redhat.com> Cc: "DRM maintainer tools announcements, discussion, and development" <dim-tools@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel <dri-devel@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Sean Paul <sean@poorly.run>, Intel Graphics Development <intel-gfx@lists.freedesktop.org> Subject: Re: [PULL] drm-misc-next-fixes Date: Fri, 18 Jun 2021 12:30:51 +1000 [thread overview] Message-ID: <CAPM=9tyQMXVTaggmiTrqXkaH_RsTOcNW9CA98CbFf0kwqP_T5Q@mail.gmail.com> (raw) In-Reply-To: <CAPM=9tz-8WVAt5r_P+fH+SLnfnaPw-u-u9h8PvcioxVn6Ye_Fg@mail.gmail.com> On Fri, 18 Jun 2021 at 12:26, Dave Airlie <airlied@gmail.com> wrote: > > when I pulled this in drm-next I got these. > > were the mst fixes meant for next or fixes btw? I'm not really sure, > but either way I don't think this is a local reason it doesn't build > or did I miss something? Hi Thomas, Please resend with the fix Lyude has pushed (just keep building, just keep building). Thanks, Dave. > > Dave. > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c: > In function ‘drm_dp_update_payload_part1’: > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:450:27: > error: request for member ‘dev’ in something not a structure or union > 450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__) > | ^~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3392:5: > note: in expansion of macro ‘drm_dbg_kms’ > 3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i); > | ^~~~~~~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3392:68: > warning: passing argument 3 of ‘drm_dev_dbg’ makes pointer from > integer without a cast [-Wint-conversion] > 3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i); > | ^ > | | > | int > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:450:53: > note: in definition of macro ‘drm_dbg_kms’ > 450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__) > | ^~~ > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:338:16: > note: expected ‘const char *’ but argument is of type ‘int’ > 338 | const char *format, ...); > | ~~~~~~~~~~~~^~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:53: > error: macro "drm_dbg_kms" requires 3 arguments, but only 1 given > 3407 | drm_dbg_kms("Fail:set payload to invalid sink"); > | ^ > In file included from > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:45: > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:449: note: > macro "drm_dbg_kms" defined here > 449 | #define drm_dbg_kms(drm, fmt, ...) \ > | > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: > error: ‘drm_dbg_kms’ undeclared (first use in this function) > 3407 | drm_dbg_kms("Fail:set payload to invalid sink"); > | ^~~~~~~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: > note: each undeclared identifier is reported only once for each > function it appears in > make[4]: *** [/home/airlied/devel/kernel/dim/src/scripts/Makefile.build:272: > drivers/gpu/drm/drm_dp_mst_topology.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > > On Thu, 17 Jun 2021 at 04:30, Thomas Zimmermann <tzimmermann@suse.de> wrote: > > > > Hi Dave and Daniel, > > > > here's this week's PR for drm-misc-next-fixes. > > > > Best regards > > Thomas > > > > drm-misc-next-fixes-2021-06-16: > > Short summary of fixes pull: > > > > * hyperv: advertise the correct formatmodifiers for its primary plane > > * dp_mst: VCPI fixes to make it work with StarTech hub > > > > The following changes since commit 1bd8a7dc28c1c410f1ceefae1f2a97c06d1a67c2: > > > > Merge tag 'exynos-drm-next-for-v5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-next (2021-06-11 14:19:12 +1000) > > > > are available in the Git repository at: > > > > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-fixes-2021-06-16 > > > > for you to fetch changes up to 3769e4c0af5b82c8ea21d037013cb9564dfaa51f: > > > > drm/dp_mst: Avoid to mess up payload table by ports in stale topology (2021-06-16 12:57:46 -0400) > > > > ---------------------------------------------------------------- > > Short summary of fixes pull: > > > > * hyperv: advertise the correct formatmodifiers for its primary plane > > * dp_mst: VCPI fixes to make it work with StarTech hub > > > > ---------------------------------------------------------------- > > Pu Lehui (1): > > drm/hyperv: Fix unused const variable 'hyperv_modifiers' > > > > Wayne Lin (2): > > drm/dp_mst: Do not set proposed vcpi directly > > drm/dp_mst: Avoid to mess up payload table by ports in stale topology > > > > drivers/gpu/drm/drm_dp_mst_topology.c | 65 +++++++++++++++++------------ > > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +- > > 2 files changed, 40 insertions(+), 27 deletions(-) > > > > -- > > Thomas Zimmermann > > Graphics Driver Developer > > SUSE Software Solutions Germany GmbH > > Maxfeldstr. 5, 90409 Nürnberg, Germany > > (HRB 36809, AG Nürnberg) > > Geschäftsführer: Felix Imendörffer
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com> To: Thomas Zimmermann <tzimmermann@suse.de>, Lyude Paul <lyude@redhat.com> Cc: "DRM maintainer tools announcements, discussion, and development" <dim-tools@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel <dri-devel@lists.freedesktop.org>, Maxime Ripard <mripard@kernel.org>, Intel Graphics Development <intel-gfx@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PULL] drm-misc-next-fixes Date: Fri, 18 Jun 2021 12:30:51 +1000 [thread overview] Message-ID: <CAPM=9tyQMXVTaggmiTrqXkaH_RsTOcNW9CA98CbFf0kwqP_T5Q@mail.gmail.com> (raw) In-Reply-To: <CAPM=9tz-8WVAt5r_P+fH+SLnfnaPw-u-u9h8PvcioxVn6Ye_Fg@mail.gmail.com> On Fri, 18 Jun 2021 at 12:26, Dave Airlie <airlied@gmail.com> wrote: > > when I pulled this in drm-next I got these. > > were the mst fixes meant for next or fixes btw? I'm not really sure, > but either way I don't think this is a local reason it doesn't build > or did I miss something? Hi Thomas, Please resend with the fix Lyude has pushed (just keep building, just keep building). Thanks, Dave. > > Dave. > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c: > In function ‘drm_dp_update_payload_part1’: > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:450:27: > error: request for member ‘dev’ in something not a structure or union > 450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__) > | ^~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3392:5: > note: in expansion of macro ‘drm_dbg_kms’ > 3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i); > | ^~~~~~~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3392:68: > warning: passing argument 3 of ‘drm_dev_dbg’ makes pointer from > integer without a cast [-Wint-conversion] > 3392 | drm_dbg_kms("Virtual channel %d is not in current topology\n", i); > | ^ > | | > | int > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:450:53: > note: in definition of macro ‘drm_dbg_kms’ > 450 | drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__) > | ^~~ > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:338:16: > note: expected ‘const char *’ but argument is of type ‘int’ > 338 | const char *format, ...); > | ~~~~~~~~~~~~^~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:53: > error: macro "drm_dbg_kms" requires 3 arguments, but only 1 given > 3407 | drm_dbg_kms("Fail:set payload to invalid sink"); > | ^ > In file included from > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:45: > /home/airlied/devel/kernel/dim/src/include/drm/drm_print.h:449: note: > macro "drm_dbg_kms" defined here > 449 | #define drm_dbg_kms(drm, fmt, ...) \ > | > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: > error: ‘drm_dbg_kms’ undeclared (first use in this function) > 3407 | drm_dbg_kms("Fail:set payload to invalid sink"); > | ^~~~~~~~~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c:3407:7: > note: each undeclared identifier is reported only once for each > function it appears in > make[4]: *** [/home/airlied/devel/kernel/dim/src/scripts/Makefile.build:272: > drivers/gpu/drm/drm_dp_mst_topology.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > > On Thu, 17 Jun 2021 at 04:30, Thomas Zimmermann <tzimmermann@suse.de> wrote: > > > > Hi Dave and Daniel, > > > > here's this week's PR for drm-misc-next-fixes. > > > > Best regards > > Thomas > > > > drm-misc-next-fixes-2021-06-16: > > Short summary of fixes pull: > > > > * hyperv: advertise the correct formatmodifiers for its primary plane > > * dp_mst: VCPI fixes to make it work with StarTech hub > > > > The following changes since commit 1bd8a7dc28c1c410f1ceefae1f2a97c06d1a67c2: > > > > Merge tag 'exynos-drm-next-for-v5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-next (2021-06-11 14:19:12 +1000) > > > > are available in the Git repository at: > > > > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-fixes-2021-06-16 > > > > for you to fetch changes up to 3769e4c0af5b82c8ea21d037013cb9564dfaa51f: > > > > drm/dp_mst: Avoid to mess up payload table by ports in stale topology (2021-06-16 12:57:46 -0400) > > > > ---------------------------------------------------------------- > > Short summary of fixes pull: > > > > * hyperv: advertise the correct formatmodifiers for its primary plane > > * dp_mst: VCPI fixes to make it work with StarTech hub > > > > ---------------------------------------------------------------- > > Pu Lehui (1): > > drm/hyperv: Fix unused const variable 'hyperv_modifiers' > > > > Wayne Lin (2): > > drm/dp_mst: Do not set proposed vcpi directly > > drm/dp_mst: Avoid to mess up payload table by ports in stale topology > > > > drivers/gpu/drm/drm_dp_mst_topology.c | 65 +++++++++++++++++------------ > > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +- > > 2 files changed, 40 insertions(+), 27 deletions(-) > > > > -- > > Thomas Zimmermann > > Graphics Driver Developer > > SUSE Software Solutions Germany GmbH > > Maxfeldstr. 5, 90409 Nürnberg, Germany > > (HRB 36809, AG Nürnberg) > > Geschäftsführer: Felix Imendörffer _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-18 2:31 UTC|newest] Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 18:30 [PULL] drm-misc-next-fixes Thomas Zimmermann 2021-06-16 18:30 ` [Intel-gfx] " Thomas Zimmermann 2021-06-18 2:26 ` Dave Airlie 2021-06-18 2:26 ` [Intel-gfx] " Dave Airlie 2021-06-18 2:30 ` Dave Airlie [this message] 2021-06-18 2:30 ` Dave Airlie 2021-06-18 8:58 ` Daniel Vetter 2021-06-18 8:58 ` [Intel-gfx] " Daniel Vetter 2021-06-18 2:30 ` Lyude Paul 2021-06-18 2:30 ` [Intel-gfx] " Lyude Paul -- strict thread matches above, loose matches on Subject: below -- 2024-03-21 16:19 Thomas Zimmermann 2024-03-14 8:28 Thomas Zimmermann 2024-03-07 12:46 Thomas Zimmermann 2024-02-29 8:53 Thomas Zimmermann 2024-01-19 12:13 Maxime Ripard 2024-01-19 12:13 ` Maxime Ripard 2024-01-11 10:11 Maxime Ripard 2024-01-11 10:11 ` Maxime Ripard 2024-01-04 14:45 Maxime Ripard 2024-01-04 14:45 ` Maxime Ripard 2023-12-21 8:36 Maxime Ripard 2023-12-21 8:36 ` Maxime Ripard 2023-11-02 13:31 Maarten Lankhorst 2023-09-11 14:19 Thomas Zimmermann 2023-09-01 7:01 Thomas Zimmermann 2023-08-24 18:12 Thomas Zimmermann 2023-08-17 13:18 Thomas Zimmermann 2023-07-06 11:31 Thomas Zimmermann 2023-06-29 11:38 Thomas Zimmermann 2023-06-15 11:40 Thomas Zimmermann 2023-04-26 6:04 Maarten Lankhorst 2023-02-28 9:13 Thomas Zimmermann 2023-02-23 18:25 Maarten Lankhorst 2023-02-23 18:48 ` Maxime Ripard 2023-02-21 12:36 Thomas Zimmermann 2023-02-16 10:39 Thomas Zimmermann 2023-02-09 9:17 Thomas Zimmermann 2023-02-02 8:14 Thomas Zimmermann 2023-01-03 14:49 Maxime Ripard 2023-01-03 20:03 ` Daniel Vetter 2022-12-08 8:40 Maxime Ripard 2022-08-10 10:41 Thomas Zimmermann 2022-07-21 7:06 Thomas Zimmermann 2022-07-14 14:09 Thomas Zimmermann 2022-05-19 8:05 Maxime Ripard 2022-04-07 10:56 Maarten Lankhorst 2022-04-07 11:52 ` Maxime Ripard 2022-03-24 13:18 Maarten Lankhorst 2022-03-24 13:15 Maarten Lankhorst 2022-01-21 8:27 Thomas Zimmermann 2022-01-14 14:24 Thomas Zimmermann 2022-01-14 15:39 ` Daniel Vetter 2022-01-13 8:29 Thomas Zimmermann 2022-01-14 13:24 ` Daniel Vetter 2021-12-23 9:23 Thomas Zimmermann 2021-11-10 8:21 Maxime Ripard 2021-11-05 7:43 Maxime Ripard 2021-09-09 8:25 Maarten Lankhorst 2021-09-03 9:38 Maarten Lankhorst 2021-07-01 9:08 Thomas Zimmermann 2021-06-24 7:16 Thomas Zimmermann 2021-06-18 8:58 Thomas Zimmermann 2021-05-06 12:27 Maxime Ripard 2021-04-29 9:03 Maxime Ripard 2021-04-22 16:33 Maxime Ripard 2021-04-22 16:40 ` Alex Deucher 2021-04-26 7:35 ` Maxime Ripard 2021-04-28 20:57 ` Alex Deucher 2021-04-29 9:32 ` Maxime Ripard 2021-02-25 9:25 Maarten Lankhorst 2021-02-11 15:44 Maarten Lankhorst 2020-12-22 19:13 Thomas Zimmermann 2021-01-04 8:05 ` Thomas Zimmermann 2020-12-15 13:04 Thomas Zimmermann 2020-12-15 16:27 ` Daniel Vetter 2020-10-20 14:14 Maxime Ripard 2020-10-13 6:57 Maxime Ripard 2020-10-09 7:53 Maxime Ripard 2020-10-02 6:52 Maxime Ripard 2020-08-05 10:00 Maarten Lankhorst 2020-06-11 7:50 Thomas Zimmermann 2020-05-27 8:01 Thomas Zimmermann 2020-04-09 9:14 Maxime Ripard 2020-04-04 9:00 Maxime Ripard 2020-03-26 13:04 Maxime Ripard 2020-02-07 9:43 Maarten Lankhorst 2019-12-12 14:04 Sean Paul 2019-12-04 21:22 Sean Paul 2019-11-20 20:49 Sean Paul 2019-11-20 20:49 ` Sean Paul 2019-11-13 21:10 Sean Paul 2019-11-13 21:10 ` Sean Paul 2019-11-06 20:27 Sean Paul 2019-09-23 16:09 Maxime Ripard 2019-09-18 14:09 Maxime Ripard 2019-09-06 7:05 Maxime Ripard 2019-07-18 15:14 Sean Paul 2019-07-12 8:33 Maarten Lankhorst 2019-06-27 13:03 Maarten Lankhorst 2019-05-15 20:17 Sean Paul 2019-05-08 20:51 Sean Paul 2019-05-01 19:09 Sean Paul 2019-04-24 21:06 Sean Paul 2019-03-13 19:21 Maxime Ripard 2019-03-06 10:54 Maxime Ripard 2019-01-02 17:26 Maarten Lankhorst 2018-10-31 20:19 Sean Paul 2018-10-17 20:07 Sean Paul 2018-10-10 20:39 Sean Paul 2018-08-22 19:38 Sean Paul 2018-08-02 11:17 Gustavo Padovan 2018-06-15 8:11 Maarten Lankhorst 2018-05-31 8:11 Maarten Lankhorst 2018-04-11 14:03 Sean Paul 2018-04-04 19:14 Sean Paul 2018-03-28 19:13 Sean Paul 2018-01-31 15:09 Gustavo Padovan 2018-01-18 17:09 Gustavo Padovan 2017-11-23 19:45 Daniel Vetter 2017-11-08 13:00 Daniel Vetter 2017-11-07 13:44 Daniel Vetter 2017-08-28 21:22 Sean Paul 2017-07-10 19:58 Sean Paul 2017-06-27 20:53 Sean Paul 2017-04-20 20:11 Sean Paul 2017-04-20 21:50 ` Daniel Vetter 2017-04-21 15:29 ` Sumit Semwal 2017-04-21 18:10 ` Sean Paul 2017-04-12 22:58 Sean Paul 2017-02-27 15:52 Daniel Vetter 2017-02-15 13:54 Jani Nikula 2017-02-16 9:39 ` Jani Nikula 2017-02-09 8:43 Daniel Vetter 2016-12-10 21:52 Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPM=9tyQMXVTaggmiTrqXkaH_RsTOcNW9CA98CbFf0kwqP_T5Q@mail.gmail.com' \ --to=airlied@gmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dim-tools@lists.freedesktop.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=lyude@redhat.com \ --cc=rodrigo.vivi@intel.com \ --cc=sean@poorly.run \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.