From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65372C38A2A for ; Thu, 7 May 2020 18:27:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3735E2073A for ; Thu, 7 May 2020 18:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qq3s6nqq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3735E2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68CE26E1A2; Thu, 7 May 2020 18:27:41 +0000 (UTC) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72FC66E1A2; Thu, 7 May 2020 18:27:40 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id g16so6394412eds.1; Thu, 07 May 2020 11:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QWr9DvvsMFmVxp+qAwg3fX2KrqX/x6aAo4AYWgOB5Qw=; b=Qq3s6nqqoirAAWmT8i1qcGBVqcM5eqsmvAZFMeO5bvnrgwHbozvVaIfvFH5hXFgipQ eHr+jvPnrHGtNTFv13OEhpHVxgtq8tMBxgzUHHLdrlqV+/FG9GzT8yu0FUjAVBpDHC1t ZQb3yEutLxMZZ6OBH6+waaxmfaWrDLTwOYJ1t4+m3MkvCZYBhXWobfNbyyStXO53ZSOf KRiG5bIeT/3KiIC5SJvaA6rH9jS7frfNfUEsxhVwvI9YpFltlkz5ZiiXfiFKuCl2DAic 92fsK8OAqeAY3uO0iE4FQhkZLroaVGboZchzZdD76C2pcWwPV8qDQy+NqJGIxsyz0YiH DxsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QWr9DvvsMFmVxp+qAwg3fX2KrqX/x6aAo4AYWgOB5Qw=; b=pLrPa3UghCOIXhB3zOLfWB+5F624VVdHMM6Z9OMggEGdSNcSJ1UQoVtvDkaubTknkH UovG1bEwqB+fixueog6zt7Q4eM3K89JAMzsHBV79a4E0R6pDsHcCL32Fu35TGJK2cFoZ sp/OiDc9LfXRsp0eFY6reAWEl+QF7g4LYxW9CBhrnkT45LVIhKUJaINzQW+tLA3tF3VO 0Xwd8A/IS2s4j4WHcAXNT8M3ejHYeUj4HFHqdYVBvh6zwjZ6WNXxMWoVzk0Ca/tKVxD5 d437WBFd/BsXTyzhaTerL++hbzKwMnz5owFr9RgH65tG8jaoZ/G7EkddIpgvAtztimC6 5Z1A== X-Gm-Message-State: AGi0PubTt4jcysHbKxVfirb9l0LTpmyQZF3YABrcJIDAFllmBkFlXhDA zKK5K69KO67LesPuYimLpWIYw+MZVkBn58pldTo= X-Google-Smtp-Source: APiQypIFjIE2vo4XeHmJyZb97yPbBOSylzyVFDiC7OpkOgyk6jxnlccOcS92g7BZTbYHhMSpTscRNbilT+QLNX3gqwI= X-Received: by 2002:a50:a365:: with SMTP id 92mr13625862edn.220.1588876058972; Thu, 07 May 2020 11:27:38 -0700 (PDT) MIME-Version: 1.0 References: <20200507153600.314454-1-jason@jlekstrand.net> <158886626795.20858.1870213936656066157@build.alporthouse.com> In-Reply-To: <158886626795.20858.1870213936656066157@build.alporthouse.com> From: Dave Airlie Date: Fri, 8 May 2020 04:27:27 +1000 Message-ID: Subject: Re: [PATCH] RFC: i915: Drop relocation support on Gen12+ To: Chris Wilson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Intel Graphics Development , dri-devel , Jason Ekstrand , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 8 May 2020 at 01:44, Chris Wilson wrote: > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12 is > > only supported by iris which never uses relocations. The older i965 > > driver in Mesa does use relocations but it only supports Intel hardware > > through Gen11 and has been deprecated for all hardware Gen9+. The entire > > relocation UAPI and related infrastructure, therefore, doesn't have any > > open-source userspace consumer starting with Gen12. > > > > Rejecting relocations starting with Gen12 has the benefit that we don't > > have to bother supporting it on platforms with local memory. Given how > > much CPU touching of memory is required for relocations, not having to > > do so on platforms where not all memory is directly CPU-accessible > > carries significant advantages. > > You are not supplying them, the kernel is not checking them [as they > don't exist], so there is no material benefit. The only question is > maintainability. > > How confident are you that you will never use them and rewrite the > media-driver? The code exists, will be tested, and can just as easily > expire with the rest of execbuffer2. >From an upstream POV I say hell yes, if the hw isn't generally available yet, and the media-driver/intel-compute-runtime people are warned in advance, I'm all in on ripping it out for new GENs. Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FABBC47257 for ; Thu, 7 May 2020 18:27:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0410B2073A for ; Thu, 7 May 2020 18:27:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qq3s6nqq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0410B2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 469A76EA51; Thu, 7 May 2020 18:27:42 +0000 (UTC) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72FC66E1A2; Thu, 7 May 2020 18:27:40 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id g16so6394412eds.1; Thu, 07 May 2020 11:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QWr9DvvsMFmVxp+qAwg3fX2KrqX/x6aAo4AYWgOB5Qw=; b=Qq3s6nqqoirAAWmT8i1qcGBVqcM5eqsmvAZFMeO5bvnrgwHbozvVaIfvFH5hXFgipQ eHr+jvPnrHGtNTFv13OEhpHVxgtq8tMBxgzUHHLdrlqV+/FG9GzT8yu0FUjAVBpDHC1t ZQb3yEutLxMZZ6OBH6+waaxmfaWrDLTwOYJ1t4+m3MkvCZYBhXWobfNbyyStXO53ZSOf KRiG5bIeT/3KiIC5SJvaA6rH9jS7frfNfUEsxhVwvI9YpFltlkz5ZiiXfiFKuCl2DAic 92fsK8OAqeAY3uO0iE4FQhkZLroaVGboZchzZdD76C2pcWwPV8qDQy+NqJGIxsyz0YiH DxsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QWr9DvvsMFmVxp+qAwg3fX2KrqX/x6aAo4AYWgOB5Qw=; b=pLrPa3UghCOIXhB3zOLfWB+5F624VVdHMM6Z9OMggEGdSNcSJ1UQoVtvDkaubTknkH UovG1bEwqB+fixueog6zt7Q4eM3K89JAMzsHBV79a4E0R6pDsHcCL32Fu35TGJK2cFoZ sp/OiDc9LfXRsp0eFY6reAWEl+QF7g4LYxW9CBhrnkT45LVIhKUJaINzQW+tLA3tF3VO 0Xwd8A/IS2s4j4WHcAXNT8M3ejHYeUj4HFHqdYVBvh6zwjZ6WNXxMWoVzk0Ca/tKVxD5 d437WBFd/BsXTyzhaTerL++hbzKwMnz5owFr9RgH65tG8jaoZ/G7EkddIpgvAtztimC6 5Z1A== X-Gm-Message-State: AGi0PubTt4jcysHbKxVfirb9l0LTpmyQZF3YABrcJIDAFllmBkFlXhDA zKK5K69KO67LesPuYimLpWIYw+MZVkBn58pldTo= X-Google-Smtp-Source: APiQypIFjIE2vo4XeHmJyZb97yPbBOSylzyVFDiC7OpkOgyk6jxnlccOcS92g7BZTbYHhMSpTscRNbilT+QLNX3gqwI= X-Received: by 2002:a50:a365:: with SMTP id 92mr13625862edn.220.1588876058972; Thu, 07 May 2020 11:27:38 -0700 (PDT) MIME-Version: 1.0 References: <20200507153600.314454-1-jason@jlekstrand.net> <158886626795.20858.1870213936656066157@build.alporthouse.com> In-Reply-To: <158886626795.20858.1870213936656066157@build.alporthouse.com> From: Dave Airlie Date: Fri, 8 May 2020 04:27:27 +1000 Message-ID: To: Chris Wilson Subject: Re: [Intel-gfx] [PATCH] RFC: i915: Drop relocation support on Gen12+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Intel Graphics Development , dri-devel , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 8 May 2020 at 01:44, Chris Wilson wrote: > > Quoting Jason Ekstrand (2020-05-07 16:36:00) > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12 is > > only supported by iris which never uses relocations. The older i965 > > driver in Mesa does use relocations but it only supports Intel hardware > > through Gen11 and has been deprecated for all hardware Gen9+. The entire > > relocation UAPI and related infrastructure, therefore, doesn't have any > > open-source userspace consumer starting with Gen12. > > > > Rejecting relocations starting with Gen12 has the benefit that we don't > > have to bother supporting it on platforms with local memory. Given how > > much CPU touching of memory is required for relocations, not having to > > do so on platforms where not all memory is directly CPU-accessible > > carries significant advantages. > > You are not supplying them, the kernel is not checking them [as they > don't exist], so there is no material benefit. The only question is > maintainability. > > How confident are you that you will never use them and rewrite the > media-driver? The code exists, will be tested, and can just as easily > expire with the rest of execbuffer2. >From an upstream POV I say hell yes, if the hw isn't generally available yet, and the media-driver/intel-compute-runtime people are warned in advance, I'm all in on ripping it out for new GENs. Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx