All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, matt.fleming@intel.com
Subject: Re: [PATCH V2 4/4] efifb: Implement vga_default_device()
Date: Fri, 20 Apr 2012 12:13:19 +0100	[thread overview]
Message-ID: <CAPM=9tz2Nxm8s-oDeCME2F1PmgLOAGFp7Y-8+oyMUoEn0eAeVQ@mail.gmail.com> (raw)
In-Reply-To: <1334607965-9582-4-git-send-email-mjg@redhat.com>

On Mon, Apr 16, 2012 at 9:26 PM, Matthew Garrett <mjg@redhat.com> wrote:
> EFI doesn't typically make use of the legacy VGA ROM, but it may still be
> configured to pass that through to a given video device. This may lead to
> an inaccurate choice of default video device. Add support to efifb to pick
> out the correct active video device.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> Cc: hpa@zytor.com
> Cc: matt.fleming@intel.com
> ---
>  arch/x86/include/asm/vga.h |    6 ++++
>  drivers/video/efifb.c      |   77 ++++++++++++++++++++++++++++++++------------
>  2 files changed, 63 insertions(+), 20 deletions(-)
>
> diff --git a/arch/x86/include/asm/vga.h b/arch/x86/include/asm/vga.h
> index c4b9dc2..2723c07 100644
> --- a/arch/x86/include/asm/vga.h
> +++ b/arch/x86/include/asm/vga.h
> @@ -17,4 +17,10 @@
>  #define vga_readb(x) (*(x))
>  #define vga_writeb(x, y) (*(y) = (x))
>
> +#if CONFIG_FB_EFI

^ #ifdef?

Dave.

  reply	other threads:[~2012-04-20 11:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 20:26 [PATCH V2 1/4] vgaarb: Add support for setting the default video device Matthew Garrett
2012-04-16 20:26 ` [PATCH V2 2/4] vga-switcheroo: Use vga_default_device() Matthew Garrett
2012-04-16 20:26 ` [PATCH V2 3/4] x86: Use vga_default_device() when determining whether an fb is primary Matthew Garrett
2012-04-16 20:26 ` [PATCH V2 4/4] efifb: Implement vga_default_device() Matthew Garrett
2012-04-20 11:13   ` Dave Airlie [this message]
2012-04-16 20:52 ` [PATCH V2 1/4] vgaarb: Add support for setting the default video device H. Peter Anvin
2012-04-16 23:00   ` Benjamin Herrenschmidt
2012-04-18  9:37 ` Geert Uytterhoeven
2012-04-18  9:44   ` Geert Uytterhoeven
2012-04-20 10:49     ` Dave Airlie
2012-04-20 10:51       ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM=9tz2Nxm8s-oDeCME2F1PmgLOAGFp7Y-8+oyMUoEn0eAeVQ@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.