From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85985C433E0 for ; Thu, 6 Aug 2020 03:46:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EDF3206D4 for ; Thu, 6 Aug 2020 03:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B3s3hBXc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EDF3206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 556AB6E871; Thu, 6 Aug 2020 03:46:57 +0000 (UTC) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0B546E871 for ; Thu, 6 Aug 2020 03:46:55 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id v22so23293029edy.0 for ; Wed, 05 Aug 2020 20:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f2kb8WT6iJUpQoGUmjdEKWB1j0Md48P0Y6vHOyGo29M=; b=B3s3hBXcbfQCf3Uz5Dg4ixywxCm49c2oaMaBQG7zGnPK376hBCW64xzquLDI41FrXt M82Bb/AHXRn2uiGkJUzuHa9P+h5geMuGRQRi/a6GhlUB1xYTdE0WqZtYYJ6smvDLL9fX vN2bllEExePKU2ZLiLGEajHxQeHCAgRCC1iU0mnk+f3Y3p82Yg/opALuBFsHnFW3aqQX fIJxy5yI7JOu6h0eK3o5m7YGYQ7D5qTor5QEnka4zk6b3j7GGjRxU48zZWH2wHZ+kOv5 o60WKW1FrYaqnjvxXrxu0KhB595y5CAzPG79CuroLo3l6XcGN4CrqCyKpMs/tvnzS2W3 ZzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f2kb8WT6iJUpQoGUmjdEKWB1j0Md48P0Y6vHOyGo29M=; b=lEwp5Cd7Ul8+GYNKGA98xskNyR1zNw8bCqFvNpWkS8qfVwvW61p+DWVvvM6fROZGQk wGgO4urubjzMspU0lWJvQOFVoe54b3L9NUGKJ87HqrEYM3TJPGbVqcToIXZrniZhFR6h U1hSJO27kQJ3O/+6fJbrE563mPUaeXeGefWaMaPyVAtGkpajuaFDV0u9iKcE8FJPg3ge G8E5R9mN976pae10QGfL2q1Rw8hYmk4EFQIK6d2iCWLr+panh4aky5OofnOE7yyIK3Qx TQgzyUPElAu6bGlGJ7MFPW/4OZOdIK4uDP3zINoTMjRqjpJe0aICbSxAsD0mOGbVGb3k imjA== X-Gm-Message-State: AOAM533kf9BloCz1a2477Mbkf6NdbxfUuEmVXvszXWkjoJkGL1+ni0HW CpD1XQhV2x/v8C3tamdVwKcE0dlkmj63IdjF2OY= X-Google-Smtp-Source: ABdhPJyBvJUB9ah9AT1r4E58cEy13MVS9hV52YQM2gFnCxBeSnJjX8nAXoIpo6PDUb6M9/HXD/8t3DasIrQ+tb9KVC0= X-Received: by 2002:aa7:cc10:: with SMTP id q16mr2158257edt.298.1596685614550; Wed, 05 Aug 2020 20:46:54 -0700 (PDT) MIME-Version: 1.0 References: <20200731040520.3701599-1-airlied@gmail.com> <20200731040520.3701599-40-airlied@gmail.com> In-Reply-To: From: Dave Airlie Date: Thu, 6 Aug 2020 13:46:42 +1000 Message-ID: Subject: Re: [PATCH 39/49] drm/ttm: make ttm_bo_man_init/takedown take type + args To: =?UTF-8?Q?Christian_K=C3=B6nig?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roland Scheidegger , Ben Skeggs , dri-devel , Gerd Hoffmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > That was not what I was talking about. Take a look at what those fields > are used for :) > > > As far as I see the only usage of the size is in > ttm_resource_manager_debug(). But this size is actually totally opaque > to TTM, it could be pages, bytes, fried chicken wings or whatever. In > other words it would be much better to print it in the debug callback of > each resource manager. Size is a bit trickier as the drivers use in a couple of funky places, radeon pokes inside the range manager and adjust its size post init, and amdgpu uses size to validate a bunch of bo sizing. These shouldn't be too messy to workaround. > The available_caching is completely superfluous as well. The original > idea what that a driver could specify multiple placements as flags in > one entry, but no driver ever used that as far as I know and it became > completely deprecated in 2014 when I moved the lpfn and fpfn into each > place. > > > The default_caching is used in ttm_bo_select_caching(), but this is > complete utterly nonsense. It just results in multiple possible cache > behaviors being selected, which are then fortunately ignored by > ttm_tt_set_placement_caching :) > > > To be honest I think just removing those parameters and the associated > caching flags all together is the next logical step. Definitely something to burn down alright. Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel