From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Airlie <airlied@gmail.com>
Subject: Re: [RFC] drm + i915 DP MST code preview
Date: Thu, 8 May 2014 17:32:53 +1000
Message-ID: <CAPM=9tzP5ZDV6w82Bd6OVTTAc2HFuCaaMGYc0RjSRF0PpLwUBw@mail.gmail.com>
References: <1399005585-2396-1-git-send-email-airlied@gmail.com>
 <20140502085206.GB21695@nuc-i3427.alporthouse.com>
 <CAPM=9ty=-HycajKWZD7TddLxr23RTcLp94L_JDRPbh-5JQK41w@mail.gmail.com>
 <20140503090028.GB9420@nuc-i3427.alporthouse.com>
 <5369DDD5.5010906@nvidia.com>
 <20140507080734.GR5730@phenom.ffwll.local>
 <CAPM=9tyDQfQuaUM441PkTPPy0knzfzg3U5v=pooKkLOvc3W9fQ@mail.gmail.com>
 <CAPM=9tz8oecv+vyVXDEuSE92yQNU74mU9kpRhmDj=naiYwYaHA@mail.gmail.com>
 <20140508072402.GB20315@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com
 [209.85.217.170])
 by gabe.freedesktop.org (Postfix) with ESMTP id AF4AE6EDF8
 for <dri-devel@lists.freedesktop.org>; Thu,  8 May 2014 00:32:54 -0700 (PDT)
Received: by mail-lb0-f170.google.com with SMTP id w7so2976444lbi.1
 for <dri-devel@lists.freedesktop.org>; Thu, 08 May 2014 00:32:53 -0700 (PDT)
In-Reply-To: <20140508072402.GB20315@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Dave Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Aaron Plattner <aplattner@nvidia.com>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 8 May 2014 17:24, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, May 08, 2014 at 11:56:02AM +1000, Dave Airlie wrote:
>> I've pushed a branch of -modesetting to
>>
>> http://cgit.freedesktop.org/~airlied/xf86-video-modesetting/log/?h=dp-mst
>
> In parse_path_blob():
> char conn_id[5];
>
> len = conn - (blob_data + 4);
> if (len + 1> 5) return -1;
>
> memcpy(conn_id, blob_data + 4, len);
> conn_id[len + 1] = '\0';
>         ^^^^^^^ should just be len.

Nice catch, thanks, I'll fix that,

The kernel side for this along with even more locking and refcounting
fixes is in
http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-i915-mst-support

Dave.