From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 0/2] drm/edid: Undo the damage from adding extra_modes Date: Fri, 20 Jul 2012 12:03:10 +1000 Message-ID: References: <1340637919-5322-1-git-send-email-ajax@redhat.com> <874npz8gb7.fsf@turtle.gmx.de> <1340646110.11265.52.camel@atropine> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 5279F9E86C for ; Thu, 19 Jul 2012 19:03:11 -0700 (PDT) Received: by qcpx40 with SMTP id x40so2560621qcp.26 for ; Thu, 19 Jul 2012 19:03:10 -0700 (PDT) In-Reply-To: <1340646110.11265.52.camel@atropine> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: Sven Joachim , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 26, 2012 at 3:41 AM, Adam Jackson wrote: > On Mon, 2012-06-25 at 19:14 +0200, Sven Joachim wrote: >> On 2012-06-25 17:25 +0200, Adam Jackson wrote: >> >> > This fixes the extra_mode walk to be much more conservative. I still think >> > the whole idea is bogus and that guessing about clone mode sizes is a >> > userspace policy decision, but apparently xrandr --newmode / --addmode is >> > unreasonably burdensome. >> > >> > This should fix a number of reported regressions, please test. >> >> Does not help in my case, unfortunately: instead of a bogus 1680x945 >> resolution I get a bogus 1400x1050 rather than the correct 1280x1024. >> >> Going to try Takashi's patch instead. > > Takashi's patch will promite 1280x1024 to the default - which is correct > - but you'll still see a 1400x1050 in the mode list, because your > monitor claims a maximum pixel clock of 140MHz and maximum hsync of > 81kHz, and 1400x1050@60 fits in that. > > Fixing that would probably require additional quirk work to add > "preferred mode is physical pixel size". EDID 1.4 redefines the "first > detailed mode is preferred" bit to mean that anyway, but we're not > currently using that to filter the mode list. > Hey ajax still want these two patches in -next? I've got them on my unreviewed list. Dave.