From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 4/7] drm/lease: Check for lessor outside of locks Date: Wed, 3 Apr 2019 11:33:37 +1000 Message-ID: References: <20190228144910.26488-1-daniel.vetter@ffwll.ch> <20190228144910.26488-5-daniel.vetter@ffwll.ch> <20190314090725.0a79f285@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190314090725.0a79f285@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: IGT development , Daniel Vetter , Keith Packard , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNCBNYXIgMjAxOSBhdCAxODowNywgQm9yaXMgQnJlemlsbG9uCjxib3Jpcy5icmV6 aWxsb25AY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4KPiBPbiBUaHUsIDI4IEZlYiAyMDE5IDE1OjQ5 OjA3ICswMTAwCj4gRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6 Cj4KPiA+IFRoZSBsZXNzb3IgaXMgaW52YXJpYW50IG92ZXIgYSBsaWZldGltZSBvZiBhIGxlYXNl LCB3ZSBkb24ndCBoYXZlIHRvCj4gPiBncmFiIGFueSBsb2NrcyBmb3IgdGhhdC4gU3BlZWRzIHVw IHRoZSBjb21tb24gY2FzZSBvZiBub3QgYmVpbmcgYSBsZWFzZS4KPiA+Cj4gPiBDYzogS2VpdGgg UGFja2FyZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2RybV9sZWFzZS5jIHwgNiArKystLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2xlYXNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2xlYXNlLmMKPiA+IGluZGV4IGNjZTVk OWRkNTJmZi4uNjk0ZmYzNjNhOTBiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9sZWFzZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2xlYXNlLmMKPiA+IEBAIC0x MTEsNyArMTExLDcgQEAgc3RhdGljIGJvb2wgX2RybV9oYXNfbGVhc2VkKHN0cnVjdCBkcm1fbWFz dGVyICptYXN0ZXIsIGludCBpZCkKPiA+ICAgKi8KPiA+ICBib29sIF9kcm1fbGVhc2VfaGVsZChz dHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgaW50IGlkKQo+ID4gIHsKPiA+IC0gICAgIGlmIChm aWxlX3ByaXYgPT0gTlVMTCB8fCBmaWxlX3ByaXYtPm1hc3RlciA9PSBOVUxMKQo+ID4gKyAgICAg aWYgKCFmaWxlX3ByaXYgfHwgIWZpbGVfcHJpdi0+bWFzdGVyKQo+Cj4gTG9va3MgbGlrZSB5b3Un cmUgZG9pbmcgdW5yZWxhdGVkIGNvc21ldGljIGNoYW5nZXMgaW4gdGhlIHNhbWUgcGF0Y2guCj4g TWF5YmUgbWVudGlvbiB0aGF0IGluIHRoZSBjb21taXQgbWVzc2FnZSwgb3IgbW92ZSB0aGF0IHRv IGEgc2VwYXJhdGUKPiBwYXRjaC4KPgo+ID4gICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPiA+ Cj4gPiAgICAgICByZXR1cm4gX2RybV9sZWFzZV9oZWxkX21hc3RlcihmaWxlX3ByaXYtPm1hc3Rl ciwgaWQpOwo+ID4gQEAgLTEzMyw3ICsxMzMsNyBAQCBib29sIGRybV9sZWFzZV9oZWxkKHN0cnVj dCBkcm1fZmlsZSAqZmlsZV9wcml2LCBpbnQgaWQpCj4gPiAgICAgICBzdHJ1Y3QgZHJtX21hc3Rl ciAqbWFzdGVyOwo+ID4gICAgICAgYm9vbCByZXQ7Cj4gPgo+ID4gLSAgICAgaWYgKGZpbGVfcHJp diA9PSBOVUxMIHx8IGZpbGVfcHJpdi0+bWFzdGVyID09IE5VTEwpCj4gPiArICAgICBpZiAoIWZp bGVfcHJpdiB8fCAhZmlsZV9wcml2LT5tYXN0ZXIgfHwgIWZpbGVfcHJpdi0+bWFzdGVyLT5sZXNz b3IpCj4gPiAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+ID4KPiA+ICAgICAgIG1hc3RlciA9 IGZpbGVfcHJpdi0+bWFzdGVyOwo+ID4gQEAgLTE1OSw3ICsxNTksNyBAQCB1aW50MzJfdCBkcm1f bGVhc2VfZmlsdGVyX2NydGNzKHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LCB1aW50MzJfdCBj cnRjc19pbikKPiA+ICAgICAgIGludCBjb3VudF9pbiwgY291bnRfb3V0Owo+ID4gICAgICAgdWlu dDMyX3QgY3J0Y3Nfb3V0ID0gMDsKPiA+Cj4gPiAtICAgICBpZiAoZmlsZV9wcml2ID09IE5VTEwg fHwgZmlsZV9wcml2LT5tYXN0ZXIgPT0gTlVMTCkKPiA+ICsgICAgIGlmICghZmlsZV9wcml2IHx8 ICFmaWxlX3ByaXYtPm1hc3RlciB8fCAhZmlsZV9wcml2LT5tYXN0ZXItPmxlc3NvcikKPiA+ICAg ICAgICAgICAgICAgcmV0dXJuIGNydGNzX2luOwo+ID4KPiA+ICAgICAgIG1hc3RlciA9IGZpbGVf cHJpdi0+bWFzdGVyOwo+Cj4gQ291bGRuJ3Qgd2UgYWxzbyByZW1vdmUgdGhlIGlmIChtYXN0ZXIt Pmxlc3NvcikgY2hlY2sgZG9uZSBpbgo+IF9kcm1fbGVhc2VfaGVsZF9tYXN0ZXIoKT8KCkRhbmll bCwgYW5zd2VycyBmb3IgdGhlc2U/IF5eCgpEYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20190228144910.26488-1-daniel.vetter@ffwll.ch> <20190228144910.26488-5-daniel.vetter@ffwll.ch> <20190314090725.0a79f285@collabora.com> In-Reply-To: <20190314090725.0a79f285@collabora.com> From: Dave Airlie Date: Wed, 3 Apr 2019 11:33:37 +1000 Message-ID: Subject: Re: [igt-dev] [PATCH 4/7] drm/lease: Check for lessor outside of locks List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Boris Brezillon Cc: IGT development , Keith Packard , DRI Development List-ID: T24gVGh1LCAxNCBNYXIgMjAxOSBhdCAxODowNywgQm9yaXMgQnJlemlsbG9uCjxib3Jpcy5icmV6 aWxsb25AY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4KPiBPbiBUaHUsIDI4IEZlYiAyMDE5IDE1OjQ5 OjA3ICswMTAwCj4gRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6 Cj4KPiA+IFRoZSBsZXNzb3IgaXMgaW52YXJpYW50IG92ZXIgYSBsaWZldGltZSBvZiBhIGxlYXNl LCB3ZSBkb24ndCBoYXZlIHRvCj4gPiBncmFiIGFueSBsb2NrcyBmb3IgdGhhdC4gU3BlZWRzIHVw IHRoZSBjb21tb24gY2FzZSBvZiBub3QgYmVpbmcgYSBsZWFzZS4KPiA+Cj4gPiBDYzogS2VpdGgg UGFja2FyZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2RybV9sZWFzZS5jIHwgNiArKystLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2xlYXNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2xlYXNlLmMKPiA+IGluZGV4IGNjZTVk OWRkNTJmZi4uNjk0ZmYzNjNhOTBiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9sZWFzZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2xlYXNlLmMKPiA+IEBAIC0x MTEsNyArMTExLDcgQEAgc3RhdGljIGJvb2wgX2RybV9oYXNfbGVhc2VkKHN0cnVjdCBkcm1fbWFz dGVyICptYXN0ZXIsIGludCBpZCkKPiA+ICAgKi8KPiA+ICBib29sIF9kcm1fbGVhc2VfaGVsZChz dHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgaW50IGlkKQo+ID4gIHsKPiA+IC0gICAgIGlmIChm aWxlX3ByaXYgPT0gTlVMTCB8fCBmaWxlX3ByaXYtPm1hc3RlciA9PSBOVUxMKQo+ID4gKyAgICAg aWYgKCFmaWxlX3ByaXYgfHwgIWZpbGVfcHJpdi0+bWFzdGVyKQo+Cj4gTG9va3MgbGlrZSB5b3Un cmUgZG9pbmcgdW5yZWxhdGVkIGNvc21ldGljIGNoYW5nZXMgaW4gdGhlIHNhbWUgcGF0Y2guCj4g TWF5YmUgbWVudGlvbiB0aGF0IGluIHRoZSBjb21taXQgbWVzc2FnZSwgb3IgbW92ZSB0aGF0IHRv IGEgc2VwYXJhdGUKPiBwYXRjaC4KPgo+ID4gICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPiA+ Cj4gPiAgICAgICByZXR1cm4gX2RybV9sZWFzZV9oZWxkX21hc3RlcihmaWxlX3ByaXYtPm1hc3Rl ciwgaWQpOwo+ID4gQEAgLTEzMyw3ICsxMzMsNyBAQCBib29sIGRybV9sZWFzZV9oZWxkKHN0cnVj dCBkcm1fZmlsZSAqZmlsZV9wcml2LCBpbnQgaWQpCj4gPiAgICAgICBzdHJ1Y3QgZHJtX21hc3Rl ciAqbWFzdGVyOwo+ID4gICAgICAgYm9vbCByZXQ7Cj4gPgo+ID4gLSAgICAgaWYgKGZpbGVfcHJp diA9PSBOVUxMIHx8IGZpbGVfcHJpdi0+bWFzdGVyID09IE5VTEwpCj4gPiArICAgICBpZiAoIWZp bGVfcHJpdiB8fCAhZmlsZV9wcml2LT5tYXN0ZXIgfHwgIWZpbGVfcHJpdi0+bWFzdGVyLT5sZXNz b3IpCj4gPiAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+ID4KPiA+ICAgICAgIG1hc3RlciA9 IGZpbGVfcHJpdi0+bWFzdGVyOwo+ID4gQEAgLTE1OSw3ICsxNTksNyBAQCB1aW50MzJfdCBkcm1f bGVhc2VfZmlsdGVyX2NydGNzKHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LCB1aW50MzJfdCBj cnRjc19pbikKPiA+ICAgICAgIGludCBjb3VudF9pbiwgY291bnRfb3V0Owo+ID4gICAgICAgdWlu dDMyX3QgY3J0Y3Nfb3V0ID0gMDsKPiA+Cj4gPiAtICAgICBpZiAoZmlsZV9wcml2ID09IE5VTEwg fHwgZmlsZV9wcml2LT5tYXN0ZXIgPT0gTlVMTCkKPiA+ICsgICAgIGlmICghZmlsZV9wcml2IHx8 ICFmaWxlX3ByaXYtPm1hc3RlciB8fCAhZmlsZV9wcml2LT5tYXN0ZXItPmxlc3NvcikKPiA+ICAg ICAgICAgICAgICAgcmV0dXJuIGNydGNzX2luOwo+ID4KPiA+ICAgICAgIG1hc3RlciA9IGZpbGVf cHJpdi0+bWFzdGVyOwo+Cj4gQ291bGRuJ3Qgd2UgYWxzbyByZW1vdmUgdGhlIGlmIChtYXN0ZXIt Pmxlc3NvcikgY2hlY2sgZG9uZSBpbgo+IF9kcm1fbGVhc2VfaGVsZF9tYXN0ZXIoKT8KCkRhbmll bCwgYW5zd2VycyBmb3IgdGhlc2U/IF5eCgpEYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2lndC1kZXY=