From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 24/81] drm/fb helper: don't call drm_crtc_helper_set_config Date: Fri, 20 Jul 2012 11:17:47 +1000 Message-ID: References: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> <1342016944-23395-25-git-send-email-daniel.vetter@ffwll.ch> <20120718154922.GC5348@phenom.ffwll.local> <20120718155010.GD5348@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120718155010.GD5348@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jul 19, 2012 at 1:50 AM, Daniel Vetter wrote: > Actually including Dave on the recipient list might work bettter ;-) > > On Wed, Jul 18, 2012 at 05:49:22PM +0200, Daniel Vetter wrote: >> Hi Dave, >> >> Can you please pick this one up for -next? There are a few other issues >> where the fb helper is a bit too intimate with the crtc helper (i.e. it >> depends upon callbacks and behaviour only provided when using the crtc >> helpers). But this one here is the only one I can't work around in i915.ko >> and hence would block merging the modeset rewrite for 3.7. >> >> I've put a todo down to untangle the fb helper a bit better from the crtc >> helper, but that's for a later patch series. >> >> Yours, Daneil >> >> PS: Can you also pick up the other drm patch in this series? That unused >> list_head confused me quite a bit until I've noticed that it's ... unused. >> Merged. Thanks. Dave.