From: Dave Airlie <airlied@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Ben Skeggs <bskeggs@redhat.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure.
Date: Wed, 29 Jul 2020 10:08:00 +1000 [thread overview]
Message-ID: <CAPM=9tzz2a3pAY3MkvVS+FCiOxX6WNs2bmooHO0E47i6P4V0JA@mail.gmail.com> (raw)
In-Reply-To: <b18a4abf-6a05-7d2f-4c75-3e48396894ae@amd.com>
On Tue, 28 Jul 2020 at 17:49, Christian König <christian.koenig@amd.com> wrote:
>
> Am 28.07.20 um 06:17 schrieb Dave Airlie:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > This is confusing, and from my reading of all the drivers only
> > nouveau got this right.
> >
> > Just make the API act under driver control of it's own allocation
> > failing, and don't call destroy, if the page table fails to
> > create there is nothing to cleanup here.
> >
> > (I'm willing to believe I've missed something here, so please
> > review deeply).
> >
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
>
> That looks right to me as well, Reviewed-by: Christian König
> <christian.koenig@amd.com>
Landed this in drm-next as well.
Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-29 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 4:17 [PATCH] drm/ttm/nouveau: don't call tt destroy callback on alloc failure Dave Airlie
2020-07-28 7:48 ` Christian König
2020-07-29 0:08 ` Dave Airlie [this message]
2020-07-29 12:17 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9tzz2a3pAY3MkvVS+FCiOxX6WNs2bmooHO0E47i6P4V0JA@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.