From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F432C433EF for ; Tue, 14 Sep 2021 16:51:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C9D6109E for ; Tue, 14 Sep 2021 16:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbhINQxA (ORCPT ); Tue, 14 Sep 2021 12:53:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbhINQw7 (ORCPT ); Tue, 14 Sep 2021 12:52:59 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7FCC061574 for ; Tue, 14 Sep 2021 09:51:41 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id k4so30234824lfj.7 for ; Tue, 14 Sep 2021 09:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SjSQE15uKcrKRnQuwXqswKvc6fyo2MaxbsLWDKYQ4RY=; b=DO2pmRkTjsKJiTLCol77A0gNdGwgoMm2ep17W0C9mucS7ff/YCFdWbSHs2ErU6fhPu YUzTMjtCt8PLZc31uy2O+m8HW0pswP6pDCYl1qQiX9gB0CrYRIo9fUGPJbMM1HH3oalL HrPPpKM1rd1RoAq3HwZSYyx1VeRlEHHMYTGmLqu3hR00cj54+41Zv283qlza8SvPKvAZ tanO7zyNiVbf6CE/ZEjUZBkJjLVMDxd2b13weLL0PMmqUaggV+EuLDXmU/dD1sz0bLCz uSjKQVgCiuuPHwY7GioyHiEl0/b3gCsHQ4b6BfK75gOdCzG7324Z83iVL+FENUbnD4e/ a5jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SjSQE15uKcrKRnQuwXqswKvc6fyo2MaxbsLWDKYQ4RY=; b=jaX0iDudeJ4zuW+DvqG9G2vR5HfKtr/XjIDdsRw0v41COfj/Z5FzETB/AhCMWk5NZ+ mdbHcKyWj4PpiEnwsux2Cf/sT/ofP3jaWDSEycuUhYkPr92BzaqWSN4j4LzuCzGMLzbl H3dI6oYAg9/CDsMQPSplJ//T1VYywkoyW7s/mAm71L3w8PDLDCBlvIIPallg0kh44RvJ QCNaXrskMpghLq3QNqsxQj+84eAI6j8Ih+wQRu4WMuxrBRHo7XHZPS2makv1qZPJ5ztE 53JQBr7PYaraXPJLjajcJ2JJSb2INAcrHudyqIE0hGXY6xS3igfHEQTbKp1+C5Bx2u4e ZcSg== X-Gm-Message-State: AOAM53015M3JxbMFp6LftGh9WaDdbrsMNnBOnHOXxjkfN0QhhWlj864M 9CDg0baqnlHJnh3qlgE6y5ZWkjyk1bj+x7ZM5LNIxg== X-Google-Smtp-Source: ABdhPJw8kEH9jiZmIM3Ry3MTSBK9jdpUAOYp3qY4qOZ2T79bacMn9Mr8HKuTARFGh+rP4G9Wpd+ptyNvmJGYAEKk6BQ= X-Received: by 2002:ac2:4e98:: with SMTP id o24mr13877402lfr.295.1631638299813; Tue, 14 Sep 2021 09:51:39 -0700 (PDT) MIME-Version: 1.0 References: <20210908184905.163787-1-posk@google.com> <20210908184905.163787-4-posk@google.com> In-Reply-To: From: Peter Oskolkov Date: Tue, 14 Sep 2021 09:51:28 -0700 Message-ID: Subject: Re: [PATCH 3/4 v0.5] sched/umcg: RFC: implement UMCG syscalls To: Jann Horn Cc: Peter Oskolkov , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Paul Turner , Ben Segall , Andrei Vagin , Thierry Delisle Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 8, 2021 at 6:40 PM Jann Horn wrote: [...] > I think umcg_idle_loop() should never be called from scheduler > callbacks (meaning umcg_wq_worker_running()), only from UMCG syscalls. I'm moving umcg_wq_worker_running() out of core.c/sched_update_worker() and into /kernel/entry/common.c/exit_to_user_mode_loop() (and will rename the function appropriately). It seems rescheduling/sleeping there is fine. I'm not yet sure if this is all that is needed to deal with UMCG_TF_PREEMPTED flag; but I don't expect to see any locks held when the task truly returns to the userspace. Maybe I'll need to set TIF_NOTIFY_RESUME in sched_update_worker()... [...]