From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CD8C433B4 for ; Tue, 20 Apr 2021 16:28:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93B2C613CE for ; Tue, 20 Apr 2021 16:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbhDTQ26 (ORCPT ); Tue, 20 Apr 2021 12:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233170AbhDTQ26 (ORCPT ); Tue, 20 Apr 2021 12:28:58 -0400 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799BDC06174A for ; Tue, 20 Apr 2021 09:28:25 -0700 (PDT) Received: by mail-ua1-x934.google.com with SMTP id j8so9769898uak.2 for ; Tue, 20 Apr 2021 09:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q+XSOjXPKQeUlfip/kcHH5wP/0vJ0tXFQPSgekpaeio=; b=coPhDDfdhLVpvR7Sd3C8EQwSfM8DeWRGPSBQtm3iJSqbK2JAemnEnMTu349XXh1Ijp EG7j9JOrESjtBvSJXSTw/id9jbPxr1W0ESvOTwhBRs32bj2mR3ZEdSM6k/xam3bD2H+N q2Zfk08XW7ksj7+GdVyP/RW41mYQ3irD2VX3eIm3urrQukdnFr67wxXzdJ1m5y7mv+Gz mBkBMPu4eTZYWsorEhLQVfKl40dmt8JPsFaEgyYRJ+3lQ2rooERYw9kfQjFDwGCKSO0v U4cfcQrQ2WzJZJrWoCrvUW4BdYeCMtTX2sf7OJvA8GCeyCxfSMHcjtF/8996HDhhzSw1 sCSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+XSOjXPKQeUlfip/kcHH5wP/0vJ0tXFQPSgekpaeio=; b=WdPo6KmikwmGy32RfINKo0BAvAMgf5xhJ8aFfwxhxAcf+gTUpWSCYqgmY0o4LTDY8a s8s3xkdIuuNe4OB/rjRvEMWT5VRZPw20VAh2zzg6jKhaxu2GpG4XhOIWd53lqdLr/iju Lf7qEcOKYplWRD6jLfDFl76Nn039buh+7bKHhEPUcxryaalibbGwZqJj9F7Er9MvqvR0 DTKvNdCFURkLlIjtKvTehtuBPzrukN47qeWp7LBSLVCeQOG+BZ/ZwXy/aGYaKAwOpUAW OMTL/Dt99WtaW2HNC12Iokx88B32tzBAGOLehtdW+l7vhSH0HSYTgKApLvMTkpTpWJCq 8gag== X-Gm-Message-State: AOAM530BRT1CxvSQXrk0s5SEufzUmkkX7Hfw1zvBb7J8AJe6yD15RkIk l+8dU1Inmjw9cpNMdYcTJlv7rG7TXEFa3htzeeiOxQ== X-Google-Smtp-Source: ABdhPJxqBV+1Z2yG4hPseFOhFrLCyJCDrD4+rW6KXFwKw4k5lbW1Fsw3IVfZ2+KnYax4i75I1zlV6mt/WivYRluCcM0= X-Received: by 2002:ab0:1e06:: with SMTP id m6mr13583365uak.16.1618936104252; Tue, 20 Apr 2021 09:28:24 -0700 (PDT) MIME-Version: 1.0 References: <20210416194709.155497-1-egranata@google.com> <20210420070129.GA3534874@infradead.org> <20210420060807-mutt-send-email-mst@kernel.org> In-Reply-To: <20210420060807-mutt-send-email-mst@kernel.org> From: Enrico Granata Date: Tue, 20 Apr 2021 10:28:13 -0600 Message-ID: Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature To: "Michael S. Tsirkin" Cc: Christoph Hellwig , jasowang@redhat.com, pbonzini@redhat.com, Stefan Hajnoczi , axboe@kernel.dk, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org I prepared a proposed patch to address these concerns: https://lists.oasis-open.org/archives/virtio-dev/202104/msg00007.html Feedback will be much appreciated Thanks, - Enrico On Tue, Apr 20, 2021 at 4:08 AM Michael S. Tsirkin wrote: > > On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > > Just to despit my 2 cents again: I think the way this is specified > > in the virtio spec is actively harmful and we should not suport it in > > Linux. > > > > If others override me we at least need to require a detailed > > documentation of these fields as the virto spec does not provide it. > > > > Please also do not add pointless over 80 character lines, and follow > > the one value per sysfs file rule. > > Enrico would you like to raise the issues with the virtio TC > for resolution? > > -- > MST >