From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD46C432BE for ; Tue, 3 Aug 2021 19:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D0BB60F93 for ; Tue, 3 Aug 2021 19:23:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239641AbhHCTXL (ORCPT ); Tue, 3 Aug 2021 15:23:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239608AbhHCTXG (ORCPT ); Tue, 3 Aug 2021 15:23:06 -0400 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE81C061757 for ; Tue, 3 Aug 2021 12:22:55 -0700 (PDT) Received: by mail-vs1-xe32.google.com with SMTP id f27so5710326vsp.8 for ; Tue, 03 Aug 2021 12:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bJgCHqhMD9Em6pMGw1fdW71SGx2aFTx82DIaIl2I9Ys=; b=CCddak14A+GM99hSHiu7epE76CqnYUYPzTR8h1703l29SibcAt1oNz/tPnUdW1DmjF pnT0myJvC3kJ+armd3cw4bpjqyeCx1kPWmtvBMag0p5kfaqMqfcI5aLe/JZyHvQMD/ua bBXLn8scFNTU2y0g0w/rf0qbHQbFN+YN1LNyvJy11lMwBacFG7HJnSPUdDBCM+8QyuRJ Qe3tHD0Dm+ExU/8lrN1RitNdJH4MsDtW5yB1F9Mc6Bqjlw7c3gI5wl6kpcTz5CpVLbQ8 4d6R1LTBWBMAfPQ9YP9mFbeSOAc8PxnCib1aRnb4uwiUOaSBPKqvWr2MiZFyQfwOTRkt Y3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bJgCHqhMD9Em6pMGw1fdW71SGx2aFTx82DIaIl2I9Ys=; b=jf6w0rVhfgkhnTadz3MtnsUdRzfnGT9HcKEmiZMmH56aRBewWucQKo1LvKNfQB1Emr htwWHveQLPwnq9luCA313sFT7ex1+ozaZpDU9PTu3wwdWPPUImLYCCQr0lgfmRYDb0u+ vi/iO1YAYjG2EnSgygcGVROymDhSAXWHFP4lAyUEVrOA3j3qiOz1ignEdd9V2k7KWpAW 2BqjmLYKmvYT4/KEgnFEyvDFInzqbM2/GeQhyrc8A7lnEV8QYwqdlJ80c3+FHARNLoHu 8VLlel5wRe14DkEPa3Zm6gz4kfiWB2V+dnmM1t0PyGc6ucQPM/H8FgFCE7GVvb7J/Yuy mKJQ== X-Gm-Message-State: AOAM532SG2Mk8+DcWOwH0Q1gqV/w7kJL1QG8uTGBKCkNOPvQl62psq2E a9Uy4jwjD8U0C5skIsL9LdqsdcNZ9v83tqfRSMySaw== X-Google-Smtp-Source: ABdhPJx6WntRS1LwyAOVtG21buIXDaq5qKX689ipeUgnlSJIEfOSkf5j1LpCyFsVGCBiGtStKsd8QaYpng+Q1ojf1+8= X-Received: by 2002:a67:d393:: with SMTP id b19mr2327100vsj.49.1628018574319; Tue, 03 Aug 2021 12:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20210803091314.3051302-1-kyletso@google.com> <8dd797be-8912-62e4-a8da-00b8edbfb65b@roeck-us.net> In-Reply-To: <8dd797be-8912-62e4-a8da-00b8edbfb65b@roeck-us.net> From: Badhri Jagan Sridharan Date: Tue, 3 Aug 2021 12:22:18 -0700 Message-ID: Subject: Re: [PATCH] usb: typec: tcpm: Keep other events when receiving FRS and Sourcing_vbus events To: Guenter Roeck Cc: Kyle Tso , Heikki Krogerus , Greg Kroah-Hartman , USB , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 3, 2021 at 6:48 AM Guenter Roeck wrote: > > On 8/3/21 2:13 AM, Kyle Tso wrote: > > When receiving FRS and Sourcing_Vbus events from low-level drivers, keep > > other events which come a bit earlier so that they will not be ignored > > in the event handler. > > > > Fixes: 8dc4bd073663 ("usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS)") > > Cc: Badhri Jagan Sridharan > > Signed-off-by: Kyle Tso > > Reviewed-by: Guenter Roeck Reviewed-by: Badhri Jagan Sridharan > > > --- > > drivers/usb/typec/tcpm/tcpm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > > index 5b22a1c931a9..b9bb63d749ec 100644 > > --- a/drivers/usb/typec/tcpm/tcpm.c > > +++ b/drivers/usb/typec/tcpm/tcpm.c > > @@ -5369,7 +5369,7 @@ EXPORT_SYMBOL_GPL(tcpm_pd_hard_reset); > > void tcpm_sink_frs(struct tcpm_port *port) > > { > > spin_lock(&port->pd_event_lock); > > - port->pd_events = TCPM_FRS_EVENT; > > + port->pd_events |= TCPM_FRS_EVENT; > > spin_unlock(&port->pd_event_lock); > > kthread_queue_work(port->wq, &port->event_work); > > } > > @@ -5378,7 +5378,7 @@ EXPORT_SYMBOL_GPL(tcpm_sink_frs); > > void tcpm_sourcing_vbus(struct tcpm_port *port) > > { > > spin_lock(&port->pd_event_lock); > > - port->pd_events = TCPM_SOURCING_VBUS; > > + port->pd_events |= TCPM_SOURCING_VBUS; > > spin_unlock(&port->pd_event_lock); > > kthread_queue_work(port->wq, &port->event_work); > > } > > >