From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900F3C433DB for ; Tue, 2 Feb 2021 00:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A1CE64E7B for ; Tue, 2 Feb 2021 00:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231454AbhBBAca (ORCPT ); Mon, 1 Feb 2021 19:32:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbhBBAc1 (ORCPT ); Mon, 1 Feb 2021 19:32:27 -0500 Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1C1C061788 for ; Mon, 1 Feb 2021 16:31:28 -0800 (PST) Received: by mail-vk1-xa2a.google.com with SMTP id q66so4422975vke.0 for ; Mon, 01 Feb 2021 16:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cRfY9yymC1FqHBkn3RUJdOofMf5Mx0Cb8K2kp8nCUFk=; b=ut6n8HAljwoT3F8K9mFW5AKoqi+N4P0tVJMl1yrdes34Zwpl5BtzMAa/CF711SbFlf P90pD3ydBcD2o8H5+Nc0QfQ+q/01/Bsr3hfRwCu1e0S7M2vXc2LLsWEkwoxanrizDqc2 4jOtqd7oOEBJ5aomZ1nIZKrTuBZ+7s7Cekd8QXicwwCdvlbq1K8LLcNAYF439EUbZX13 Cqax3TD4xUh9nZPzhhAr3DB/GpxMKEb9aZp1nuae9IHsHrFNkXBeLVJ5+pf6F5SQMURv +qaoJUthKlPknZs64tQJH6tyFRuS/gIfA+HrclKisldZ7CGzhMl8gBkrroA0AqKZwj7K Qpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cRfY9yymC1FqHBkn3RUJdOofMf5Mx0Cb8K2kp8nCUFk=; b=mlSMxXc7CeoMrOZqWq6+/XAoMlsuwaKIWo2Cxi+/0KbkT8AzLWe6jn58yXaM+Okhsz PdU2U+gGxBUyTpu8v5v8RNDl8ANNlc//XOS05nCBMPSGwe9boldEtry/eGbiVkBJ2e8o yrmDQIP3UssemhEa5njkkKy16Rfy7EozMn8DvI8mILGbcTyxO6NP1xPU2qHkuIgPFnZq TroYJup+Z/IBAzuRJNTgqZQxSlkgtsNVb/jODxbbCEQVCiro96g6QOI76DQPhfEl0Mlh /x3To1hcPVKuep+wyTlZq2P1E74vqBqOk1+Bu2qmneFpxWQ4YCqmTtTKBQvzvtoZvvJ9 sH+A== X-Gm-Message-State: AOAM533afDtwBk1Kz4LMOHS/twySi6fh/Jxu1tBw64UdQq+MDOgOfq4D GU9SaY+zfZ64dyLneqVJhZnRn8G02/7f8SqHZ/gK6Q== X-Google-Smtp-Source: ABdhPJx0Gf9HxU2uyjDQFdbU6rj8ju/V4B81N6W+1rXfacAJuGaAduX9GSF+/vnI4QN3MQzuXPMSYli7m7Wx3bIzP80= X-Received: by 2002:a1f:6ac3:: with SMTP id f186mr4764475vkc.18.1612225887587; Mon, 01 Feb 2021 16:31:27 -0800 (PST) MIME-Version: 1.0 References: <20210201095309.39486-1-badhri@google.com> In-Reply-To: From: Badhri Jagan Sridharan Date: Mon, 1 Feb 2021 16:30:51 -0800 Message-ID: Subject: Re: [PATCH v1 1/3] usb: typec: tcpm: Add Callback to Usb Communication capable partner To: Guenter Roeck Cc: Heikki Krogerus , Greg Kroah-Hartman , Kyle Tso , USB , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 1, 2021 at 6:59 AM Guenter Roeck wrote: > > On 2/1/21 1:53 AM, Badhri Jagan Sridharan wrote: > > The USB Communications Capable bit indicates if port > > partner is capable of communication over the USB data lines > > (e.g. D+/- or SS Tx/Rx). Notify the status of the bit to low > > level drivers to perform chip specific operation. > > For instance, low level driver enables USB switches on D+/D- > > lines to set up data path when the bit is set. > > > > Refactored from patch initially authored by > > Kyle Tso > > > > Signed-off-by: Badhri Jagan Sridharan > > --- > > drivers/usb/typec/tcpm/tcpm.c | 16 ++++++++++++++++ > > include/linux/usb/tcpm.h | 5 +++++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > > index 0afd8ef692e8..96190b4d46a7 100644 > > --- a/drivers/usb/typec/tcpm/tcpm.c > > +++ b/drivers/usb/typec/tcpm/tcpm.c > > @@ -298,6 +298,7 @@ struct tcpm_port { > > struct usb_pd_identity partner_ident; > > struct typec_partner_desc partner_desc; > > struct typec_partner *partner; > > + bool partner_usb_comm_capable; > > > > enum typec_cc_status cc_req; > > > > @@ -3429,6 +3430,16 @@ static void tcpm_unregister_altmodes(struct tcpm_port *port) > > memset(modep, 0, sizeof(*modep)); > > } > > > > +static void tcpm_set_partner_usb_comm_capable(struct tcpm_port *port, bool capable) > > +{ > > + tcpm_log(port, "Setting usb_comm capable %s", capable ? "true" : "false"); > > + > > + if (port->tcpc->set_partner_usb_comm_capable) > > + port->tcpc->set_partner_usb_comm_capable(port->tcpc, capable); > > + > > + port->partner_usb_comm_capable = capable; > > +} > > + > > static void tcpm_reset_port(struct tcpm_port *port) > > { > > int ret; > > @@ -3445,6 +3456,7 @@ static void tcpm_reset_port(struct tcpm_port *port) > > port->attached = false; > > port->pd_capable = false; > > port->pps_data.supported = false; > > + tcpm_set_partner_usb_comm_capable(port, false); > > > > /* > > * First Rx ID should be 0; set this to a sentinel of -1 so that > > @@ -3785,6 +3797,8 @@ static void run_state_machine(struct tcpm_port *port) > > } > > } else { > > tcpm_pd_send_control(port, PD_CTRL_ACCEPT); > > + port->partner_usb_comm_capable = port->sink_request & RDO_USB_COMM; > > That seems to be redundant since tcpm_set_partner_usb_comm_capable() is setting it again. You are correct. This is redundant. Removing in V2 version. > > > + tcpm_set_partner_usb_comm_capable(port, port->partner_usb_comm_capable); > > tcpm_set_state(port, SRC_TRANSITION_SUPPLY, > > PD_T_SRC_TRANSITION); > > } > > @@ -4004,6 +4018,8 @@ static void run_state_machine(struct tcpm_port *port) > > break; > > case SNK_NEGOTIATE_CAPABILITIES: > > port->pd_capable = true; > > + port->partner_usb_comm_capable = port->sink_request & RDO_USB_COMM; > > Same here. But then I don't really see where this variable is actually used. > Am I missing something ? Not used anywhere else. Removing this in V2. Also fixing the check for this case. It should have been port->source_caps[0] & PDO_FIXED_USB_COMM Thanks for the reviews, Badhri > > Thanks, > Guenter > > > + tcpm_set_partner_usb_comm_capable(port, port->partner_usb_comm_capable); > > port->hard_reset_count = 0; > > ret = tcpm_pd_send_request(port); > > if (ret < 0) { > > diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h > > index 3af99f85e8b9..42fcfbe10590 100644 > > --- a/include/linux/usb/tcpm.h > > +++ b/include/linux/usb/tcpm.h > > @@ -108,6 +108,10 @@ enum tcpm_transmit_type { > > * is supported by TCPC, set this callback for TCPM to query > > * whether vbus is at VSAFE0V when needed. > > * Returns true when vbus is at VSAFE0V, false otherwise. > > + * @set_partner_usb_comm_capable: > > + * Optional; The USB Communications Capable bit indicates if port > > + * partner is capable of communication over the USB data lines > > + * (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit. > > */ > > struct tcpc_dev { > > struct fwnode_handle *fwnode; > > @@ -139,6 +143,7 @@ struct tcpc_dev { > > int (*set_auto_vbus_discharge_threshold)(struct tcpc_dev *dev, enum typec_pwr_opmode mode, > > bool pps_active, u32 requested_vbus_voltage); > > bool (*is_vbus_vsafe0v)(struct tcpc_dev *dev); > > + void (*set_partner_usb_comm_capable)(struct tcpc_dev *dev, bool enable); > > }; > > > > struct tcpm_port; > > >