From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4824C433E0 for ; Fri, 19 Feb 2021 09:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9533D64EC0 for ; Fri, 19 Feb 2021 09:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbhBSJNQ (ORCPT ); Fri, 19 Feb 2021 04:13:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbhBSJHn (ORCPT ); Fri, 19 Feb 2021 04:07:43 -0500 Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B310C061786 for ; Fri, 19 Feb 2021 01:07:02 -0800 (PST) Received: by mail-vk1-xa34.google.com with SMTP id v66so1055628vkd.10 for ; Fri, 19 Feb 2021 01:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yN01wuFruNiwvlR4nWVGFgREmWX9yHFllXRmh8fxIwU=; b=n3/LrxpsC2OkD6fPu/ezlq1VjEsvFGYJCOYMZ5J88dLnqxxoYyPe/rKQNxUSuLuIln TboExNJt5RX7XuGOjmi+CHKe6KOg5bie9RLclwxE3Q4HU2pBjN5yUBxmLXGv/qXtdTzy MpfapeRfJRJbCHj8diZP+lGSH91/hn+uqS+3gVGv1FxG9HaqX6VQT4tcqbtNGe2oSXdq /KgFhgNC5V/3RY7KAh9QYiCZX8bS/0YHl2cmxmEPnH7oKP6zWE97Q+kH976uyz5/bjbc QUbRHoubY6M68u+Sa/nKnoblkNOdmXGg+F/r/yZ7D7RTHrhoHZWxurwm3JvN7AUYAJiQ tJXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yN01wuFruNiwvlR4nWVGFgREmWX9yHFllXRmh8fxIwU=; b=JqvT4cdI06mHN61UHwrK/F6rfgwHo64watYqrVSgE3N6dX+RKw8Fs/4Gkrbh8bfDJy OhCt+qwzkTPsYjw7Q2h8ZnGAtPgrIQ970U46YMOczIBcwouRQCKO/mxpUU9innI7BePy fJ7zXVSl99MuMzRnP/DNp+gDui5m54Bl7GnN0l9KhsXoYuOpJSB8f7r0psQ11rfnp0O4 Ob9XI/rzYxwSvS+scwE94SDw2cSWSpByqvShJ6yswp+VbX64Fk6ub1CQThmhJRei+Lbw ssFn8BeMxRJ6sYzLzfHPeKIcXI4yOAMEt6nBHkTtvBBLPuzOR8YKV281d12ZngDbP2WH gbCA== X-Gm-Message-State: AOAM530rC+kddjEwm8fxb283+6VOHxFLAYq5AyI5kSNQZy3Cvjyk6r1N IdtcrgUUoxyxh+vV1/XoK99kCzK3WQ2nFCiTJKQvYg== X-Google-Smtp-Source: ABdhPJzKUm/xh7nllJxIUI73WY+U82eO0Jix5S18RtlTJR4/AkvhLw5A7tcATq+17s+Blm6SA10wg4ku1I2I3uRkAKE= X-Received: by 2002:a1f:9c55:: with SMTP id f82mr235371vke.22.1613725621204; Fri, 19 Feb 2021 01:07:01 -0800 (PST) MIME-Version: 1.0 References: <20210218100243.32187-1-badhri@google.com> In-Reply-To: From: Badhri Jagan Sridharan Date: Fri, 19 Feb 2021 01:06:24 -0800 Message-ID: Subject: Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling To: Greg Kroah-Hartman Cc: Guenter Roeck , Heikki Krogerus , Kyle Tso , USB , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Done. Just sent out the following patch and CCed stable@vger.kernel.org as well. [PATCH v2] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling Thanks, Badhri On Thu, Feb 18, 2021 at 2:42 AM Greg Kroah-Hartman wrote: > > On Thu, Feb 18, 2021 at 02:38:45AM -0800, Badhri Jagan Sridharan wrote: > > Hi Greg, > > > > This patch is a bug fix for the following patch which was introduced in 5.11. > > > > commit f321a02caebdd0c56e167610cda2fa148cd96e8b > > Author: Badhri Jagan Sridharan > > Date: Wed Oct 28 23:31:35 2020 -0700 > > > > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support > > > > TCPCI spec allows TCPC hardware to autonomously discharge the vbus > > capacitance upon disconnect. The expectation is that the TCPM enables > > AutoDischargeDisconnect while entering SNK/SRC_ATTACHED states. Hardware > > then automously discharges vbus when the vbus falls below a certain > > threshold i.e. VBUS_SINK_DISCONNECT_THRESHOLD. > > > > Apart from enabling the vbus discharge circuit, AutoDischargeDisconnect > > is also used a flag to move TCPCI based TCPC implementations into > > Attached.Snk/Attached.Src state as mentioned in > > Figure 4-15. TCPC State Diagram before a Connection of the > > USB Type-C Port Controller Interface Specification. > > In such TCPC implementations, setting AutoDischargeDisconnect would > > prevent TCPC into entering "Connection_Invalid" state as well. > > > > Signed-off-by: Badhri Jagan Sridharan > > Reviewed-by: Heikki Krogerus > > Link: https://lore.kernel.org/r/20201029063138.1429760-8-badhri@google.com > > Signed-off-by: Greg Kroah-Hartman > > Great, then can you resend the patch and add a proper Fixes: tag, along > with a cc: stable as well? > > thanks, > > greg k-h