From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754142AbaKRJaT (ORCPT ); Tue, 18 Nov 2014 04:30:19 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:36615 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbaKRJaP (ORCPT ); Tue, 18 Nov 2014 04:30:15 -0500 MIME-Version: 1.0 In-Reply-To: <2279061.naADrHDgyn@wuerfel> References: <1416220572-13381-1-git-send-email-ankit.jindal@linaro.org> <1416220572-13381-6-git-send-email-ankit.jindal@linaro.org> <2279061.naADrHDgyn@wuerfel> From: Ankit Jindal Date: Tue, 18 Nov 2014 14:59:54 +0530 Message-ID: Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver To: Arnd Bergmann Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Varka Bhadram , Russell King - ARM Linux , Greg Kroah-Hartman , Anup Patel , Guenter Roeck , "patches@apm.com" , Rob Herring , "Hans J. Koch" , Tushar Jagad , Kumar Gala , =?UTF-8?Q?Andreas_F=C3=A4rber?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 November 2014 16:47, Arnd Bergmann wrote: > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote: >> + >> + qmtm1_uio: qmtm_uio@1f200000 { >> + compatible = "apm,xgene-qmtm"; >> + status = "disabled"; >> + reg = <0x0 0x1f200000 0x0 0x10000>, >> + <0x0 0x1b000000 0x0 0x400000>; >> + reg-names = "csr", "fabric"; >> + qpool-memory = <&qmtm1_uio_qpool>; >> + clocks = <&qmtm1clk 0>; >> + num-queues = <0x400>; >> + devid = <1>; >> + }; >> + > > To make my previous review comments clearer: > > NAK > > Do not create device nodes that are meant for a specific use case in > software and that are not usable for the common case. I don't think > it makes any sense to keep on submitting a UIO driver for this until > we have a proper network driver that uses this so we can make sure we > have a working binding. The dataplane frameworks like OpenDataPlane etc, need to have access to complete subsystem from the user space. Hence, we would like to have this driver and some other UIO drivers to be the part of kernel to have data plane frameworks working on our platform. > > Arnd Thanks, Ankit From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ankit Jindal Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver Date: Tue, 18 Nov 2014 14:59:54 +0530 Message-ID: References: <1416220572-13381-1-git-send-email-ankit.jindal@linaro.org> <1416220572-13381-6-git-send-email-ankit.jindal@linaro.org> <2279061.naADrHDgyn@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <2279061.naADrHDgyn@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Varka Bhadram , Russell King - ARM Linux , Greg Kroah-Hartman , Anup Patel , Guenter Roeck , "patches-qTEPVZfXA3Y@public.gmane.org" , Rob Herring , "Hans J. Koch" , Tushar Jagad , Kumar Gala , =?UTF-8?Q?Andreas_F=C3=A4rber?= List-Id: devicetree@vger.kernel.org On 17 November 2014 16:47, Arnd Bergmann wrote: > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote: >> + >> + qmtm1_uio: qmtm_uio@1f200000 { >> + compatible = "apm,xgene-qmtm"; >> + status = "disabled"; >> + reg = <0x0 0x1f200000 0x0 0x10000>, >> + <0x0 0x1b000000 0x0 0x400000>; >> + reg-names = "csr", "fabric"; >> + qpool-memory = <&qmtm1_uio_qpool>; >> + clocks = <&qmtm1clk 0>; >> + num-queues = <0x400>; >> + devid = <1>; >> + }; >> + > > To make my previous review comments clearer: > > NAK > > Do not create device nodes that are meant for a specific use case in > software and that are not usable for the common case. I don't think > it makes any sense to keep on submitting a UIO driver for this until > we have a proper network driver that uses this so we can make sure we > have a working binding. The dataplane frameworks like OpenDataPlane etc, need to have access to complete subsystem from the user space. Hence, we would like to have this driver and some other UIO drivers to be the part of kernel to have data plane frameworks working on our platform. > > Arnd Thanks, Ankit -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ankit.jindal@linaro.org (Ankit Jindal) Date: Tue, 18 Nov 2014 14:59:54 +0530 Subject: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver In-Reply-To: <2279061.naADrHDgyn@wuerfel> References: <1416220572-13381-1-git-send-email-ankit.jindal@linaro.org> <1416220572-13381-6-git-send-email-ankit.jindal@linaro.org> <2279061.naADrHDgyn@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17 November 2014 16:47, Arnd Bergmann wrote: > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote: >> + >> + qmtm1_uio: qmtm_uio at 1f200000 { >> + compatible = "apm,xgene-qmtm"; >> + status = "disabled"; >> + reg = <0x0 0x1f200000 0x0 0x10000>, >> + <0x0 0x1b000000 0x0 0x400000>; >> + reg-names = "csr", "fabric"; >> + qpool-memory = <&qmtm1_uio_qpool>; >> + clocks = <&qmtm1clk 0>; >> + num-queues = <0x400>; >> + devid = <1>; >> + }; >> + > > To make my previous review comments clearer: > > NAK > > Do not create device nodes that are meant for a specific use case in > software and that are not usable for the common case. I don't think > it makes any sense to keep on submitting a UIO driver for this until > we have a proper network driver that uses this so we can make sure we > have a working binding. The dataplane frameworks like OpenDataPlane etc, need to have access to complete subsystem from the user space. Hence, we would like to have this driver and some other UIO drivers to be the part of kernel to have data plane frameworks working on our platform. > > Arnd Thanks, Ankit