From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL2mz-0004Ek-6q for qemu-devel@nongnu.org; Thu, 07 Jul 2016 02:27:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL2mx-0000L7-3a for qemu-devel@nongnu.org; Thu, 07 Jul 2016 02:27:56 -0400 Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:34534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL2mw-0000L3-Ti for qemu-devel@nongnu.org; Thu, 07 Jul 2016 02:27:55 -0400 Received: by mail-vk0-x242.google.com with SMTP id v6so864458vkb.1 for ; Wed, 06 Jul 2016 23:27:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1467732989-12028-1-git-send-email-peter.maydell@linaro.org> References: <1467732989-12028-1-git-send-email-peter.maydell@linaro.org> Date: Thu, 7 Jul 2016 15:27:54 +0900 Message-ID: From: Chanho Park Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org" , "patches@linaro.org" , Riku Voipio , Laurent Vivier , Chanho Park Hi Peter, On Wednesday, July 6, 2016, Peter Maydell wrote: > The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly > defined as IOC_W rather than IOC_R, which meant we weren't > correctly copying the information back from the kernel to the guest. > The loop_info64 structure definition was also missing a member > and using the wrong type for several 32-bit fields. > > In particular, this meant that "kpartx -d image.img" didn't work > and "losetup -a" behaved strangely. Correct the ioctl type definitions. > > Reported-by: Chanho Park > > Signed-off-by: Peter Maydell > > --- It worked well for me. Tested-by: Chanho Park > -- Best Regards, Chanho Park