All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gwendal Grignou <gwendal@chromium.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, groeck@chromium.org, keescook@chromium.org
Subject: Re: [PATCH] FIXUP: proc: Provide details on speculation flaw mitigations
Date: Mon, 14 Jan 2019 10:00:54 -0800	[thread overview]
Message-ID: <CAPUE2usHg7gJRSTiJDCZyNXWQGuuF-bOJhcNNvznncZ1rLrm_Q@mail.gmail.com> (raw)
In-Reply-To: <20190112080125.GA17489@kroah.com>

On Sat, Jan 12, 2019 at 12:01 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jan 11, 2019 at 04:32:12PM -0800, Gwendal Grignou wrote:
> > Prevent an empty line in /proc/self/status, allow iotop to work.
> >
> > iotop does not like empty lines, fails with:
> >   File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line
> > 196, in parse_proc_pid_status
> >     key, value = line.split(':\t', 1)
> > ValueError: need more than 1 value to unpack
> >
> > [reading /proc/self/status]
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > ---
> >  fs/proc/array.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Why send this to me?  Always use scripts/get_maintainer.pl on a patch to
> determine who and what lists to send patches to.
I did, your email address is on the first line:
./scripts/get_maintainer.pl
0001-CHROMIUM-FIXUP-proc-Provide-details-on-speculation-f.patch
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:6/4=100%)
"Srivatsa S. Bhat" <srivatsa@csail.mit.edu> (commit_signer:3/4=75%)
Thomas Gleixner <tglx@linutronix.de>
(commit_signer:3/4=75%,authored:1/4=25%,added_lines:3/28=11%)
David Woodhouse <dwmw@amazon.co.uk> (commit_signer:3/4=75%)
Bo Gan <ganb@vmware.com> (commit_signer:3/4=75%)
Kees Cook <keescook@chromium.org> (authored:1/4=25%,added_lines:23/28=82%)
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
(authored:1/4=25%,removed_lines:1/2=50%)
Gwendal Grignou <gwendal@chromium.org> (authored:1/4=25%,removed_lines:1/2=50%)
linux-kernel@vger.kernel.org (open list)

>
> And is this a new bug?  What commit caused this?
It is only in 4.4 stable. It has been introduced by:
"484964fa3e5a0 proc: Provide details on speculation flaw mitigations"

That patch adds an extra \n in front of "Speculation Store Bypass"
that breaks iotop processing of /proc/../status.

Regards,

Gwendal.
>
> thanks,
>
> greg k-h

  reply	other threads:[~2019-01-14 18:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12  0:32 [PATCH] FIXUP: proc: Provide details on speculation flaw mitigations Gwendal Grignou
2019-01-12  8:01 ` Greg KH
2019-01-14 18:00   ` Gwendal Grignou [this message]
2019-01-14 18:13     ` [PATCH v2] proc: Remove empty line in /proc/self/status Gwendal Grignou
2019-01-14 18:21       ` Guenter Roeck
2019-01-14 18:50         ` Greg Kroah-Hartman
2019-01-14 19:01           ` Guenter Roeck
2019-01-14 19:05             ` Kees Cook
2019-01-16 16:06               ` Guenter Roeck
2019-01-16 17:00                 ` Kees Cook
2019-01-16 17:16                   ` Guenter Roeck
2019-01-18 16:10       ` Greg KH
2019-01-14 18:49     ` [PATCH] FIXUP: proc: Provide details on speculation flaw mitigations Greg KH
2019-01-14 21:36       ` Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUE2usHg7gJRSTiJDCZyNXWQGuuF-bOJhcNNvznncZ1rLrm_Q@mail.gmail.com \
    --to=gwendal@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=keescook@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.