From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53B5C433EF for ; Sat, 6 Nov 2021 06:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86D74611AE for ; Sat, 6 Nov 2021 06:00:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233677AbhKFGDE (ORCPT ); Sat, 6 Nov 2021 02:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232771AbhKFGDD (ORCPT ); Sat, 6 Nov 2021 02:03:03 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74B0AC061570 for ; Fri, 5 Nov 2021 23:00:22 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id z206so13227478iof.0 for ; Fri, 05 Nov 2021 23:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+OJQOpgw6XjOeEYCuqdr+cw0CdJGoPws37dy1y5VAs=; b=BZKCvur6XVR1j04QzFkQDL47569Rtd3K5mfpKAYPKy/hvVdkLmME+D58HlA2Xamr8P 2njfmy8jbw+WxoMG8aCuVKrRNsPu61MihGExYKoHjzeIwqny6oO2XEPyyCZI/WJsau0F qgBSxIbZ1k1xHrQBnUqQGYp8PoDkY6ZyW4/uo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+OJQOpgw6XjOeEYCuqdr+cw0CdJGoPws37dy1y5VAs=; b=3A1KqytnnIrYavmZGp8p+PBJ3f8iEAxIH9Msy+VRVGaeuzChEoXvwy/F61s1OsK4rO QRsy1tC1ARR+dtudv5J16KnrAqVIOd9FaEiyDUoTYY6qxuKzI1ExaTgjG5FtNURjWs+w A5vz1QHrUF9WU3mn59FVYhtLXBgeikYY+FfHi/x5vJT/8V07xncns0I6VCozoiwibHJY 5IVUkisUcJbBxc9FGvXK3dTB2ydgH/Rwk+3oGx6Hdu+v4ZzSGWd6qJNkwlIdVLGfLjFO hSvKCG6WILd8YTYvROR2+Nm5ag6qu5cls0Xj3Wn/cEzP0dhEg5XqthKjnqW1/mWYrqIp PWfg== X-Gm-Message-State: AOAM530ZKlX3YncimtWly5hfY7LaVy2MC7w/ox82djC+rVSVB/9aWz5d +4dqyWvRbUeXWtEgkI4fsm7j51b2672R1u4D71+V4g== X-Google-Smtp-Source: ABdhPJzhPN/6m26A34tHzi4QUOJga51bkwZEdk0ae5UJyghzGGm+B/vFqzfPkCrkd2VRb2L7vGDmtYdx3m94TA9NOrI= X-Received: by 2002:a05:6602:1cc:: with SMTP id w12mr2862651iot.63.1636178421426; Fri, 05 Nov 2021 23:00:21 -0700 (PDT) MIME-Version: 1.0 References: <20211104071303.3604314-1-gwendal@chromium.org> <20211104071303.3604314-5-gwendal@chromium.org> In-Reply-To: <20211104071303.3604314-5-gwendal@chromium.org> From: Gwendal Grignou Date: Fri, 5 Nov 2021 23:00:09 -0700 Message-ID: Subject: Re: [PATCH v2 4/5] dt-bindings: iio: Add sx9324 binding To: jic23@kernel.org, lars@metafoo.de, swboyd@chromium.org Cc: andy.shevchenko@gmail.com, linux-iio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org I need to fix capacitance resolution and meaning of proxraw-strength, they are not accurate. On Thu, Nov 4, 2021 at 12:13 AM Gwendal Grignou wrote: > > Similar to SX9310, add biddings to setup sx9324 hardware properties. > SX9324 is a little different, introduce 4 phases to be configured in 2 > pairs over 3 antennas. > > Signed-off-by: Gwendal Grignou > --- > Changes in v2: > - Fix interrupt documentation wording. > > .../iio/proximity/semtech,sx9324.yaml | 140 ++++++++++++++++++ > 1 file changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > new file mode 100644 > index 0000000000000..2c060803632f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > @@ -0,0 +1,140 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/proximity/semtech,sx9310.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Semtech's SX9324 capacitive proximity sensor > + > +maintainers: > + - Gwendal Grignou > + - Daniel Campello > + > +description: | > + Semtech's SX9324 proximity sensor. > + > +properties: > + compatible: > + enum: > + - semtech,sx9324 > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Generated by device to announce preceding read request has finished > + and data is available or that a close/far proximity event has happened. > + maxItems: 1 > + > + vdd-supply: > + description: Main power supply > + > + svdd-supply: > + description: Host interface power supply > + > + "#io-channel-cells": > + const: 1 > + > + semtech,ph0-pin: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + Indicates how each CS pin is used during phase 0. > + Each of the 3 pins have the following value - > + 0 : unused (high impedance) > + 1 : measured input > + 2 : dynamic shield > + 3 : grounded. > + For instance, CS0 measured, CS1 shield and CS2 ground is [1, 2, 3] > + items: > + enum: [ 0, 1, 2, 3 ] > + minItems: 3 > + maxItems: 3 > + > + semtech,ph1-pin: > + semtech,ph2-pin: > + semtech,ph3-pin: > + Same as ph0-pin > + > + semtech,resolution01 > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + description: > + Capacitance measurement resolution. For phase 0 and 1. > + Higher the number, higher the resolution. > + default: 4 > + > + semtech,resolution23 > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + description: > + Capacitance measurement resolution. For phase 2 and 3 > + default: 4 > + > + semtech,startup-sensor: > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 1, 2, 3] > + default: 0 > + description: > + Phase used for start-up proximity detection. > + It is used when we enable a phase to remove static offset and measure > + only capacitance changes introduced by the user. > + > + semtech,proxraw-strength01: > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + default: 1 > + description: > + PROXRAW filter strength for phase 0 and 1. A value of 0 represents off,i > + and other values represent 1-1/N. > + > + semtech,proxraw-strength23: > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + default: 1 > + description: > + PROXRAW filter strength for phase 2 and 3. A value of 0 represents off,i > + and other values represent 1-1/N. > + > + semtech,avg-pos-strength: > + $ref: /schemas/types.yaml#definitions/uint32 > + enum: [0, 16, 64, 128, 256, 512, 1024, 4294967295] > + default: 16 > + description: > + Average positive filter strength. A value of 0 represents off and > + UINT_MAX (4294967295) represents infinite. Other values > + represent 1-1/N. > + > +required: > + - compatible > + - reg > + - "#io-channel-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + proximity@28 { > + compatible = "semtech,sx9310"; > + reg = <0x28>; > + interrupt-parent = <&pio>; > + interrupts = <5 IRQ_TYPE_LEVEL_LOW 5>; > + vdd-supply = <&pp3300_a>; > + svdd-supply = <&pp1800_prox>; > + #io-channel-cells = <1>; > + semtech,ph0-pin = <1, 2, 3>; > + semtech,ph1-pin = <3, 2, 1>; > + semtech,ph2-pin = <1, 2, 3>; > + semtech,ph3-pin = <3, 2, 1>; > + semtech,resolution01 = 2; > + semtech,resolution23 = 2; > + semtech,startup-sensor = <1>; > + semtech,proxraw-strength01 = <2>; > + semtech,proxraw-strength23 = <2>; > + semtech,avg-pos-strength = <64>; > + }; > + }; > -- > 2.33.1.1089.g2158813163f-goog >