From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CCCC43387 for ; Mon, 14 Jan 2019 21:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E6E820659 for ; Mon, 14 Jan 2019 21:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dYTgLwhv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfANVgs (ORCPT ); Mon, 14 Jan 2019 16:36:48 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:44536 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726856AbfANVgr (ORCPT ); Mon, 14 Jan 2019 16:36:47 -0500 Received: by mail-io1-f65.google.com with SMTP id r200so416914iod.11 for ; Mon, 14 Jan 2019 13:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KGcMk7d0HLNIwsdlwvKPlJ/g4/4HF4VS/MNPd2pUZhs=; b=dYTgLwhvCz9mJMzbVkfYCRODeosQ+425s5iT91OnYuBFEQQJuLGEDzHodyNjM50QRl QU2wZYyDODGF2OQsLQuj6DupV1KUKlkVARKkES9UQKwHZeDBvgichfKoPZkhpbdne4bz YNDqMyefegyTvAZmRMfqZzStBexpwb+mFBahk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KGcMk7d0HLNIwsdlwvKPlJ/g4/4HF4VS/MNPd2pUZhs=; b=A9TFbmljJcQ+n8SUxl2y17DzBRo0Hs1LtJG4pmckT05k/3ap+Q9QYrCrTlNRT0cpFn VJq6u1VQ/ocPvcv9lYd4qoJatmH9ZJ/8ML1ykHoz6F99kmIT6jVqz19dJvnxjjCFCkRS 7u86oEKD03ErBGOjmDaTkl7ynEW4FpyR7ndKp+WB/447lVZxhvRdVVPkcqHqHyrpQ/ZS eoiyab3ZwS9T/M72z2QTMQVPYESMisjdYIWOVdLJPweqjY4gUVybsU+jw6EqzTr2TgKK VNTBT9WMV6TFSfjh0wBN8+QLVLpGzT7Tb6AmmTN3vVfXEZ0XDssFlLFDa9CmNx5ztLnN YViA== X-Gm-Message-State: AJcUukf8QDgCd4iYU8pc81DNKNYnOgSRL7IvzCXvp15zET6lfNhdcVKd Z/FOWngJ4ZnB5SiV2OD26iNBuXxfVm2TiLAa1CdvAYkOv8A= X-Google-Smtp-Source: ALg8bN7Y4F6rXF/N7HxQ8HdFuAd3JnJmOrLHtw52YINRietvjAyG2QAcIVySIuAQHWP/NGSsinvBJJAOq+V8EDzIOx4= X-Received: by 2002:a6b:c544:: with SMTP id v65mr322557iof.118.1547501806583; Mon, 14 Jan 2019 13:36:46 -0800 (PST) MIME-Version: 1.0 References: <20190112003212.103301-1-gwendal@chromium.org> <20190112080125.GA17489@kroah.com> <20190114184935.GA13821@kroah.com> In-Reply-To: <20190114184935.GA13821@kroah.com> From: Gwendal Grignou Date: Mon, 14 Jan 2019 13:36:35 -0800 Message-ID: Subject: Re: [PATCH] FIXUP: proc: Provide details on speculation flaw mitigations To: Greg KH Cc: stable@vger.kernel.org, groeck@chromium.org, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 14, 2019 at 10:49 AM Greg KH wrote: > > On Mon, Jan 14, 2019 at 10:00:54AM -0800, Gwendal Grignou wrote: > > On Sat, Jan 12, 2019 at 12:01 AM Greg KH wrote: > > > > > > On Fri, Jan 11, 2019 at 04:32:12PM -0800, Gwendal Grignou wrote: > > > > Prevent an empty line in /proc/self/status, allow iotop to work. > > > > > > > > iotop does not like empty lines, fails with: > > > > File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line > > > > 196, in parse_proc_pid_status > > > > key, value = line.split(':\t', 1) > > > > ValueError: need more than 1 value to unpack > > > > > > > > [reading /proc/self/status] > > > > > > > > Signed-off-by: Gwendal Grignou > > > > --- > > > > fs/proc/array.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > Why send this to me? Always use scripts/get_maintainer.pl on a patch to > > > determine who and what lists to send patches to. > > I did, your email address is on the first line: > > ./scripts/get_maintainer.pl > > 0001-CHROMIUM-FIXUP-proc-Provide-details-on-speculation-f.patch > > Greg Kroah-Hartman (commit_signer:6/4=100%) > > Ah, wait, you are making a patch against the stable kernel tree? > > We can't go back in time, you need to work against Linus's latest kernel > tree, that's why I am showing up in this list. I'm not the upstream > developer for this file. > > > "Srivatsa S. Bhat" (commit_signer:3/4=75%) > > Thomas Gleixner > > (commit_signer:3/4=75%,authored:1/4=25%,added_lines:3/28=11%) > > David Woodhouse (commit_signer:3/4=75%) > > Bo Gan (commit_signer:3/4=75%) > > Kees Cook (authored:1/4=25%,added_lines:23/28=82%) > > Konrad Rzeszutek Wilk > > (authored:1/4=25%,removed_lines:1/2=50%) > > Gwendal Grignou (authored:1/4=25%,removed_lines:1/2=50%) > > linux-kernel@vger.kernel.org (open list) > > > > > > > > And is this a new bug? What commit caused this? > > It is only in 4.4 stable. It has been introduced by: > > "484964fa3e5a0 proc: Provide details on speculation flaw mitigations" > > That really is commit fae1fa0fc6cca8beee3ab8ed71d54f9a78fa3f64 in > Linus's tree, and is in the 4.4, 4.9, 4.14, 4.16, and 4.17 kernel > releases. > > So it also is included in 5.0-rc1, if this is still an issue there, > please submit the patch to the correct developers and then the patch > will be backported to the needed stable kernel trees if you add the > correct "Fixes:" and "cc: stable@stable.kernel.org" lines to the patch. > Documentation/SubmittingPatches will tell you all about how to do this. > > > That patch adds an extra \n in front of "Speculation Store Bypass" > > that breaks iotop processing of /proc/../status. > > Why isn't iotop broken in the latest kernel release? It seems to work > for me here. iotop is not broken in ToT, only on 4.4 stable: fae1fa0fc6cca8beee3ab8ed71d54f9a78fa3f64 assumes f7a5f132b447c ("proc: faster /proc/*/status") has been applied. That patch breaks seq_printf(m, "Seccomp:\t%d\n", p->seccomp.mode); in 2: seq_puts(m, "Seccomp:\t"); seq_put_decimal_ull(m, 0, p->seccomp.mode); and seq_putc(m, '\n'); f7a5f132b447c is not applied to 4.4 stable. Comparing fae1fa0fc6 with 484964fa3e5a0, the latter adds a 'seq_putc(m, '\n');' whereas it was already there when fae1fa0fc6 was applied. 484964fa3e5a0 is adding an empty line, the patch I propose removes it. Regards, Gwendal. > > thanks, > > greg k-h