From: Gwendal Grignou <gwendal@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: acpi_als: Add trigger support
Date: Wed, 9 Dec 2020 11:01:35 -0800 [thread overview]
Message-ID: <CAPUE2uteTbf3WKngh05-hFh-TKyZGZ1-NbDwqLrW9CAi_OezTQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Ve+oXJoYqRFV_FeMrS_Kh9d_3VhVQSgqtn3BxNx9k0ZtQ@mail.gmail.com>
On Wed, Dec 9, 2020 at 7:16 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Dec 4, 2020 at 10:40 PM Gwendal Grignou <gwendal@chromium.org> wrote:
> >
> > Add timestamp channel: use standard procedure to collect timestamp.
> > As some firmware do not notify on illuminance changes, add a
>
> do -> does
Done in v2
>
> > trigger to periodically query light.
>
> Sounds like two things in one change, you have to split.
Done in v2
>
> > We can either use the device trigger, or a software trigger like sysfs
> > or hrtimer.
> >
> > This change is not backward compatible.
>
> You mean you are breaking ABI? It won't go like this.
No, I was not setting a default trigger: on machines capable of
sending ALS readout asynchronously, the user had to set a trigger in
v1. Fixed in v2, now backward compatible.
>
> > To get samples from bios that
>
> bios -> BIOS
Done in v2, submitting soon.
>
> > supports notification, we need to register the hardware trigger first:
>
> --
> With Best Regards,
> Andy Shevchenko
prev parent reply other threads:[~2020-12-09 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 20:37 [PATCH] iio: acpi_als: Add trigger support Gwendal Grignou
2020-12-05 18:26 ` Jonathan Cameron
2020-12-09 22:36 ` Gwendal Grignou
2020-12-13 14:35 ` Jonathan Cameron
2020-12-09 15:16 ` Andy Shevchenko
2020-12-09 19:01 ` Gwendal Grignou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPUE2uteTbf3WKngh05-hFh-TKyZGZ1-NbDwqLrW9CAi_OezTQ@mail.gmail.com \
--to=gwendal@chromium.org \
--cc=andy.shevchenko@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.