Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check

From: Carlo Arenas <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Git List" <git@vger.kernel.org>,
	"Elia Pinto" <gitter.spiros@gmail.com>
Subject: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
Date: Sat, 12 Mar 2022 18:37:27 -0800	[thread overview]
Message-ID: <CAPUEspgdmaztSShPd6vJpT7801_czRuBt_QaPu_W2JGOw+UqrQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqtuc2lhis.fsf@gitster.g>

On Sat, Mar 12, 2022 at 6:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> > But probably better is to just amend that to call it as "test-tool libc
> > is-glibc-2.34-or-newer" or whatever. Then just do:
> >
> >       if (__GLIBC__ > 2 || (__GLIBC__ == 2 && 34 >= __GLIBC_MINOR__))
> >               return 0;
> >       return 1;
>
> Yuck.  Then we'd have yet another libc-is-glibc-2.36-or-newer
> option, too, in the future?

Luckily that won't be needed, as this the original version (with expr)
is practically good enough even if it might be a little odd looking
and incorrect for 2.4 <= glibc <= 2.9 (which are over 10 years old).

  $ expr 2.34 \<= "2.34.9000"
  1
  $ expr 2.34 \<= ""
  0

Apologies for the confusion, and feel free to drop this patch

Carlo