All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Arenas <carenas@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Hariom Verma <hariom18599@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition
Date: Sun, 24 Nov 2019 12:15:47 -0800	[thread overview]
Message-ID: <CAPUEspjTpWsaT=pm1HLwTUQQye+WMCeWwpmC9RWkBuKQELubRw@mail.gmail.com> (raw)
In-Reply-To: <CAPUEspjAjR+QojRbC8dkoj=9adAKEv4StYYiy6hFmbMwQZ7CNw@mail.gmail.com>

On Sun, Nov 24, 2019 at 9:40 AM Carlo Arenas <carenas@gmail.com> wrote:
>
> I think the problem might come from places where the default compiler
> is still not C99 by default (ex: old CentOS)

CentOS 6.10 (using gcc 4.4.7) compiles this without problems by
default so nothing to worry about, sorry for the red herring

Carlo

PS. non GNU89 (AKA ANSI) mode will obviously break but not ONLY
because of this change

  reply	other threads:[~2019-11-24 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 13:09 [PATCH 0/1] git-compat-util.h: drop the PRIuMAX definition Hariom Verma via GitGitGadget
2019-11-24 13:09 ` [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition Hariom Verma via GitGitGadget
2019-11-24 17:06   ` Jeff King
2019-11-24 17:40     ` Carlo Arenas
2019-11-24 20:15       ` Carlo Arenas [this message]
2019-11-25  2:24     ` Junio C Hamano
2019-11-25  2:45       ` Junio C Hamano
2019-11-25  9:34         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPUEspjTpWsaT=pm1HLwTUQQye+WMCeWwpmC9RWkBuKQELubRw@mail.gmail.com' \
    --to=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=hariom18599@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.