Re: [PATCH net-next 5/7] openvswitch: Add original direction conntrack tuple to sw_flow_key.

From: Joe Stringer <joe@ovn.org>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 5/7] openvswitch: Add original direction conntrack tuple to sw_flow_key.
Date: Tue, 7 Feb 2017 13:38:51 -0800	[thread overview]
Message-ID: <CAPWQB7FaWJL3ncLOoY=KZXxBR=gQ8A4G5UCEY2OP=PBsAZzMaA@mail.gmail.com> (raw)
In-Reply-To: <CAPWQB7Hhm+dVqaOxU-56wV6MmDJw70716ir7cUAnxNnWs_a1LA@mail.gmail.com>

On 6 February 2017 at 23:15, Joe Stringer <joe@ovn.org> wrote:
> On 2 February 2017 at 17:10, Jarno Rajahalme <jarno@ovn.org> wrote:
>> @@ -79,9 +80,17 @@ static inline void ovs_ct_fill_key(const struct sk_buff *skb,
>>         key->ct.zone = 0;
>>         key->ct.mark = 0;
>>         memset(&key->ct.labels, 0, sizeof(key->ct.labels));
>> +       key->ct.orig_proto = 0;
>> +       key->ct.orig_tp.src = 0;
>> +       key->ct.orig_tp.dst = 0;
>> +       if (key->eth.type == htons(ETH_P_IP))
>> +               memset(&key->ipv4.ct_orig, 0, sizeof(key->ipv4.ct_orig));
>> +       else if (key->eth.type == htons(ETH_P_IPV6) && !sw_flow_key_is_nd(key))
>> +               memset(&key->ipv6.ct_orig, 0, sizeof(key->ipv6.ct_orig));
>
> If we only ever use these fields based on key->ct.orig_proto being
> nonzero, then we m

I think I had my email opened in two windows so truncated this
sentence somehow. I was wondering whether we can just initialize
key->ct.orig_proto and only init the others on demand.