From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298Ab2E2Qe5 (ORCPT ); Tue, 29 May 2012 12:34:57 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:39391 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380Ab2E2Qez convert rfc822-to-8bit (ORCPT ); Tue, 29 May 2012 12:34:55 -0400 MIME-Version: 1.0 In-Reply-To: <1338308088.2202.39.camel@joe2Laptop> References: <1336004953.4240.9.camel@mop> <20120526111143.GA32304@lizard> <1338307620.886.21.camel@mop> <1338308088.2202.39.camel@joe2Laptop> From: Kay Sievers Date: Tue, 29 May 2012 18:34:33 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Joe Perches Cc: Anton Vorontsov , Greg Kroah-Hartmann , Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org, Kees Cook , Colin Cross , Tony Luck , John Stultz Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2012 at 6:14 PM, Joe Perches wrote: > On Tue, 2012-05-29 at 18:07 +0200, Kay Sievers wrote: >> +bool kmsg_dump_get_line(struct kmsg_dumper *dumper, bool syslog, >> +                       const char *line, size_t size, size_t *len) >> +{ >> +     return false >> +} > > uncompilable. The damn !CONFIG_PRINTK case. :) Fixed! http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=commitdiff;h=607b6e8fa7ca61dd385d632fe51c6afc5f5374b7 Thanks, Kay